Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: constrain DTLS cipher list with OpenSSL #1335

Merged
merged 1 commit into from
Feb 23, 2025
Merged

fix: constrain DTLS cipher list with OpenSSL #1335

merged 1 commit into from
Feb 23, 2025

Conversation

achingbrain
Copy link
Contributor

Reduces the number of supported ciphers to ensure Client Hello messages are not fragmented, ECDHE-ECDSA-AES128-GCM-SHA256 takes priority and older insecure ciphers are not used.

Fixes #1333

@achingbrain
fix: constrain DTLS cipher list
a0dd549 
Reduces the number of supported ciphers to ensure Client Hello
messages are not fragmented, `ECDHE-ECDSA-AES128-GCM-SHA256`
takes priority and older insecure ciphers are not used.

Fixes paullouisageneau#1333
@achingbrain
Copy link
Contributor Author

achingbrain commented Feb 15, 2025 •
edited
Loading

I'm not sure how to unit test this properly, but I've published a fork of node-datachannel at @ipshipyard/node-datachannel patched with murat-dogan/node-datachannel#256 which also uses libdatachannel patched with this change (as well as #1211, paullouisageneau/libjuice#292 and paullouisageneau/libjuice#295 and you can see CI passing using both regular WebRTC (e.g. SDP messages exchanged out of band) and WebRTC-Direct (uses SDP munging to skip the handshake) which tests node-datachannel against pion (go - SDP munging only), webrtc-rs (rust - SDP munging only), Firefox, Chrome, and Webkit and all are compatible.

Without this change libdatachannel fails to initiate a connection to webrtc-rs, though webrtc-rs can initiate a connection to libdatachannel.

@achingbrain achingbrain mentioned this pull request Feb 15, 2025
Closed
paullouisageneau
paullouisageneau approved these changes Feb 23, 2025
View reviewed changes
Copy link
Owner

@paullouisageneau paullouisageneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thank you!

@paullouisageneau paullouisageneau changed the title fix: constrain DTLS cipher list fix: constrain DTLS cipher list with OpenSSL Feb 23, 2025
@paullouisageneau paullouisageneau merged commit 7001da9 into paullouisageneau:master Feb 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paullouisageneau paullouisageneau paullouisageneau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify DTLS handshake cipher suite?
2 participants
@achingbrain @paullouisageneau