feat: expose juice_mux_stop_listen function #291
Conversation
This is a follow-up to paullouisageneau#248 that just adds the `juice_mux_stop_listen` function to `juice.h` in order to invoke it from libdatachannel.
achingbrain
force-pushed
the
feat/expose-mux-stop-listen
branch
from
f012414 to
9953b7a
Compare
| @@ -256,7 +256,7 @@ int conn_get_addrs(juice_agent_t *agent, addr_record_t *records, size_t size) { | |||
| return get_mode_entry(agent)->get_addrs_func(agent, records, size); | |||
| } | |||
|
|
|||
| static int juice_mux_stop_listen(const char *bind_address, int local_port) { | |||
There was a problem hiding this comment.
Did this need to be static? juice_mux_listen is not static so I removed it from here otherwise it doesn't compile.
|
Or, actually yeah - we can call |
Indeed, I preferred not to expose such a function in #248 (comment) because it looks quite clumsy and misleading to me (It ignores its parameters and doesn't actually stop listening on the port). @xicilion kept it as a local function rather than cleaning it up, that's why it is static. You can indeed unregister the callback with |
This is a follow-up to #248 that just adds the
juice_mux_stop_listenfunction tojuice.hin order to invoke it from libdatachannel.