Skip to content

Modernize #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Modernize #3

wants to merge 4 commits into from

Conversation

minchinweb
Copy link
Member

@minchinweb minchinweb commented Jun 2, 2021

Hi @justinmayer !

This is hopefully all the code pieces to "modernize" this plugin. In particular:

  • move from setup.py to poetry
  • reorganize into a namespace plugin
  • add common project supports, like pre-commit config and common tasks.py
  • updated Changelog format
  • add a very basic test site

There are a few things that I can't do:

  • the repo should be renamed, likely to "nojekyll" (JM: Done!)
  • AutoPub needs to be configured
  • any prep to push the package to PyPI
  • version 2.0 released!

Let me know if there's anything else I need to do on my side to move this forward.

Once this is done, I still have several more plugins that I'm maintaining that were originally pulled the common repo. Let me know how best to move forward on those too!

@minchinweb minchinweb requested a review from justinmayer June 2, 2021 03:06
@justinmayer
Copy link
Contributor

@minchinweb: Thanks for working on this. I renamed the repository. I am traveling for the next few weeks but will try to find time to review this PR as soon as I can. 😊

and make flake8 happy
@minchinweb
Copy link
Member Author

Enjoy your trip!

@minchinweb
Copy link
Member Author

@justinmayer ready to merge?

@minchinweb
Copy link
Member Author

bump... @justinmayer is this ready to merge?

@justinmayer
Copy link
Contributor

Hi @minchinweb. Please accept my sincere apologies for the absurd delay in reviewing this pull request, which I clearly overlooked during what was a very hectic period.

In terms of what to do next, my suggestion would be to follow the steps listed in the Pelican Plugin Template README (mainly, choose an output location and then run something like pipx run cruft create https://github.com/getpelican/cookiecutter-pelican-plugin --output-dir $HOME/Desktop/nojekyll-plugin-generated) and enter the appropriate values when prompted in order to generate current, up-to-date plugin scaffolding. Then you can diff what you have here with that scaffolded plugin in order to merge the upstream template changes with your plugin's code. (In the future, it will be much easier to maintain alignment with upstream template changes via Cruft.)

Does that make sense? Let me know — I am available to help out with anything that's not clear. Once again, very sorry for the delay, and many thanks for all your patience.

@minchinweb
Copy link
Member Author

Thank you for coming back to this!

I will take a look at this again; Cruft looks like it could be a gamechanger, I hope it likes up to it's promise! I'm not sure of my timeline, but updates will be posted here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants