Add ability to open and close ticket sales #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviupadhyayula
commented
Jan 3, 2025
Comment on lines
+2512
to
+2518
| for item in quantities: | ||
| if item.get("count", 0) <= 0: | ||
| return Response( | ||
| {"detail": "Ticket quantities must be positive", "success": False}, | ||
| status=status.HTTP_400_BAD_REQUEST, | ||
| ) | ||
|
|
There was a problem hiding this comment.
This change is unrelated to the PR. Just noticed that we weren't checking that quantities being added to the cart were positive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds route for club leaders to suspend and resume ticket sales. If an event has its ticket sales paused, buyers can no longer view it via
ticketsor add them to cart. (Note that checkout initiation and completion is unaffected for now, as these components are going to be reworked for #758.)Addresses #759.
(Note: when #762 is merged in, rebase this one to
ticketing-v2.)