Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom roles and role permissions management in pgAdmin. #7310 #8631

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adityatoshniwal
Copy link
Contributor

No description provided.

Copy link
Contributor

@akshay-joshi akshay-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GUI Review Comments:

  1. Permission pop-up should be worked from the context menu, and buttons on the Object Explorer like (Filtered Row, and View/Edit Data). Currently, it is throwing a Forbidden error.ERD for Table and ERD for Database menus also show the Forbidden message.
  2. If there is no Query Tool permission then Create Script, Generate Script(from Schema Diff) should also shown the Permission Denied pop up. In any case, if the Query Tool/PSQL tab is opened with a Forbidden message then please try to fix the issue of closing tab.
  3. If registering a new server requires permission, then removing the server should also be added, or the existing permission should be renamed "Register/Remove servers," which works for both. Please check "Copy Server" as well.
  4. Checkboxes on the permissions tab look disabled when not selected. Can we change the background color to white?
  5. The PSQL Tool is missing from the Tools permission.
  6. Please test the CLI commands to add user, external user, and all other commands.
  7. As we are using the same name for Permissions then "Perform maintenance" should be renamed to "Maintenance".
  8. Disable the Query Tool and PSQL Tool workspace if there is no permission.

Code Review Comments:

  1. Create constants/enums for all the permissions like 'tools_debugger', 'tools_backup', etc... used in the JavaScript files. Or use "class AllPermissionTypes:" if possible.
  2. Check the default permissions for Role 'User' it contains "module,............,dict,weakref,doc"
  3. Add comments in the entire code wherever you feel it's needed for other developers to understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants