-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom roles and role permissions management in pgAdmin. #7310 #8631
Open
adityatoshniwal
wants to merge
2
commits into
pgadmin-org:master
Choose a base branch
from
adityatoshniwal:7310-custom-roles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for custom roles and role permissions management in pgAdmin. #7310 #8631
adityatoshniwal
wants to merge
2
commits into
pgadmin-org:master
from
adityatoshniwal:7310-custom-roles
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da41483
to
1a65d09
Compare
akshay-joshi
requested changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GUI Review Comments:
- Permission pop-up should be worked from the context menu, and buttons on the Object Explorer like (Filtered Row, and View/Edit Data). Currently, it is throwing a Forbidden error.ERD for Table and ERD for Database menus also show the Forbidden message.
- If there is no Query Tool permission then Create Script, Generate Script(from Schema Diff) should also shown the Permission Denied pop up. In any case, if the Query Tool/PSQL tab is opened with a Forbidden message then please try to fix the issue of closing tab.
- If registering a new server requires permission, then removing the server should also be added, or the existing permission should be renamed "Register/Remove servers," which works for both. Please check "Copy Server" as well.
- Checkboxes on the permissions tab look disabled when not selected. Can we change the background color to white?
- The PSQL Tool is missing from the Tools permission.
- Please test the CLI commands to add user, external user, and all other commands.
- As we are using the same name for Permissions then "Perform maintenance" should be renamed to "Maintenance".
- Disable the Query Tool and PSQL Tool workspace if there is no permission.
Code Review Comments:
- Create constants/enums for all the permissions like 'tools_debugger', 'tools_backup', etc... used in the JavaScript files. Or use "class AllPermissionTypes:" if possible.
- Check the default permissions for Role 'User' it contains "module,............,dict,weakref,doc"
- Add comments in the entire code wherever you feel it's needed for other developers to understand.
1a65d09
to
6326657
Compare
6326657
to
75dbced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.