PHP 8.4 compatibility #25
Conversation
> Http\Client\Common\Plugin\LoggerPlugin::__construct(): Implicitly marking parameter $formatter as nullable is deprecated, the explicit nullable type must be used instead
|
@dbu could you please approve the workflow? The other error is unrelated. |
|
i fixed the cs error in the 1.x branch. oh boy, this has not been updated in a while. do you have time to investigate the setup issues? hopefully we just need to allow new versions of dependencies. |
|
PHPSpec, the gift that keeps on giving 😭 I think it should be removed, and replaced with PHPUnit. |
|
Before we do any work, wouldn't it make more sense to remove EOL PHP versions too? |
|
looking how few tests we have here (and how small the component is): yes please, lets just switch to phpunit. our policy regarding dropping EOL php versions has been to drop then when they become a nuisance, but not to just drop them when all is still fine. i guess with phpunit upgrade, it would be nice to use a recent version directly - i am fine with dropping EOL versions that hinder using a recent phpunit version. |
|
Handled in #27 |
No description provided.