Skip to content

ext/tidy: simplify tidy_instantiate #18647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2025
Merged

ext/tidy: simplify tidy_instantiate #18647

merged 2 commits into from
May 25, 2025
+3 −10

Conversation

devnexen
Copy link
Member

No description provided.

nielsdos
nielsdos reviewed May 25, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tidy_instantiate is now pointless, why not replace all calls to it with object_init_ex ?

@devnexen
Copy link
Member Author

tidy_instantiate is now pointless, why not replace all calls to it with object_init_ex ?

I know but it was to keep the naming in line and keeping the change minimal.

@nielsdos
Copy link
Member

I know but it was to keep the naming in line and keeping the change minimal.

But we're here on master anyway, so it's fine to refactor that imo

@devnexen devnexen merged commit caf0a53 into php:master May 25, 2025
9 checks passed
@devnexen devnexen deleted the tidy_instantiate_simpl branch May 25, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Extension: tidy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @nielsdos