Fix silent sync #30
Open
Fix silent sync #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update my fork
With zero phase, the aux output was misleadingly silent.
electron271
approved these changes
Jun 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR was null. Grrrr! Once more with feeling. (Sigh!)
As it stands, the AUX output is silent when the module starts. This confuses some folk
including me. See: https://community.vcvrack.com/t/resonator-bad-start-bug/9619/11
and below. This is basically Xenakios's patch with the phase offset chosen so the output
is pitched at the 2nd harmonic of the sync modulator frequency. (Hope that's clear.)
The last I asked he hadn't sent a pull, and this is a long time since this was discussed
in the forum, so I figured I'd send it along. I have this patch running without issue on my
Linux boxes, but I'm not sure that you think the initially silent output is the wrong thing to
do, so I offer this pull merely as a suggestion.
Thoughts?