Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rings const part_chords #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rings const part_chords #62

wants to merge 1 commit into from

Conversation

eh2k
Copy link

@eh2k eh2k commented Dec 13, 2023

Two small improvements here.
The first is the const declaration of the chords array in the part.cc.
The second change (renaming chords to part_chords) is because of the case if you want to use the chords array with extern const float chords[] elsewhere. Imho it is not possible because there are two global chords definitions in the rings namespace. See one in the part.cc the other in the synth_string_part.cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant