Refactor data models and improve code quality across microservices

[sweep-ai]

This pull request was created by Sweep to resolve the following request by @piomin:

can you analyze that repository codebase and prepare a single PR with all suggestions you have?

Continue chatting at https://app.sweep.dev/c/a2541fca-d359-4707-b9e7-6d1084a76e00.

Purpose

This pull request aims to improve code quality, consistency, and type safety across the microservices by refactoring data models and implementing better practices in request/response handling.

Description

The changes focus on several key areas:

1. Data Model Improvements:

• Converted regular classes to data classes for better encapsulation and equality handling
• Standardized property declarations in data models
• Made properties more explicit by removing default values where appropriate
• Fixed package declarations and class organization

2. Request/Response Handling:

• Enhanced the ResponseTimeInterceptor with better logging and timing measurements
• Improved request tracking by using URI host and port instead of MDC
• Cleaned up parameter naming and formatting in controller methods

3. Code Quality:

• Made immutable properties explicit by changing var to val where appropriate
• Improved code formatting and alignment
• Added proper package declarations to previously missing files

Summary

• Refactored Conversation, CallmeRequest, CallmeResponse, and Person to data classes
• Enhanced ResponseTimeInterceptor with better request timing and logging
• Removed default values from CallmeRequest, CallmeEvent, and related models
• Fixed package declarations in CallmeResponse classes
• Changed mutable property to immutable in Person class (var age to val age)
• Improved code formatting in CallerController and other classes
• Updated request/response parameter handling for better type safety

Summary by CodeRabbit

• Refactor
  • Improved data consistency by requiring explicit values for request and response fields across multiple services.
  • Enhanced immutability in data models, making certain fields read-only after creation.
  • Improved logging clarity for request execution times.
• Style
  • Minor whitespace and naming adjustments for code clarity (no impact on functionality).

[coderabbitai]

Walkthrough

This set of changes primarily standardizes data class constructors across multiple modules by removing default property values and enforcing non-null, explicitly provided parameters. Several data classes now require all properties to be specified at instantiation, and some properties have been changed from mutable to immutable. Additionally, a class was converted to a data class to leverage automatic method generation. In one interceptor, address extraction and logging logic were updated to use explicit URI information instead of MDC, and minor code cleanups and renamings were performed. One file contains only a whitespace adjustment.

Changes

File(s)	Change Summary
.../eventdriven/cunsumerb/message/CallmeEvent.kt .../eventdriven/cunsumerb/message/CallmeResponse.kt	Removed default values from CallmeEvent and CallmeResponse data class properties; now requires explicit values for all parameters.
.../inter-caller-service/src/main/kotlin/pl/piomin/samples/caller/model/CallmeRequest.kt .../CallmeResponse.kt	Made properties non-nullable and removed default values in CallmeRequest and CallmeResponse data classes; changed id in CallmeResponse from var to val.
.../inter-caller-service/src/main/kotlin/pl/piomin/samples/caller/model/Conversation.kt	Changed Conversation from a regular class to a data class.
.../inter-callme-service/src/main/kotlin/pl/piomin/samples/callme/model/CallmeRequest.kt	Removed default values from CallmeRequest data class properties; now requires explicit values for all parameters.
.../inter-caller-service/src/main/kotlin/pl/piomin/samples/caller/client/ResponseTimeInterceptor.kt	Refactored to construct address from request URI instead of using MDC; renamed variables and parameters for clarity; updated logging format; removed unused MDC import.
.../inter-caller-service/src/main/kotlin/pl/piomin/samples/caller/controller/CallerController.kt	Adjusted whitespace in argument indentation for findByRequestId method; no functional changes.
.../intro/domain/Person.kt	Changed age property in Person data class from mutable (var) to immutable (val).

Poem

In fields of code where classes dwell,
Constructors now their stories tell—
No defaults to hide behind,
Each value clear, each type defined.
Immutability rings anew,
With data classes marching through!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 00723de and 2653ee8.

📒 Files selected for processing (9)

• event-driven/consumer-b-service/src/main/kotlin/pl/piomin/samples/eventdriven/cunsumerb/message/CallmeEvent.kt (1 hunks)
• event-driven/consumer-b-service/src/main/kotlin/pl/piomin/samples/eventdriven/cunsumerb/message/CallmeResponse.kt (1 hunks)
• inter-communication/inter-caller-service/src/main/kotlin/pl/piomin/samples/caller/client/ResponseTimeInterceptor.kt (1 hunks)
• inter-communication/inter-caller-service/src/main/kotlin/pl/piomin/samples/caller/controller/CallerController.kt (1 hunks)
• inter-communication/inter-caller-service/src/main/kotlin/pl/piomin/samples/caller/model/CallmeRequest.kt (1 hunks)
• inter-communication/inter-caller-service/src/main/kotlin/pl/piomin/samples/caller/model/CallmeResponse.kt (1 hunks)
• inter-communication/inter-caller-service/src/main/kotlin/pl/piomin/samples/caller/model/Conversation.kt (1 hunks)
• inter-communication/inter-callme-service/src/main/kotlin/pl/piomin/samples/callme/model/CallmeRequest.kt (1 hunks)
• intro-to-spring-boot/src/main/kotlin/pl/piomin/samples/intro/domain/Person.kt (1 hunks)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[piomin]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.