Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #76: Nested @context definition returns an error #77

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

kazarena
Copy link
Member

Summary

This change fixes #76.

The implementation was inspired by https://github.com/digitalbazaar/jsonld.js/blob/e2f6523b5c01f8d44a198e21e2b206586db4472e/lib/context.js#L148.

Checks

  • Passes make test

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (207e3e3) 79.88% compared to head (dfba40f) 79.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   79.88%   79.85%   -0.04%     
==========================================
  Files          20       20              
  Lines        6180     6185       +5     
==========================================
+ Hits         4937     4939       +2     
- Misses        960      962       +2     
- Partials      283      284       +1     
Files Coverage Δ
ld/context.go 82.54% <40.00%> (-0.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kazarena kazarena merged commit 257ca0d into master Oct 30, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested @context definition returns an error
1 participant