-
Notifications
You must be signed in to change notification settings - Fork 90
Contributing documentation changes
The official Pivotal UI documentation is the Pivotal UI Styleguide. The code for the styleguide lives in the pivotal-cf/pui-styleguide repo.
All text content and code examples are written in Markdown files that live in the docs
directory. To improve/add documentation, you probably only need to edit files in the docs
directory.
The preferred ways of contributing documentation changes are as follows:
This is the easiest/fastest way to make changes, but when doing this you will not be able to preview your changes in the styleguide as you're making them (you'll have to rely on GitHub's Markdown preview).
-
Find the page that you would like to edit in the
docs
directory. -
Click the "Edit this file" button (a pencil icon) and make the changes you'd like to make.
-
When finished, choose the option to commit the changes to a new branch and start a pull request.
-
Soon, someone from the Pivotal UI team will review the pull request and either accept the changes or discuss next steps.
Once the pull request is accepted, the change will go through our pipeline. Next time we deploy the styleguide to production, your change will be visible at styleguide.pivotal.io.
If you'd prefer to preview your changes as you're making them, follow these steps.
- Clone the styleguide repo to your computer and install dependencies:
git clone https://github.com/pivotal-cf/pui-styleguide.git && cd pui-styleguide && yarn
- Create a new branch for your changes:
git checkout -b fix-typo-in-buttons-docs
- Start up the styleguide locally:
yarn start
-
Make the changes you'd like to make in your code editor and commit them.
-
Push them to your new branch in our repo:
git push -u origin fix-typo-in-buttons-docs
-
Open a pull request on GitHub to merge your branch into
master
. -
Soon, someone from the Pivotal UI team will review the pull request and either accept the changes or discuss next steps.
Once the pull request is accepted, the change will go through our pipeline. Next time we deploy the styleguide to production, your change will be visible at styleguide.pivotal.io.
We use "jest" to run the unit tests. You can either run jest
or yarn run test
- Be aware that the font validator test only works if python2 is your "python" executable.