dcc: refactor slider #3414
Draft
dcc: refactor slider #3414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoolADE85
force-pushed
the
feature/dcc-refactor-slider
branch
from
5626ff1 to
0fab988
Compare
|
@T4rk1n please review (and complete if necessary) - we want this for Studio. |
T4rk1n
reviewed
Aug 26, 2025
There was a problem hiding this comment.
Can we put the test files in tests/unit, I just find it easier after that to manage test runners in ci/pre-commit if they are separated from the codebase.
| persistence_type = PersistenceTypes.local, | ||
| // eslint-disable-next-line no-magic-numbers | ||
| verticalHeight = 400, | ||
| ...rest |
Comment on lines
+9
to
+17
| enum PersistenceTypes { | ||
| 'local' = 'local', | ||
| 'session' = 'session', | ||
| 'memory' = 'memory', | ||
| } | ||
|
|
||
| enum PersistedProps { | ||
| 'value' = 'value', | ||
| } |
There was a problem hiding this comment.
Those will be the same for all the components that use ts, we can put them in the type.ts file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Contributor Checklist
optionals
CHANGELOG.md