feat: refactor tests classes

pmareke · Sep 24, 2024 · 9fda090 · 9fda090
1 parent a4a2e77
commit 9fda090
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 10 deletions.
diff --git a/tests/acceptance/delivery/api/test_heath_controller.py b/tests/acceptance/delivery/api/test_heath_controller.py
@@ -6,7 +6,7 @@
 from main import app, settings
 
 
-class TestHealthController:
+class TestHealthControllerAcceptance:
     @pytest.fixture
     def client(self) -> TestClient:
         return TestClient(app)

diff --git a/tests/acceptance/delivery/api/test_hello_controller.py b/tests/acceptance/delivery/api/test_hello_controller.py
@@ -6,7 +6,7 @@
 from main import app, settings
 
 
-class TestHelloController:
+class TestHelloControllerAcceptance:
     @pytest.fixture
     def client(self) -> TestClient:
         return TestClient(app)

diff --git a/tests/integration/hello/test_dummy_hello_client_integration.py b/tests/integration/hello/test_dummy_hello_client_integration.py
@@ -3,7 +3,7 @@
 from src.infrastructure.hello.hello_client import DummyHelloClient
 
 
-class TestDummyHelloClientIntegrtion:
+class TestDummyHelloClientIntegration:
     def test_get_name(self) -> None:
         expected_name = "Yes"
         client = DummyHelloClient()

diff --git a/tests/unit/acceptance/delivery/api/test_hello_controller.py b/tests/unit/acceptance/delivery/api/test_hello_controller.py
@@ -1,5 +1,3 @@
-import pytest
-
 from doublex import ANY_ARG, Mimic, Stub
 from expects import expect, equal
 from fastapi.testclient import TestClient
@@ -19,11 +17,8 @@ def _failing_handler(self) -> SayHelloCommandHandler:
             self.handler.execute(ANY_ARG).raises(exception)
         return self.handler  # type: ignore
 
-    @pytest.fixture
-    def client(self) -> TestClient:
-        return TestClient(app)
-
-    def test_hello_controller(self, client: TestClient) -> None:
+    def test_hello_controller(self) -> None:
+        client = TestClient(app)
         app.dependency_overrides[say_hello_command_handler] = self._failing_handler
         invalid_name = "any-invalid-name"