Skip to content

Fix pivot() to correctly accept options object as first parameter #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

Fix pivot() to correctly accept options object as first parameter #318

merged 1 commit into from
Mar 19, 2025

Conversation

elegantcoder
Copy link
Contributor

Fix pivot() to correctly accept options object as first parameter to close #317

@Bidek56
Copy link
Collaborator

Bidek56 commented Mar 16, 2025

@elegantcoder
Did you run: bun run lint:ts on your PR? Thx

@elegantcoder
Copy link
Contributor Author

@Bidek56

@elegantcoder Did you run: bun run lint:ts on your PR? Thx

Yes I did!

universalmind303
universalmind303 approved these changes Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@universalmind303 universalmind303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @elegantcoder

@universalmind303 universalmind303 merged commit dbc164d into pola-rs:main Mar 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@universalmind303 universalmind303 universalmind303 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pivot() fails when passing options as the first parameter
3 participants
@elegantcoder @Bidek56 @universalmind303