Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): Update pyo3 and numpy crates to version 0.24 #22015

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bschoenmaeckers
Copy link
Contributor

@bschoenmaeckers bschoenmaeckers commented Apr 1, 2025

This release has significant less breaking changes than the previous one 😅

@github-actions github-actions bot added build Changes that affect the build system or external dependencies python Related to Python Polars labels Apr 1, 2025
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (90094f0) to head (468149a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/conversion/datetime.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22015      +/-   ##
==========================================
- Coverage   80.99%   80.90%   -0.09%     
==========================================
  Files        1638     1639       +1     
  Lines      236856   236899      +43     
  Branches     2696     2696              
==========================================
- Hits       191840   191671     -169     
- Misses      44382    44594     +212     
  Partials      634      634              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bschoenmaeckers
Copy link
Contributor Author

I'm currently unable to fix the clippy error. It reports a unused import but when expanding the impl_set_with_mask or converting it into a concrete implementation, the error goes away.

@ritchie46
Copy link
Member

I'm currently unable to fix the clippy error. It reports a unused import but when expanding the impl_set_with_mask or converting it into a concrete implementation, the error goes away.

Can we than silence that lint for that specific code snippet?

@bschoenmaeckers
Copy link
Contributor Author

I'm currently unable to fix the clippy error. It reports a unused import but when expanding the impl_set_with_mask or converting it into a concrete implementation, the error goes away.

Can we than silence that lint for that specific code snippet?

I spammed #[allow(unused_imports)] all over the macro but I could not fix this locally. But luckily the issue is fixed upstream and will be released in pyo3 0.24.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants