Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix LazyFrame.__contains__ not issuing PerformanceWarning #22236

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

magikcarp
Copy link

Closes #21917

Changes

  • Make LazyFrame.__contains__ emit PerformanceWarning and redirection of user to use collect_schema() to mirror other methods that causes the schema to be collected.
  • Update tests to call collect_schema() directly to prevent emitting the PerformanceWarning.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Apr 12, 2025
Copy link

codecov bot commented Apr 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.78%. Comparing base (69ad1ba) to head (7c244b9).

Files with missing lines Patch % Lines
py-polars/polars/lazyframe/frame.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #22236   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files        1639     1639           
  Lines      235548   235549    +1     
  Branches     2714     2714           
=======================================
+ Hits       190278   190294   +16     
+ Misses      44630    44614   -16     
- Partials      640      641    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LazyFrame.__contains__ does not issue PerformanceWarning
1 participant