feat(ismp-grandpa): add benchmarking support #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvaincormier
force-pushed
the
feat/benchmark-ismp-grandpa
branch
from
8507b80 to
15664bb
Compare
seunlanlege
reviewed
Dec 16, 2024
seunlanlege
reviewed
Dec 16, 2024
seunlanlege
reviewed
Dec 16, 2024
seunlanlege
reviewed
Dec 16, 2024
sylvaincormier
force-pushed
the
feat/benchmark-ismp-grandpa
branch
from
a970efb to
549c119
Compare
seunlanlege
reviewed
Dec 17, 2024
seunlanlege
reviewed
Dec 17, 2024
seunlanlege
requested changes
Dec 17, 2024
sylvaincormier
force-pushed
the
feat/benchmark-ismp-grandpa
branch
2 times, most recently
from
b92289b to
549c119
Compare
…ions - Add runtime benchmarking support for ismp-grandpa and integrate `frame-benchmarking`. - Parameterize WeightInfo methods to scale costs according to the number of state machines. - Update pallet calls to use parameterized weights for add/remove extrinsics. - Incorporate empirical benchmark results for more accurate weight calculations. - Cleanup and remove outdated files.
sylvaincormier
force-pushed
the
feat/benchmark-ismp-grandpa
branch
from
2df1dff to
2954a32
Compare
seunlanlege
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements benchmarking support for
ismp-grandpa, addressing issue #350. The implementation includes:WeightInfotrait and default weight implementationChanges include
Related issues
Closes #350