Design implementation pass of Song Select v2

[frenzibyte]

peppynote: took over this PR to knock some sense into things for review. this is a working draft until further notice!

• Depends on Fix carousel handling of bleed areas #32760
• Depends on Allow showing "unknown" state on status pill #32759
• Depends on Add new icons, font templates, statistics naming changes and colour updates #32764

[peppy]

First impressions aren't great:

Left and right halves are overlapping with a pretty normal aspect ratio. @frenzibyte can you confirm this is how you left things and I haven't fucked something up?

[peppy]

Leaderboard doesn't seem to show placeholders on failures:

osu.2025-04-08.at.07.20.43.mp4

[peppy]

Something is going very wrong with this display:

[frenzibyte]

• For the wedge/leaderboard measurements, yes this is how things stayed. I think the fix would be to limit the size of the wedge to not eat the header, roughly 650px last time I tried.

• For leaderboard issues, the design has not been hooked up with a fetching backend yet (see code), also from previous PR chain:

  This branch in its current state does not hook up the rankings section with actual score fetching backend yet. I've used Extract leaderboard fetch logic from song select beatmap leaderboard drawable #32494 temporarily during my own testing and also to record the preview video below. I've left the code necessary to consume the components by the linked PR commented, so that if the PR goes in then attaching it to the components here is simple.

  TL;DR: I've made functionality of leaderboard dependant on Extract leaderboard fetch logic from song select beatmap leaderboard drawable #32494

  Design implementations can be checked using TestSceneBeatmapRankingsWedge.

• For the wedge statistics looking broken on 4:3, it is also an issue that I'm not yet sure how to fix and I've left it as a follow-up task / up to discussion (since it's a minor issue surrounded by the gigantic diff of everything design). I'm foreseeing the right-hand difficutly statistics shortening to CS/OD/HP/AR to give breathing room for the left-hand statistics.

[smoogipoo]

Without doing a full review, I'll just mention that this is causing a beatmap load on the update thread resulting in FPS spikes when loading beatmaps.

[frenzibyte]

Good point, I guess this explains why previous BeatmapInfoWedge was performing asynchronous load of content, pointless move from me to remove that in here.

[peppy]

I've done what I can with this PR, but I'm still not happy to merge it. There's too many issues with implementation details to even start reviewing. I've voiced concerns with @frenzibyte and he's going to make an attempt to split out the changes here into compartmentalised pieces with the following in mind:

• The "placeholder functionality" – data hookups or otherwise – in new components should either match the original component in functionality and test coverage, or be removed. One of the major issues I have had during review is that things are implemented just enough to make it look like they work but once you delve into the code you realise that's a facade. A good example is checking this new code which has functional and code quality issues – the null case doesn't clear existing display, and the check for matching labels creates drawables for no reason.
• Any of the follow up commits and fixes I've made should be squashed down (they don't need to exist). There should only be one (or a handful of relevant) commits per new component
• Each new component should get its own PR, unless multiple components are very closely related and the resultant PR size is <500 LoC changed
• New component PRs should not be touching any existing code (unless it's only a few stray lines)
• All design updates / functionality changes to existing components should be in their own PR(s)

I've already split out some changes in #32817, #32818, #32819. There are around 65 files left to work with.

Will leave this PR open for now, as it may be used to compare on an ongoing basis, but eventually this will be closed with new 100% isolated PRs taking its place.

[peppy]

As commented.