Update the code to not use trigger error or error log in production #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Plugin Check https://wordpress.org/plugins/plugin-check/ reports the following messages:
|
rstefan1
requested changes
Apr 28, 2025
| flock( $gitium_lock_handle, LOCK_UN ); | ||
| fclose( $gitium_lock_handle ); | ||
| } | ||
| endif; | ||
|
|
||
| // Merges the commits with remote and pushes them back | ||
| function gitium_merge_and_push( $commits ) { | ||
| global $git; | ||
| global $git; |
There was a problem hiding this comment.
It looks like the indentation is inconsistent.
| if ( $git->is_dirty() && $git->add() > 0 ) { | ||
| $commit = $git->commit( $commitmsg ); | ||
| if ( ! $commit ) { | ||
| wp_die( 'Error: Could not commit local changes.', 'Gitium Error', [ 'response' => 500 ] ); |
There was a problem hiding this comment.
Suggested change
| wp_die( 'Error: Could not commit local changes.', 'Gitium Error', [ 'response' => 500 ] ); | |
| wp_die( 'Could not commit local changes.', 'Gitium Error', [ 'response' => 500 ] ); |
|
|
||
| if ( ! gitium_merge_and_push( $commits ) ) { | ||
| $error = $git->get_last_error(); | ||
| wp_die( 'Error: Merge & push failed. ' . ( is_string( $error ) ? $error : '' ), 'Gitium Error', [ 'response' => 500 ] ); |
There was a problem hiding this comment.
Suggested change
| wp_die( 'Error: Merge & push failed. ' . ( is_string( $error ) ? $error : '' ), 'Gitium Error', [ 'response' => 500 ] ); | |
| wp_die( 'Merge & push failed. ' . ( is_string( $error ) ? $error : '' ), 'Gitium Error', [ 'response' => 500 ] ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.