Skip to content

Fix extra padding on SelectPanel with groups #5869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

hectahertz
Copy link
Contributor

@hectahertz hectahertz commented Apr 3, 2025

Closes https://github.com/github/primer/issues/4830

Changelog

Changed

Changes the ActionList mode to full when groups are present so we don't have that extra padding

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

(with modern action list FF ONLY)

Before
Screenshot 2025-04-03 at 19 14 41

After
Screenshot 2025-04-03 at 21 20 09

Merge checklist

@hectahertz hectahertz requested a review from a team as a code owner April 3, 2025 17:15
@hectahertz hectahertz requested a review from TylerJDev April 3, 2025 17:15
Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: 3ee082c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hectahertz hectahertz marked this pull request as draft April 3, 2025 17:16
Copy link
Contributor

github-actions bot commented Apr 3, 2025

Uh oh! @hectahertz, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations:

  • Images should have meaningful alternative text (alt text) at line 27
  • Images should have meaningful alternative text (alt text) at line 32

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 3, 2025
Copy link
Contributor

github-actions bot commented Apr 3, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Apr 3, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 99.73 KB (-0.04% 🔽)
packages/react/dist/browser.umd.js 99.95 KB (+0.02% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5869 April 3, 2025 17:31 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5869 April 3, 2025 17:45 Inactive
@hectahertz hectahertz force-pushed the hectahertz/fix-padding-selectpanel-groups branch from 66c4c1a to 51ff6a1 Compare April 3, 2025 19:22
@hectahertz hectahertz marked this pull request as ready for review April 3, 2025 19:23
@hectahertz hectahertz requested a review from a team as a code owner April 3, 2025 19:23
@hectahertz hectahertz requested a review from emilybrick April 3, 2025 19:23
@github-actions github-actions bot requested a deployment to storybook-preview-5869 April 3, 2025 19:26 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5869 April 3, 2025 19:38 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5869 April 3, 2025 19:53 Inactive
Copy link
Contributor

@emilybrick emilybrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshots LGTM

francinelucca

This comment was marked as resolved.

@github-actions github-actions bot temporarily deployed to storybook-preview-5869 April 4, 2025 02:28 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 4, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-5869 April 25, 2025 03:06 Abandoned
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 25, 2025
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed update snapshots labels Apr 25, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-5869 April 25, 2025 03:18 Abandoned
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 25, 2025
@francinelucca francinelucca marked this pull request as ready for review April 25, 2025 03:20
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 25, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot requested a deployment to storybook-preview-5869 April 25, 2025 03:23 Abandoned
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 25, 2025
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/374856

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Apr 25, 2025
Copy link
Contributor

@emilybrick emilybrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay! thank you for this polish!!

@francinelucca francinelucca enabled auto-merge April 26, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh status: review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants