-
Notifications
You must be signed in to change notification settings - Fork 610
feat: add support for size to Blankslate #5899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
🦋 Changeset detectedLatest commit: b15f6d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Is there any way we can get it out of experimental? I mean, is it really experimental?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I noticed that the icon size for small
should be 24px
, but it is 16 at the moment. Can we change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as long as the visual changes are expected 👀
Some more updates were added to the Figma version, specifically to the small variant: https://www.figma.com/design/GCvY3Qv8czRgZgvl1dG6lp/Primer-Web?node-id=4398-2383&t=T3iXg81O8v9mxzrZ-4 |
@lukasoppermann just made the two updates! (Icon and small variant, not spacious padding) |
Hey @joshblack, great. Some minor points:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes, all that is left is to make sure that in the small variant, the actions use the small variant as well.
Closes https://github.com/github/primer/issues/4863
Changelog
New
size
toBlankslate
Changed
Removed
Rollout strategy