-
Notifications
You must be signed in to change notification settings - Fork 605
test(e2e): update Banner to take screenshots off of the storybook root #5918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
size-limit report 📦
|
…primer/react into test/update-tests-to-use-storybook-root
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, lovely! Now we have to do all the others lol
Update our e2e test setup for Banner to only screenshot the component instead of the overall page. This helps to reduce our overall screenshot sizes and also makes it easier to detect differences in the UI for reviewing.
Changelog
New
Changed
Removed
Rollout strategy
This is a change to how we snapshot in an e2e test and does not impact the public API