Skip to content

test(e2e): update Banner to take screenshots off of the storybook root #5918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Apr 11, 2025

Update our e2e test setup for Banner to only screenshot the component instead of the overall page. This helps to reduce our overall screenshot sizes and also makes it easier to detect differences in the UI for reviewing.

Changelog

New

Changed

  • Update our e2e tests for Banner to only snapshot the storybook root
  • Update padding in our global storybook styles so that padding is added on the storybook root

Removed

Rollout strategy

  • None; if selected, include a brief description as to why

This is a change to how we snapshot in an e2e test and does not impact the public API

Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: 6d354d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Apr 11, 2025
@joshblack joshblack added skip changeset This change does not need a changelog and removed staff Author is a staff member labels Apr 11, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-5918 April 11, 2025 16:46 Abandoned
Copy link
Contributor

github-actions bot commented Apr 11, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.22 KB (0%)
packages/react/dist/browser.umd.js 104.55 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5918 April 11, 2025 16:57 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5918 April 11, 2025 17:11 Inactive
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 11, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

@hectahertz hectahertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, lovely! Now we have to do all the others lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants