Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Refactor halo2 backend #269

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Refactor halo2 backend #269

merged 7 commits into from
Jul 10, 2024

Conversation

leolara
Copy link
Collaborator

@leolara leolara commented Jul 9, 2024

No description provided.

@leolara leolara requested a review from alxkzmn July 9, 2024 09:26
@alxkzmn
Copy link
Collaborator

alxkzmn commented Jul 9, 2024

@leolara the test is failing, could you please check? Also, there are changes to k calculation in my other pull request #268, could we first merge them?

leolara added 2 commits July 9, 2024 14:54
…he-k-value-from-the-number-of-rows-of-the-compilationunit' into leo/refactor-halo2
@leolara
Copy link
Collaborator Author

leolara commented Jul 10, 2024

Done both things

Copy link
Collaborator

@alxkzmn alxkzmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should I merge?

@leolara leolara merged commit 6bbe1fe into chiquito-2024 Jul 10, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants