This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Remove the Halo2 frontend ConstraintSystem #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alxkzmn let's get this one that the imported columns and expressions are still from halo2 frontend and gives an error if there are. The rest is cool that it does not depend of the halo2 frontend at all |
leolara
reviewed
Aug 5, 2024
src/plonkish/backend/halo2.rs
Outdated
| fn configure_columns_sub_circuit(&mut self, meta: &mut ConstraintSystem<F>) { | ||
| let mut advice_columns = HashMap::<UUID, Column<Advice>>::new(); | ||
| let mut fixed_columns = HashMap::<UUID, Column<Fixed>>::new(); | ||
| fn configure_halo2_columns(&mut self, meta: &mut ConstraintSystemBuilder<F>) { |
There was a problem hiding this comment.
@alxkzmn why is called meta here but cs_builder somewhere. meta was the name we were using in the times of zkevm
There was a problem hiding this comment.
I'll change it to constraint system too, meta is not a very meaningful name but it is used in Halo2 code.
leolara
reviewed
Aug 5, 2024
|
|
||
| fn convert_poly(&self, meta: &mut VirtualCells<'_, F>, src: &PolyExpr<F>) -> Expression<F> { | ||
| impl<F: PrimeField> ConstraintSystemBuilder<F> { |
There was a problem hiding this comment.
@alxkzmn I think all the impl of ConstraintSystemBuilder should be after the struct defintion
leolara
approved these changes
Aug 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a better approach to Halo2 middleware compilation than #277. It eliminates the need for TableColumns that are a purely frontend concept. If we choose to proceed with this path, we can completely remove the dependency on Halo2 frontend. I have prepared the corresponding changes here: 93f9553