Skip to content

Commit 2c17011

Browse files
manjunath-grlrestyled-commits
manjunath-grl
and
restyled-commits
authored
Fix YAML script issues Dec 18 (#31060)
* Fixes issues: 87,88,89,90,91,93,94 Modified tests: TC_G_2_3 TC_IDM_4_2 TC_I_2_2 TC_OPSTATE_2_2 TC_OPSTATE_2_5 TC_REFALM_2_2 TC_S_2_3 TC_S_3_1 * Auto generated files * Fixes issue: 81, 84 TC_DISHM_1_1 TC_DISHM_2_1 TC_SWTCH_1_1 TC_SWTCH_2_1 TC_SWTCH_2_2 TC_SWTCH_3_2 TC_TCCM_2_1 * Restyled by whitespace * Fixes issue: 95. 96 * Modified init.py to run the test APPOBSERVER againts TV-app * Remove TC-APPOBSERVER-1.13 test * Fixes issue: 83 * Remove APPOBSERVER from init.py * Updated TC-S-3.1 manual test. * Restyled by whitespace --------- Co-authored-by: Restyled.io <commits@restyled.io>
1 parent 9277121 commit 2c17011

23 files changed

+1131
-637
lines changed

‎src/app/tests/suites/certification/PICS.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -757,6 +757,12 @@ PICS:
757757
"Does the device implement an Application Device Type on any endpoint"
758758
id: APPDEVICE.S
759759

760+
# Content App Observer Cluster
761+
- label:
762+
"Does the device implement the Content App Observer cluster as a
763+
server?"
764+
id: APPOBSERVER.S
765+
760766
# Actions Cluster Test Plan
761767
- label: "Does the device implement the Actions cluster as a server?"
762768
id: ACT.S

‎src/app/tests/suites/certification/Test_TC_CADMIN_1_3.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ tests:
391391
verification: |
392392
On TH_CR2 send the below command
393393
394-
./chip-tool pairing open-commissioning-window 2 1 PIXIT.CADMIN.CwDuration 1000 3840 --commissioner-name beta
394+
./chip-tool pairing open-commissioning-window nodeId2 endpoint PIXIT.CADMIN.CwDuration 1000 3840 --commissioner-name beta
395395
396396
Verify the Open commisioning window on the DUT_CE(all-cluster-app) Log:
397397

‎src/app/tests/suites/certification/Test_TC_DISHM_1_1.yaml

+19-19
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,11 @@ tests:
3535
verification: |
3636
./chip-tool dishwashermode read cluster-revision 1 1
3737
38-
Verify the "ClusterRevision" value is of unit16 and reflects the highest revision number (2) on the TH(Chip-tool) and below is the sample log provided for the raspi platform:
38+
Verify the "ClusterRevision" value is of unit16 and reflects the highest revision number 2 on the TH(Chip-tool) and below is the sample log provided for the raspi platform:
3939
40-
[1690365584.246794][27436:27438] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_FFFD DataVersion: 1130015440
41-
[1690365584.246860][27436:27438] CHIP:TOO: ClusterRevision: 2
40+
CHIP:DMG : }
41+
CHIP:TOO : Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_FFFD DataVersion: 2488070594
42+
CHIP:TOO : ClusterRevision: 2
4243
disabled: true
4344

4445
- label: "Step 3: TH reads from the DUT the FeatureMap attribute."
@@ -56,32 +57,31 @@ tests:
5657
./chip-tool dishwashermode read attribute-list 1 1
5758
5859
Verify the "AttributeList " should include the mandatory attributes (values 0, 1),
59-
- Global attributes (value 65533, 65532, 65531, 65530, 65529 and 65528) and
60+
- Global attributes (value 65533, 65532, 65531, 65529 and 65528) and
6061
- List may include optional attribute(value 0x0002), if DISHM.S.A0002(StartUpMode) supports,
6162
- List contains feature dependent attribute (values 0x0003), if DISHM.S.F00(DEPONOFF) is true on the TH(Chip-tool) Log and below is the sample log provided for the raspi platform:
6263
63-
[1689930814.439457][300741:300743] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_FFFB DataVersion: 2031856391
64-
[1689930814.439500][300741:300743] CHIP:TOO: AttributeList: 10 entries
65-
[1689930814.439520][300741:300743] CHIP:TOO: [1]: 0
66-
[1689930814.439538][300741:300743] CHIP:TOO: [2]: 1
67-
[1689930814.439565][300741:300743] CHIP:TOO: [3]: 2
68-
[1689930814.439584][300741:300743] CHIP:TOO: [4]: 3
69-
[1689930814.439599][300741:300743] CHIP:TOO: [5]: 65528
70-
[1689930814.439602][300741:300743] CHIP:TOO: [6]: 65529
71-
[1689930814.439604][300741:300743] CHIP:TOO: [7]: 65530
72-
[1689930814.439616][300741:300743] CHIP:TOO: [8]: 65531
73-
[1689930814.439619][300741:300743] CHIP:TOO: [9]: 65532
74-
[1689930814.439621][300741:300743] CHIP:TOO: [10]: 65533
64+
[1696402605.599359][7921:7923] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_FFFB DataVersion: 712950283
65+
[1696402605.599377][7921:7923] CHIP:TOO: AttributeList: 9 entries
66+
[1696402605.599382][7921:7923] CHIP:TOO: [1]: 0
67+
[1696402605.599385][7921:7923] CHIP:TOO: [2]: 1
68+
[1696402605.599388][7921:7923] CHIP:TOO: [3]: 2
69+
[1696402605.599391][7921:7923] CHIP:TOO: [4]: 3
70+
[1696402605.599393][7921:7923] CHIP:TOO: [5]: 65528
71+
[1696402605.599396][7921:7923] CHIP:TOO: [6]: 65529
72+
[1696402605.599399][7921:7923] CHIP:TOO: [7]: 65531
73+
[1696402605.599402][7921:7923] CHIP:TOO: [8]: 65532
74+
[1696402605.599404][7921:7923] CHIP:TOO: [9]: 65533
7575
disabled: true
7676

7777
- label: "Step 5: TH reads from the DUT the EventList attribute."
7878
verification: |
7979
./chip-tool dishwashermode read event-list 1 1
8080
81-
Verify "EventList" contains a list of supported events, for this cluster the list is emty(0 entries) on the TH(Chip-tool) Log and below is the sample log provided for the raspi platform:
81+
* Step 5 is currently not supported and SHALL be skipped.
8282
83-
[1689996691.141081][359868:359870] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_FFFA DataVersion: 1427220838
84-
[1689996691.141341][359868:359870] CHIP:TOO: EventList: 0 entries
83+
[1696402636.316151][7926:7928] CHIP:DMG: }
84+
[1696402636.316183][7926:7928] CHIP:TOO: Response Failure: IM Error 0x00000586: General error: 0x86 (UNSUPPORTED_ATTRIBUTE)
8585
disabled: true
8686

8787
- label: "Step 6: TH reads from the DUT the AcceptedCommandList attribute."

‎src/app/tests/suites/certification/Test_TC_DISHM_2_1.yaml

+6-4
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# limitations under the License.
1414
# Auto-generated scripts for harness use only, please review before automation. The endpoints and cluster names are currently set to default
1515

16-
name: 263.3.1. [TC-DISHM-2.1] ChangeToModeWithStatus Verification DUT as Server
16+
name: 263.3.1. [TC-DISHM-2.1] Change to Mode functionality with DUT as Server
1717

1818
PICS:
1919
- DISHM.S
@@ -38,6 +38,7 @@ tests:
3838
3939
Verify that the DUT response contains list of ModeOptionsStruct entries
4040
- Verify that the list has two or more entries
41+
- Verify that PIXIT.DISHM.MODE_CHANGE_FAIL is one of supported_modes_dut
4142
- Save the Mode field values as supported_modes_dut on the TH (Chip-tool) and below is the sample log provided for the raspi platform:
4243
4344
[1689998005.121163][360287:360289] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0059 Attribute 0x0000_0000 DataVersion: 1994417976
@@ -108,13 +109,13 @@ tests:
108109
- label:
109110
"Step 5: Manually put the device in a state from which it will FAIL to
110111
transition to PIXIT.DISHM.MODE_CHANGE_FAIL"
111-
PICS: DISHM.S.M.CAN_TEST_MODE_FAILURE
112+
PICS: DISHM.S.M.CAN_TEST_MODE_FAILURE && DISHM.S.M.CAN_MANUALLY_CONTROLLED
112113
verification: |
113114
Manual operation required
114115
disabled: true
115116

116117
- label: "Step 6: TH reads from the DUT the CurrentMode attribute."
117-
PICS: DISHM.S.A0001
118+
PICS: DISHM.S.A0001 && DISHM.S.M.CAN_MANUALLY_CONTROLLED
118119
verification: |
119120
./chip-tool dishwashermode read current-mode 1 1
120121
@@ -157,12 +158,13 @@ tests:
157158
- label:
158159
"Step 9: Manually put the device in a state from which it will
159160
SUCCESSFULLY transition to PIXIT.DISHM.MODE_CHANGE_OK"
161+
PICS: DISHM.S.M.CAN_MANUALLY_CONTROLLED
160162
verification: |
161163
Manual operation required
162164
disabled: true
163165

164166
- label: "Step 10: TH reads from the DUT the CurrentMode attribute."
165-
PICS: DISHM.S.A0001
167+
PICS: DISHM.S.A0001 && DISHM.S.M.CAN_MANUALLY_CONTROLLED
166168
verification: |
167169
./chip-tool dishwashermode read current-mode 1 1
168170

‎src/app/tests/suites/certification/Test_TC_DRLK_2_5.yaml

+31-10
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ name:
1919

2020
PICS:
2121
- DRLK.S
22+
- DRLK.S.F08
2223

2324
config:
2425
nodeId: 0x12344321
@@ -84,7 +85,8 @@ tests:
8485
value: null
8586

8687
- label:
87-
"Step 1: TH reads NumberOfWeekDay SchedulesSupportedPerUser attribute"
88+
"Step 1: TH reads NumberOfWeekDay SchedulesSupportedPerUser attribute
89+
and saves for future use"
8890
PICS: DRLK.S.F04 && DRLK.S.A0014
8991
command: "readAttribute"
9092
attribute: "NumberOfWeekDaySchedulesSupportedPerUser"
@@ -94,7 +96,9 @@ tests:
9496
minValue: 0
9597
maxValue: 255
9698

97-
- label: "Step 2: TH reads NumberOfTotalUsers Supported attribute"
99+
- label:
100+
"Step 2: TH reads NumberOfTotalUsers Supported attribute and saves for
101+
future use"
98102
PICS: DRLK.S.F08 && DRLK.S.A0011
99103
command: "readAttribute"
100104
attribute: "NumberOfTotalUsersSupported"
@@ -104,7 +108,11 @@ tests:
104108
minValue: 0
105109
maxValue: 65534
106110

107-
- label: "Step 3: TH send Set Week Day Schedule Command"
111+
- label:
112+
"Step 3: TH send Set Week Day Schedule Command to DUT with the
113+
following values : a)WeekDayIndex as 1 b)UserIndex as 1 c)DaysMaskMap
114+
as 2 d)StartHour as 15 e)StartMinute as 45 f)EndHour as 16 g)EndMinute
115+
as 55 "
108116
PICS: DRLK.S.F04 && DRLK.S.C0b.Rsp
109117
command: "SetWeekDaySchedule"
110118
arguments:
@@ -125,7 +133,9 @@ tests:
125133
value: 55
126134

127135
#issue #18591
128-
- label: "Step 4: TH send Get Week Day Schedule Command to DUT"
136+
- label:
137+
"Step 4: TH send Get Week Day Schedule Command to DUT with
138+
a)WeekDayIndex as 1 b)UserIndex as 1 "
129139
PICS: DRLK.S.F04 && DRLK.S.C0c.Rsp && DRLK.S.C0c.Tx
130140
command: "GetWeekDaySchedule"
131141
arguments:
@@ -157,7 +167,11 @@ tests:
157167
hasValue: true
158168
minValue: 55
159169

160-
- label: "Step 5: TH send Set Week Day Schedule Command"
170+
- label:
171+
"Step 5: TH send Set Week Day Schedule Command to DUT with the
172+
following values : a)WeekDayIndex as 0 (invalid value) b)UserIndex as
173+
1 c)DaysMaskMap as 7 (invalid value) d)StartHour as 15 e)StartMinute
174+
as 45 f)EndHour as 16 g)EndMinute as 55"
161175
PICS: DRLK.S.F04 && DRLK.S.C0b.Rsp
162176
command: "SetWeekDaySchedule"
163177
arguments:
@@ -179,7 +193,9 @@ tests:
179193
response:
180194
error: INVALID_COMMAND
181195

182-
- label: "Step 6: TH send Get Week Day Schedule Command to DUT"
196+
- label:
197+
"Step 6: TH send Get Week Day Schedule Command to DUT : a)WeekDayIndex
198+
as 0 b)UserIndex as 1 "
183199
PICS: DRLK.S.F04 && DRLK.S.C0c.Rsp && DRLK.S.C0c.Tx
184200
command: "GetWeekDaySchedule"
185201
arguments:
@@ -213,8 +229,9 @@ tests:
213229
hasValue: false
214230

215231
- label:
216-
"Step 7: TH sends Get Week Day Schedule Command to DUT for
217-
non-existent User"
232+
"Step 7: TH sends Get Week Day Schedule Command to DUT with following
233+
values: a)WeekDayIndex as 1 (index of existing Schedule entry)
234+
b)UserIndex as 2 (index on non-existent User)"
218235
PICS: DRLK.S.F04 && DRLK.S.C0c.Rsp && DRLK.S.C0c.Tx
219236
command: "GetWeekDaySchedule"
220237
arguments:
@@ -247,7 +264,9 @@ tests:
247264
constraints:
248265
hasValue: false
249266

250-
- label: "Step 8: TH sends Clear Week Day Schedule Command to DUT"
267+
- label:
268+
"Step 8: TH sends Clear Week Day Schedule Command to DUT with :
269+
a)WeekDayIndex as 1 b)UserIndex as 1"
251270
PICS: DRLK.S.F04 && DRLK.S.C0d.Rsp
252271
command: "ClearWeekDaySchedule"
253272
arguments:
@@ -257,7 +276,9 @@ tests:
257276
- name: "UserIndex"
258277
value: 1
259278

260-
- label: "Step 9: TH sends Get Week Day Schedule Command to DUT"
279+
- label:
280+
"Step 9: TH sends Get Week Day Schedule Command to DUT with following
281+
values: a)WeekDayIndex as 1 b)UserIndex as 1"
261282
PICS: DRLK.S.F04 && DRLK.S.C0c.Rsp && DRLK.S.C0c.Tx
262283
command: "GetWeekDaySchedule"
263284
arguments:

0 commit comments

Comments
 (0)