Skip to content

Commit 9a00cb9

Browse files
Update specification revision and test (#37367) (#37463)
* Spec revisions: Update to 1.4.1 * TC-BINFO-2.1: Update for dot requirements * minor rewording * Restyled by prettier-yaml * Update expected value in test --------- Co-authored-by: Restyled.io <commits@restyled.io>
1 parent 9bdfc49 commit 9a00cb9

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/app/SpecificationDefinedRevisions.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ namespace Revision {
3131
* See section 8.1.1. "Revision History" in the "Interaction Model
3232
* Specification" chapter of the core Matter specification.
3333
*/
34-
inline constexpr InteractionModelRevision kInteractionModelRevision = 11;
34+
inline constexpr InteractionModelRevision kInteractionModelRevision = 12;
3535
inline constexpr uint8_t kInteractionModelRevisionTag = 0xFF;
3636

3737
/**
@@ -50,7 +50,7 @@ inline constexpr uint16_t kDataModelRevision = 18;
5050
* See section 11.1.5.22. "SpecificationVersion Attribute" in "Service and
5151
* Device Management" chapter of the core Matter specification.
5252
*/
53-
inline constexpr uint32_t kSpecificationVersion = 0x01040000;
53+
inline constexpr uint32_t kSpecificationVersion = 0x01040100;
5454

5555
} // namespace Revision
5656
} // namespace chip

src/app/tests/suites/TestBasicInformation.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ tests:
207207
attribute: "SpecificationVersion"
208208
response:
209209
# For now all-clusters-app has a version 1.4.
210-
value: 0x01040000
210+
value: 0x01040100
211211

212212
- label: "Read the Max Paths Per Invoke value"
213213
command: "readAttribute"

src/app/tests/suites/certification/Test_TC_BINFO_2_1.yaml

+4-4
Original file line numberDiff line numberDiff line change
@@ -715,16 +715,16 @@ tests:
715715
response:
716716
value: ProductAppearancevalue
717717

718+
# This list should be expanded as we expand the TH to support more specification revisions
718719
- label:
719-
"Step 62: SpecificationVersion value should in the inclusive range of
720-
(0x01040000 to 0x0104FF00) and the lower 8 bits are set to zero."
720+
"Step 62: SpecificationVersion value should be set to a valid Major,
721+
Minor, and Dot version with the lower 8 bits set to zero."
721722
command: "readAttribute"
722723
attribute: "SpecificationVersion"
723724
response:
724725
saveAs: SpecificationVersionValue
725726
constraints:
726-
minValue: 0x01040000
727-
maxValue: 0x0104FF00
727+
anyOf: [0x01040000, 0x01040100]
728728
hasMasksClear: [0x1, 0x2, 0x4, 0x8, 0x10, 0x20, 0x40, 0x80]
729729

730730
- label:

0 commit comments

Comments
 (0)