Skip to content

Commit 9c49f28

Browse files
authored
Changed timing in TC-CC-3.1 to fix the wrap problem and removed manual steps (#37336)
* steps 1x and 2x * updated 3x and 4x * updated 3x * deleted manual steps from 3x * Updated labels in 3b and 3c * updated comments * removed comments * updated 2x and 3x with tolerance in change and added comments * updated 4x, 5x with tolerance in change and added comments
1 parent d389bf4 commit 9c49f28

File tree

1 file changed

+63
-78
lines changed

1 file changed

+63
-78
lines changed

src/app/tests/suites/certification/Test_TC_CC_3_1.yaml

+63-78
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ tests:
3939
arguments:
4040
value: 0
4141

42-
- label: "Step 1b: H sends On command to DUT"
42+
- label: "Step 1b: TH sends On command to DUT"
4343
PICS: OO.S.C01.Rsp
4444
cluster: "On/Off"
4545
command: "On"
@@ -98,14 +98,15 @@ tests:
9898
- name: "ms"
9999
value: 10000
100100

101+
# In 10s, the value will have changed by (120-60)*10/30 = 20. A 15% tolerance is 3, so value must be in range 80+/-3 => [77, 83]
101102
- label: "Step 2c: TH reads CurrentHue attribute from DUT"
102103
PICS: CC.S.F00 && CC.S.A0000
103104
command: "readAttribute"
104105
attribute: "CurrentHue"
105106
response:
106107
constraints:
107-
minValue: 68
108-
maxValue: 92
108+
minValue: 77
109+
maxValue: 83
109110

110111
- label: "Wait 10s"
111112
PICS: CC.S.F00
@@ -116,14 +117,15 @@ tests:
116117
- name: "ms"
117118
value: 10000
118119

120+
# In 20s, the value will have changed by (120-60)*20/30 = 40. A 15% tolerance is 6, so value must be in range 100+/-6 => [94, 106]
119121
- label: "Step 2d: TH reads CurrentHue attribute from DUT"
120122
PICS: CC.S.F00 && CC.S.A0000
121123
command: "readAttribute"
122124
attribute: "CurrentHue"
123125
response:
124126
constraints:
125-
minValue: 85
126-
maxValue: 115
127+
minValue: 94
128+
maxValue: 106
127129

128130
- label: "Wait 10s"
129131
PICS: CC.S.F00
@@ -134,14 +136,15 @@ tests:
134136
- name: "ms"
135137
value: 10000
136138

139+
# In 30s, the value will have changed by (120-60)*30/30 = 60. A 15% tolerance is 9, so value must be in range 120+/-9 => [111, 129]
137140
- label: "Step 2e: TH reads CurrentHue attribute from DUT"
138141
PICS: CC.S.F00 && CC.S.A0000
139142
command: "readAttribute"
140143
attribute: "CurrentHue"
141144
response:
142145
constraints:
143-
minValue: 102
144-
maxValue: 138
146+
minValue: 111
147+
maxValue: 129
145148

146149
- label: "Wait 5s"
147150
PICS: CC.S.F00
@@ -158,8 +161,8 @@ tests:
158161
attribute: "CurrentHue"
159162
response:
160163
constraints:
161-
minValue: 102
162-
maxValue: 138
164+
minValue: 111
165+
maxValue: 129
163166

164167
- label:
165168
"Step 3a: TH sends MoveToHue command to DUT with Hue=60,
@@ -206,61 +209,45 @@ tests:
206209
- name: "OptionsOverride"
207210
value: 0
208211

209-
- label: "Wait 10s"
212+
- label: "Wait 5s"
210213
PICS: CC.S.F00
211214
cluster: "DelayCommands"
212215
command: "WaitForMs"
213216
arguments:
214217
values:
215218
- name: "ms"
216-
value: 10000
219+
value: 5000
217220

218-
#https://github.com/CHIP-Specifications/chip-test-scripts/issues/416#issuecomment-1228072461
221+
# In 30s, the value will have changed by 180 (total change)
222+
# In 5s, the value will have changed by 180*5/30 = 30. A 15% tolerance is 4.5, so ~5, and value must be in range 30+/-5 => [25, 35]
219223
- label: "Step 3c: TH reads CurrentHue attribute from DUT"
220-
PICS: CC.S.F00 && CC.S.A0000 && PICS_SKIP_SAMPLE_APP
221-
verification: |
222-
./chip-tool colorcontrol read current-hue 1 1
223-
Verify response contains a CurrentHue value in TH(chip-tool) Logs:
224-
225-
[1649661849.854961][8307:8312] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0300 Attribute 0x0000_0000 DataVersion: 4087274517
226-
[1649661849.855019][8307:8312] CHIP:TOO: current hue: 0 (value can vary)
227-
[1649661849.855097][8307:8312] CHIP:EM: Sending Standalone Ack for MessageCounter:13414799 on exchange 39735i
228-
cluster: "LogCommands"
229-
command: "UserPrompt"
230-
arguments:
231-
values:
232-
- name: "message"
233-
value: "Enter 'y' after success"
234-
- name: "expectedValue"
235-
value: "y"
224+
PICS: CC.S.F00 && CC.S.A0000
225+
command: "readAttribute"
226+
attribute: "CurrentHue"
227+
response:
228+
constraints:
229+
minValue: 25
230+
maxValue: 35
236231

237-
- label: "Wait 10s"
232+
- label: "Wait 15s"
238233
PICS: CC.S.F00
239234
cluster: "DelayCommands"
240235
command: "WaitForMs"
241236
arguments:
242237
values:
243238
- name: "ms"
244-
value: 10000
239+
value: 15000
245240

246-
#https://github.com/CHIP-Specifications/chip-test-scripts/issues/493#issuecomment-1422075950
241+
# In 20s, the value will have changed by 180*20/30 = 120. A 15% tolerance is 18, so value must be in range
242+
# 60-120 = 255-60 = 195+/-18 => [177, 213]
247243
- label: "Step 3d: TH reads CurrentHue attribute from DUT"
248-
PICS: CC.S.F00 && CC.S.A0000 && PICS_SKIP_SAMPLE_APP
249-
verification: |
250-
./chip-tool colorcontrol read current-hue 1 1
251-
252-
After another 10 seconds , Verify that CurrentHue value as 195 On TH(chip-tool) Logs:
253-
[1649661821.298198][8292:8297] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0300 Attribute 0x0000_0000 DataVersion: 4087274517
254-
[1649661821.298271][8292:8297] CHIP:TOO: current hue: 195 (value can vary)
255-
[1649661821.298374][8292:8297] CHIP:EM: Sending Standalone Ack for MessageCounter:13643708 on exchange 28536i
256-
cluster: "LogCommands"
257-
command: "UserPrompt"
258-
arguments:
259-
values:
260-
- name: "message"
261-
value: "Enter 'y' after success"
262-
- name: "expectedValue"
263-
value: "y"
244+
PICS: CC.S.F00 && CC.S.A0000
245+
command: "readAttribute"
246+
attribute: "CurrentHue"
247+
response:
248+
constraints:
249+
minValue: 177
250+
maxValue: 213
264251

265252
- label: "Wait 10s"
266253
PICS: CC.S.F00
@@ -271,24 +258,16 @@ tests:
271258
- name: "ms"
272259
value: 10000
273260

274-
#https://github.com/CHIP-Specifications/chip-test-scripts/issues/493#issuecomment-1422075950
261+
# In 30s, the value will have changed by 180*30/30 = 180. A 15% tolerance is 27, so value must be in range
262+
# 60-180 = 255-120 = 135+/-27 => [108, 162]
275263
- label: "Step 3e: TH reads CurrentHue attribute from DUT"
276-
PICS: CC.S.F00 && CC.S.A0000 && PICS_SKIP_SAMPLE_APP
277-
verification: |
278-
./chip-tool colorcontrol read current-hue 1 1
279-
After another 10 seconds , Verify that CurrentHue value as 135 On TH(chip-tool) Logs:
280-
281-
[1649661821.298198][8292:8297] CHIP:TOO: Endpoint: 1 Cluster: 0x0000_0300 Attribute 0x0000_0000 DataVersion: 4087274517
282-
[1649661821.298271][8292:8297] CHIP:TOO: current hue: 135
283-
[1649661821.298374][8292:8297] CHIP:EM: Sending Standalone Ack for MessageCounter:13643708 on exchange 28536i"
284-
cluster: "LogCommands"
285-
command: "UserPrompt"
286-
arguments:
287-
values:
288-
- name: "message"
289-
value: "Enter 'y' after success"
290-
- name: "expectedValue"
291-
value: "y"
264+
PICS: CC.S.F00 && CC.S.A0000
265+
command: "readAttribute"
266+
attribute: "CurrentHue"
267+
response:
268+
constraints:
269+
minValue: 108
270+
maxValue: 162
292271

293272
- label: "Wait 5s"
294273
PICS: CC.S.F00
@@ -305,8 +284,8 @@ tests:
305284
attribute: "CurrentHue"
306285
response:
307286
constraints:
308-
minValue: 115
309-
maxValue: 155
287+
minValue: 108
288+
maxValue: 162
310289

311290
- label:
312291
"Step 4a: TH sends MoveToHue command to DUT with Hue=60,
@@ -362,14 +341,15 @@ tests:
362341
- name: "ms"
363342
value: 10000
364343

344+
# In 10s, the value will have changed by (120-60)*10/30 = 20. A 15% tolerance is 3, so value must be in range 80+/-3 => [77, 83]
365345
- label: "Step 4c: TH reads CurrentHue attribute from DUT"
366346
PICS: CC.S.F00 && CC.S.A0000
367347
command: "readAttribute"
368348
attribute: "CurrentHue"
369349
response:
370350
constraints:
371-
minValue: 68
372-
maxValue: 92
351+
minValue: 77
352+
maxValue: 83
373353

374354
- label: "Wait 10s"
375355
PICS: CC.S.F00
@@ -380,14 +360,15 @@ tests:
380360
- name: "ms"
381361
value: 10000
382362

363+
# In 20s, the value will have changed by (120-60)*20/30 = 40. A 15% tolerance is 6, so value must be in range 100+/-6 => [94, 106]
383364
- label: "Step 4d: TH reads CurrentHue attribute from DUT"
384365
PICS: CC.S.F00 && CC.S.A0000
385366
command: "readAttribute"
386367
attribute: "CurrentHue"
387368
response:
388369
constraints:
389-
minValue: 85
390-
maxValue: 115
370+
minValue: 94
371+
maxValue: 106
391372

392373
- label: "Wait 10s"
393374
PICS: CC.S.F00
@@ -398,14 +379,15 @@ tests:
398379
- name: "ms"
399380
value: 10000
400381

382+
# In 30s, the value will have changed by (120-60)*30/30 = 60. A 15% tolerance is 9, so value must be in range 120+/-9 => [111, 129]
401383
- label: "Step 4e: TH reads CurrentHue attribute from DUT"
402384
PICS: CC.S.F00 && CC.S.A0000
403385
command: "readAttribute"
404386
attribute: "CurrentHue"
405387
response:
406388
constraints:
407-
minValue: 102
408-
maxValue: 138
389+
minValue: 111
390+
maxValue: 129
409391

410392
- label: "Wait 5s"
411393
PICS: CC.S.F00
@@ -422,8 +404,8 @@ tests:
422404
attribute: "CurrentHue"
423405
response:
424406
constraints:
425-
minValue: 102
426-
maxValue: 138
407+
minValue: 111
408+
maxValue: 129
427409

428410
- label:
429411
"Step 5a: TH sends MoveToHue command to DUT with Hue=120,
@@ -479,14 +461,15 @@ tests:
479461
- name: "ms"
480462
value: 10000
481463

464+
# In 10s, the value will have changed by (120-60)*10/30 = 20. A 15% tolerance is 3, so value must be in range 100+/-3 => [97, 103]
482465
- label: "Step 5c: TH reads CurrentHue attribute from DUT"
483466
PICS: CC.S.F00 && CC.S.A0000
484467
command: "readAttribute"
485468
attribute: "CurrentHue"
486469
response:
487470
constraints:
488-
minValue: 85
489-
maxValue: 115
471+
minValue: 97
472+
maxValue: 103
490473

491474
- label: "Wait 10s"
492475
PICS: CC.S.F00
@@ -497,14 +480,15 @@ tests:
497480
- name: "ms"
498481
value: 10000
499482

483+
# In 20s, the value will have changed by (120-60)*20/30 = 40. A 15% tolerance is 6, so value must be in range 80+/-6 => [74, 86]
500484
- label: "Step 5d: TH reads CurrentHue attribute from DUT"
501485
PICS: CC.S.F00 && CC.S.A0000
502486
command: "readAttribute"
503487
attribute: "CurrentHue"
504488
response:
505489
constraints:
506-
minValue: 68
507-
maxValue: 92
490+
minValue: 74
491+
maxValue: 86
508492

509493
- label: "Wait 10s"
510494
PICS: CC.S.F00
@@ -515,6 +499,7 @@ tests:
515499
- name: "ms"
516500
value: 10000
517501

502+
# In 30s, the value will have changed by (120-60)*30/30 = 60. A 15% tolerance is 9, so value must be in range 60+/-9 => [51, 69]
518503
- label: "Step 5e: TH reads CurrentHue attribute from DUT"
519504
PICS: CC.S.F00 && CC.S.A0000
520505
command: "readAttribute"

0 commit comments

Comments
 (0)