[Python] Eliminate ZCLSubscribeAttribute (#33337)

* Use asyncio sleep to unblock asyncio event loop

* Avoid fixed sleep in TestCaseEviction

Use asyncio Event and wait_for to wait for the change and continue
immediately when received.

* Make TestSubscription an async test

The current test implementation starves the asyncio event loop by
synchronously waiting for the threading.Condition. This prevents
making the SubscriptionTransaction fully leveraging the async
paradigm.

It probably would be possible to mix asyncio.sleep() and threading,
but instead embrace the async pradigm for this test.

* Make TestSubscriptionResumption an async test

The current test implementation starves the asyncio event loop by
synchronously waiting for the threading.Condition. This prevents
making the SubscriptionTransaction fully leveraging the async
paradigm.

It probably would be possible to mix asyncio.sleep() and threading,
but instead embrace the async pradigm for this test.

* Make TestSubscriptionResumptionCapacityStep1 an async test

Eliminate use of ZCLSubscribeAttribute and embrace asyncio.

* Make TestSubscriptionResumptionCapacityStep2 an async test

Eliminate use of ZCLSubscribeAttribute and embrace asyncio.

* Remove ZCLSubscribeAttribute from subscription_resumption_timeout_test

Use ReadAttribute with asyncio in subscription_resumption_timeout_test
as well.

* Rewrite TestWriteBasicAttributes to drop ZCLRead/WriteAttribute

* Improve wait for end of update task in TestSubscription

Author: agners

src/controller/python/test/test_scripts/base.py

@@ -129,9 +129,8 @@ def TestDatamodel(test: BaseTestHelper, device_nodeid: int):
               "Failed to test Read Basic Attributes")
 
     logger.info("Testing attribute writing")
-    FailIfNot(test.TestWriteBasicAttributes(nodeid=device_nodeid,
-                                            endpoint=ENDPOINT_ID,
-                                            group=GROUP_ID),
+    FailIfNot(asyncio.run(test.TestWriteBasicAttributes(nodeid=device_nodeid,
+                                                        endpoint=ENDPOINT_ID)),
               "Failed to test Write Basic Attributes")
 
     logger.info("Testing attribute reading basic again")
@@ -141,11 +140,11 @@ def TestDatamodel(test: BaseTestHelper, device_nodeid: int):
               "Failed to test Read Basic Attributes")
 
     logger.info("Testing subscription")
-    FailIfNot(test.TestSubscription(nodeid=device_nodeid, endpoint=LIGHTING_ENDPOINT_ID),
+    FailIfNot(asyncio.run(test.TestSubscription(nodeid=device_nodeid, endpoint=LIGHTING_ENDPOINT_ID)),
               "Failed to subscribe attributes.")
 
     logger.info("Testing another subscription that kills previous subscriptions")
-    FailIfNot(test.TestSubscription(nodeid=device_nodeid, endpoint=LIGHTING_ENDPOINT_ID),
+    FailIfNot(asyncio.run(test.TestSubscription(nodeid=device_nodeid, endpoint=LIGHTING_ENDPOINT_ID)),
               "Failed to subscribe attributes.")
 
     logger.info("Testing re-subscription")

src/controller/python/test/test_scripts/mobile-device-test.py

@@ -19,6 +19,7 @@
 
 # Commissioning test.
 
+import asyncio
 import os
 import sys
 from optparse import OptionParser
@@ -113,8 +114,8 @@ def main():
         "Failed on on-network commissioing")
 
     FailIfNot(
-        test.TestSubscriptionResumptionCapacityStep1(
-            options.nodeid, TEST_ENDPOINT_ID, options.setuppin, options.subscriptionCapacity),
+        asyncio.run(test.TestSubscriptionResumptionCapacityStep1(
+            options.nodeid, TEST_ENDPOINT_ID, options.setuppin, options.subscriptionCapacity)),
         "Failed on step 1 of testing subscription resumption capacity")
 
     timeoutTicker.stop()

src/controller/python/test/test_scripts/subscription_resumption_capacity_test_ctrl1.py

@@ -19,6 +19,7 @@
 
 # Commissioning test.
 
+import asyncio
 import os
 import sys
 from optparse import OptionParser
@@ -125,8 +126,9 @@ def main():
         "Failed on on-network commissioing")
 
     FailIfNot(
-        test.TestSubscriptionResumptionCapacityStep2(options.nodeid, TEST_ENDPOINT_ID, options.deviceAddress,
-                                                     TEST_SSH_PORT, options.remoteServerApp, options.subscriptionCapacity),
+        asyncio.run(
+            test.TestSubscriptionResumptionCapacityStep2(options.nodeid, TEST_ENDPOINT_ID, options.deviceAddress,
+                                                         TEST_SSH_PORT, options.remoteServerApp, options.subscriptionCapacity)),
         "Failed on testing subscription resumption capacity")
 
     timeoutTicker.stop()

src/controller/python/test/test_scripts/subscription_resumption_capacity_test_ctrl2.py

@@ -19,6 +19,7 @@
 
 # Commissioning test.
 
+import asyncio
 import os
 import sys
 from optparse import OptionParser
@@ -115,8 +116,8 @@ def main():
         "Failed on on-network commissioing")
 
     FailIfNot(
-        test.TestSubscriptionResumption(options.nodeid, TEST_ENDPOINT_ID, options.deviceAddress,
-                                        TEST_SSH_PORT, options.remoteServerApp), "Failed to resume subscription")
+        asyncio.run(test.TestSubscriptionResumption(options.nodeid, TEST_ENDPOINT_ID, options.deviceAddress,
+                                                    TEST_SSH_PORT, options.remoteServerApp)), "Failed to resume subscription")
 
     timeoutTicker.stop()
 

src/controller/python/test/test_scripts/subscription_resumption_test.py

@@ -19,11 +19,13 @@
 
 # Commissioning test.
 
+import asyncio
 import os
 import sys
 from optparse import OptionParser
 
 from base import BaseTestHelper, FailIfNot, TestFail, TestTimeout, logger
+from chip import clusters as Clusters
 
 TEST_DISCRIMINATOR = 3840
 TEST_SETUPPIN = 20202021
@@ -101,10 +103,12 @@ def main():
 
     FailIfNot(
         test.TestOnNetworkCommissioning(options.discriminator, options.setuppin, options.nodeid, options.deviceAddress),
-        "Failed on on-network commissioing")
+        "Failed on on-network commissioning")
+
     try:
-        test.devCtrl.ZCLSubscribeAttribute("BasicInformation", "NodeLabel", options.nodeid, TEST_ENDPOINT_ID, 1, 2,
-                                           keepSubscriptions=True, autoResubscribe=False)
+        asyncio.run(test.devCtrl.ReadAttribute(options.nodeid,
+                                               [(TEST_ENDPOINT_ID, Clusters.BasicInformation.Attributes.NodeLabel)],
+                                               None, False, reportInterval=(1, 2), keepSubscriptions=True, autoResubscribe=False))
     except Exception as ex:
         TestFail(f"Failed to subscribe attribute: {ex}")