Skip to content

Commit b7899bc

Browse files
tcarmelveilleuxrestyled-commits
andauthoredMar 25, 2025··
[VID Verification] Add empty handlers to fix ZAP issue (#38118)
* Update VidVerification->VIDVerification in ZAP XML * ZAP Regen * Run alchemy * Regen zap * Add unimplemented versionf of VID Verification commands - Add SetVIDVerificationStatement and SetVIDVerificationStatement to all-clusters app. - Make the cluster respond un-implemented. - Add a temporary test for the fact that it's unimplemented. - Fixes #37748 * Restyled by clang-format * Fix integration test --------- Co-authored-by: Restyled.io <commits@restyled.io>
1 parent 03d3595 commit b7899bc

File tree

6 files changed

+96
-2
lines changed

6 files changed

+96
-2
lines changed
 

‎examples/all-clusters-app/all-clusters-common/all-clusters-app.matter

+3
Original file line numberDiff line numberDiff line change
@@ -8312,6 +8312,9 @@ endpoint 0 {
83128312
handle command UpdateFabricLabel;
83138313
handle command RemoveFabric;
83148314
handle command AddTrustedRootCertificate;
8315+
handle command SetVIDVerificationStatement;
8316+
handle command SignVIDVerificationRequest;
8317+
handle command SignVIDVerificationResponse;
83158318
}
83168319

83178320
server cluster GroupKeyManagement {

‎examples/all-clusters-app/all-clusters-common/all-clusters-app.zap

+25-1
Original file line numberDiff line numberDiff line change
@@ -5172,6 +5172,30 @@
51725172
"source": "client",
51735173
"isIncoming": 1,
51745174
"isEnabled": 1
5175+
},
5176+
{
5177+
"name": "SetVIDVerificationStatement",
5178+
"code": 12,
5179+
"mfgCode": null,
5180+
"source": "client",
5181+
"isIncoming": 1,
5182+
"isEnabled": 1
5183+
},
5184+
{
5185+
"name": "SignVIDVerificationRequest",
5186+
"code": 13,
5187+
"mfgCode": null,
5188+
"source": "client",
5189+
"isIncoming": 1,
5190+
"isEnabled": 1
5191+
},
5192+
{
5193+
"name": "SignVIDVerificationResponse",
5194+
"code": 14,
5195+
"mfgCode": null,
5196+
"source": "server",
5197+
"isIncoming": 0,
5198+
"isEnabled": 1
51755199
}
51765200
],
51775201
"attributes": [
@@ -25839,4 +25863,4 @@
2583925863
"parentEndpointIdentifier": null
2584025864
}
2584125865
]
25842-
}
25866+
}

‎examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter

+3
Original file line numberDiff line numberDiff line change
@@ -6565,6 +6565,9 @@ endpoint 0 {
65656565
handle command UpdateFabricLabel;
65666566
handle command RemoveFabric;
65676567
handle command AddTrustedRootCertificate;
6568+
handle command SetVIDVerificationStatement;
6569+
handle command SignVIDVerificationRequest;
6570+
handle command SignVIDVerificationResponse;
65686571
}
65696572

65706573
server cluster GroupKeyManagement {

‎examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap

+25-1
Original file line numberDiff line numberDiff line change
@@ -3336,6 +3336,30 @@
33363336
"source": "client",
33373337
"isIncoming": 1,
33383338
"isEnabled": 1
3339+
},
3340+
{
3341+
"name": "SetVIDVerificationStatement",
3342+
"code": 12,
3343+
"mfgCode": null,
3344+
"source": "client",
3345+
"isIncoming": 1,
3346+
"isEnabled": 1
3347+
},
3348+
{
3349+
"name": "SignVIDVerificationRequest",
3350+
"code": 13,
3351+
"mfgCode": null,
3352+
"source": "client",
3353+
"isIncoming": 1,
3354+
"isEnabled": 1
3355+
},
3356+
{
3357+
"name": "SignVIDVerificationResponse",
3358+
"code": 14,
3359+
"mfgCode": null,
3360+
"source": "server",
3361+
"isIncoming": 0,
3362+
"isEnabled": 1
33393363
}
33403364
],
33413365
"attributes": [
@@ -11933,4 +11957,4 @@
1193311957
"parentEndpointIdentifier": null
1193411958
}
1193511959
]
11936-
}
11960+
}

‎src/app/clusters/operational-credentials-server/operational-credentials-server.cpp

+18
Original file line numberDiff line numberDiff line change
@@ -1195,3 +1195,21 @@ bool emberAfOperationalCredentialsClusterAddTrustedRootCertificateCallback(
11951195
commandObj->AddStatus(commandPath, finalStatus);
11961196
return true;
11971197
}
1198+
1199+
bool emberAfOperationalCredentialsClusterSetVIDVerificationStatementCallback(
1200+
app::CommandHandler * commandObj, const app::ConcreteCommandPath & commandPath,
1201+
const Commands::SetVIDVerificationStatement::DecodableType & commandData)
1202+
{
1203+
(void) commandData;
1204+
commandObj->AddStatus(commandPath, Status::UnsupportedCommand);
1205+
return true;
1206+
}
1207+
1208+
bool emberAfOperationalCredentialsClusterSignVIDVerificationRequestCallback(
1209+
app::CommandHandler * commandObj, const app::ConcreteCommandPath & commandPath,
1210+
const Commands::SignVIDVerificationRequest::DecodableType & commandData)
1211+
{
1212+
(void) commandData;
1213+
commandObj->AddStatus(commandPath, Status::UnsupportedCommand);
1214+
return true;
1215+
}

‎src/app/tests/suites/TestOperationalCredentialsCluster.yaml

+22
Original file line numberDiff line numberDiff line change
@@ -130,3 +130,25 @@ tests:
130130
values:
131131
- name: "FabricIndex"
132132
value: 1
133+
134+
# Not yet implemented!
135+
- label: "Check SetVIDVerificationStatement not implemented"
136+
command: "SetVIDVerificationStatement"
137+
arguments:
138+
values:
139+
- name: "VendorID"
140+
value: 0xfff1
141+
response:
142+
error: UNSUPPORTED_COMMAND
143+
144+
# Not yet implemented!
145+
- label: "Check SignVIDVerificationRequest not implemented"
146+
command: "SignVIDVerificationRequest"
147+
arguments:
148+
values:
149+
- name: "FabricIndex"
150+
value: 1
151+
- name: "ClientChallenge"
152+
value: "hex:00112233445566778899aabbccddeeff00112233445566778899aabbccddeeff"
153+
response:
154+
error: UNSUPPORTED_COMMAND

0 commit comments

Comments
 (0)
Please sign in to comment.