[VID Verification] Add empty handlers to fix ZAP issue #38118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SetVIDVerificationStatement and SetVIDVerificationStatement to all-clusters app. - Make the cluster respond un-implemented. - Add a temporary test for the fact that it's unimplemented. - Fixes project-chip#37748
tehampson
approved these changes
Mar 25, 2025
|
PR #38118: Size comparison from 7d04796 to 46735d3 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Mar 25, 2025
|
PR #38118: Size comparison from 7d04796 to ace9d73 Increases above 0.2%:
Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
juandediosg
pushed a commit
to juandediosg/connectedhomeip
that referenced
this pull request
Mar 28, 2025
…38118) * Update VidVerification->VIDVerification in ZAP XML * ZAP Regen * Run alchemy * Regen zap * Add unimplemented versionf of VID Verification commands - Add SetVIDVerificationStatement and SetVIDVerificationStatement to all-clusters app. - Make the cluster respond un-implemented. - Add a temporary test for the fact that it's unimplemented. - Fixes project-chip#37748 * Restyled by clang-format * Fix integration test --------- Co-authored-by: Restyled.io <commits@restyled.io>
juandediosg
pushed a commit
to juandediosg/connectedhomeip
that referenced
this pull request
Mar 28, 2025
…38118) * Update VidVerification->VIDVerification in ZAP XML * ZAP Regen * Run alchemy * Regen zap * Add unimplemented versionf of VID Verification commands - Add SetVIDVerificationStatement and SetVIDVerificationStatement to all-clusters app. - Make the cluster respond un-implemented. - Add a temporary test for the fact that it's unimplemented. - Fixes project-chip#37748 * Restyled by clang-format * Fix integration test --------- Co-authored-by: Restyled.io <commits@restyled.io>
soares-sergio
pushed a commit
to soares-sergio/connectedhomeip
that referenced
this pull request
Apr 8, 2025
…38118) * Update VidVerification->VIDVerification in ZAP XML * ZAP Regen * Run alchemy * Regen zap * Add unimplemented versionf of VID Verification commands - Add SetVIDVerificationStatement and SetVIDVerificationStatement to all-clusters app. - Make the cluster respond un-implemented. - Add a temporary test for the fact that it's unimplemented. - Fixes project-chip#37748 * Restyled by clang-format * Fix integration test --------- Co-authored-by: Restyled.io <commits@restyled.io>
sayondeep
pushed a commit
to sayondeep/connectedhomeip
that referenced
this pull request
Apr 10, 2025
…38118) * Update VidVerification->VIDVerification in ZAP XML * ZAP Regen * Run alchemy * Regen zap * Add unimplemented versionf of VID Verification commands - Add SetVIDVerificationStatement and SetVIDVerificationStatement to all-clusters app. - Make the cluster respond un-implemented. - Add a temporary test for the fact that it's unimplemented. - Fixes project-chip#37748 * Restyled by clang-format * Fix integration test --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
SetVIDVerificationStatementandSignVIDVerificationRequestcommands, so that builds don't break if included in ZAP.app.
emberAfOperationalCredentialsClusterSetVidVerificationStatementCallback#37748Testing