Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using the a* pattern for method input parameters #34541

Open
hicklin opened this issue Jul 26, 2024 · 3 comments
Open

Stop using the a* pattern for method input parameters #34541

hicklin opened this issue Jul 26, 2024 · 3 comments
Assignees

Comments

@hicklin
Copy link
Contributor

hicklin commented Jul 26, 2024

Following this PR comment, this issue is to track the removal of the a* pattern for method input parameters.

@bzbarsky-apple
Copy link
Contributor

bzbarsky-apple commented Jul 26, 2024

I am fine with that if we also get rid of the "p" and "mp" prefixes....

What is the plan for the "m" and "s" prefixes for members?

That said, I should note that contrary to the PR comment cited above "a" prefixes are not "Hungarian style". Hungarian style is when the type is encoded into the name. This is encoding semantic/lifetime information, not the type.

@hicklin
Copy link
Contributor Author

hicklin commented Jul 29, 2024

Is there a "standard" or at least "preferred" style guide for matter? So far I have been trying to mimic what I have seen elsewhere in the SDK. Sometimes I happen to choose the wrong example.

@bzbarsky-apple
Copy link
Contributor

There is not. For new files, it's people doing whatever they want. For existing files, follow file style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants