Implementation of service area server #33991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edhomeip-spec PR 8933
…nnectedhomeip-spec PR 8937
…nnectedhomeip-spec PR 8937
…996d0ef74a36b2a6b93ac0d3db9c45
…d5b7eff4d3443273f47f12f22baf 2024-05-23
…definition-for-service-area-cluster
Merge remote-tracking branch 'origin/Add-common-definitions-for-Home-Location' into Add-xml-definition-for-service-area-cluster
Pull in updates to Home-Location definitions from other PR branch.
… 6bf3762eb1ee733c642e79074744d1185b82a89c 2024-05-24
…o commit 6bf3762eb1ee733c642e79074744d1185b82a89c 2024-05-24
…definition-for-service-area-cluster
…definition-for-service-area-cluster
…mentation-of-service-area-server
|
PR #33991: Size comparison from 4334e91 to 2df0c57 Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
|
PR #33991: Size comparison from 4334e91 to 8588959 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33991: Size comparison from 5e3127f to aee7b9e Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 29, 2024
| virtual ~Delegate() = default; | ||
|
|
||
| /** | ||
| * Stop this class objects from being copied. |
There was a problem hiding this comment.
Comment about why? what self-referential data structures or pointers are contained within this class?
There was a problem hiding this comment.
I see mInstance however I am unclear about what management of it is done. at a frist glance it seems to be just a raw pointer with set/get method.
There was a problem hiding this comment.
mInstance points to an Instance object that has a pointer to this Delegate object. The Delegate and Instance classes are coupled in this way.
Copying a delegate class might make things confusing as it allows the possibility of a Delegate object that points to an Instance that does not point back to it.
There was a problem hiding this comment.
This should be explained in a comment. A stop this class object for being copied just re-states the code when I see a = delete. When maintaining this code, I need to answer why this is not allowed and what would happen if I do allow it.
Design-wise, the circular reference is a bit frustrating.
There was a problem hiding this comment.
@andy31415 Added an explanation in this commit.
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #33991: Size comparison from 29b055a to 2e707f8 Full report (4 builds for cc32xx, mbed, stm32)
|
|
PR #33991: Size comparison from 29b055a to 56abce4 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #33991: Size comparison from 29b055a to af7d1ba Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 30, 2024
andy31415
approved these changes
Jul 30, 2024
plauric
approved these changes
Jul 30, 2024
|
Manual merging: github CI seems broken somehow (java tests hang, restyler does not work) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33365.
This PR implements the Service Area cluster server. The Instance / Delegate pattern used for the Mode Base and Operational State clusters has been used.
This PR builds on top of #33569 and #33752.
This PR also adds a service area cluster to the RVC example app. It is not yet properly integrated with RVC app logic but it implements all the necessary methods to test attribute access. Further work on the RVC app is covered by issue #33367.