Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] sub-optimal test TC_TSTAT_4_2.py - does not check that writes were successful #35299

Closed
hasty opened this issue Aug 29, 2024 · 1 comment
Closed

[Tests] sub-optimal test TC_TSTAT_4_2.py - does not check that writes were successful #35299

hasty opened this issue Aug 29, 2024 · 1 comment
Assignees
@hasty
Labels
build issue needs triage tests

Comments

@hasty
Copy link
Contributor

hasty commented Aug 29, 2024

Test issue(s)

Test didn't fail, but is sub-optimal. The Thermostat test script TC_TSTAT_4_2.py has tests that write to the Presets attribute, and then rollback the writes, but don't check in between to make sure the attribute was actually updated.

Platform

all

Anything else?

No response
@hasty hasty self-assigned this Aug 29, 2024
@hasty hasty mentioned this issue Aug 29, 2024
Merged
@andy31415 andy31415 changed the title [Test Failed] [Tests] sub-optimal test TC_TSTAT_4_2.py - does not check that writes were successful Feb 4, 2025
@andy31415
Copy link
Contributor

Seems closed by #35290

@github-project-automation github-project-automation bot moved this from Todo to Done in [Build] Build Issues Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hasty hasty

Labels
build issue needs triage tests
Projects
[Build] Build Issues
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hasty @andy31415