[HVAC] Make Thermostat Preset tests generic #35290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…server's initial state
|
Review changes with SemanticDiff. Analyzed 1 of 1 files. Overall, the semantic diff is 38% smaller than the GitHub diff.
|
github-actions
bot
added
tests
matter-1.4-te2-script-change
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
pullapprove
bot
requested review from
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35290: Size comparison from cfdbba9 to abf0270 Full report (3 builds for nxp, stm32)
|
|
PR #35290: Size comparison from cfdbba9 to 35ab294 Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #35290: Size comparison from cfdbba9 to 9ba838a Full report (44 builds for bl602, bl702, bl702l, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
examples/thermostat/thermostat-common/src/thermostat-delegate-impl.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #35290: Size comparison from cfdbba9 to 468cb2e Full report (77 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Aug 29, 2024
jmartinez-silabs
approved these changes
Aug 30, 2024
shgutte
pushed a commit
to shgutte/connectedhomeip
that referenced
this pull request
Sep 10, 2024
* [HVAC] Alter Thermostat Preset tests to not rely on knowledge of the server's initial state * Pick midpoint setpoints for new presets * Lint fixes * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Fixes from code review * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Fix remaining places with hard-coded setpoints * Don't abort test if there are no built-in presets * Remove unneeded length check * Fix max number of preset types --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alters the Thermostat test script TC_TSTAT_4_2.py to not have foreknowledge of the server's state before testing.