-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVSE and Device Energy Management XML should use new base energy reporting types (and other minor fixes) #30701
Merged
mergify
merged 19 commits into
project-chip:master
from
jamesharrow:30665-13-updates-needed-on-evse-xml-device-energy-management-to-use-new-types-and-clean-up-other-comments-with-optional-xml
Dec 18, 2023
Merged
EVSE and Device Energy Management XML should use new base energy reporting types (and other minor fixes) #30701
mergify
merged 19 commits into
project-chip:master
from
jamesharrow:30665-13-updates-needed-on-evse-xml-device-energy-management-to-use-new-types-and-clean-up-other-comments-with-optional-xml
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed to use amperage_mA, energy_mWh - removed max on epoch_s - removed access for operate - removed side for events
…ogen, but still fails with some parts of regen_all
PR #30701: Size comparison from f1b6ea5 to 35a06a7 Decreases (2 builds for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30701: Size comparison from f1b6ea5 to 41acd01 Increases above 0.2%:
Increases (29 builds for linux, telink)
Decreases (49 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ml-device-energy-management-to-use-new-types-and-clean-up-other-comments-with-optional-xml
…ml-device-energy-management-to-use-new-types-and-clean-up-other-comments-with-optional-xml
PR #30701: Size comparison from 1f3bcbc to 6b83a69 Decreases (8 builds for cc32xx, mbed, nrfconnect, qpg)
Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
…Nullable etc and in Fault Event).
PR #30701: Size comparison from 1f3bcbc to b44b866 Increases (3 builds for bl602, linux)
Decreases (28 builds for cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
jamesharrow
commented
Dec 15, 2023
jamesharrow
commented
Dec 15, 2023
…-energy-management-to-use-new-types-and-clean-up-other-comments-with-optional-xml
PR #30701: Size comparison from 221e466 to 1e7fe6b Increases (25 builds for bl602, esp32, linux, telink)
Decreases (47 builds for cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…ml-device-energy-management-to-use-new-types-and-clean-up-other-comments-with-optional-xml
PR #30701: Size comparison from 9310a37 to 3dc98b0 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
brdandu
approved these changes
Dec 18, 2023
bzbarsky-apple
approved these changes
Dec 18, 2023
src/app/zap-templates/zcl/data-model/chip/device-energy-management-cluster.xml
Show resolved
Hide resolved
yunhanw-google
approved these changes
Dec 18, 2023
PR #30701: Size comparison from 9310a37 to b916654 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
energy
examples
review - approved
scripts
skip-protocol-compatibility
Marker that protocol backwards compatibility checks are to be skipped
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30665
Fixes #30805
energy-evse-server.xml:
Updated Device Energy Management:
for #30805 (EVSE Session attributes should be nullable)
Fixes #31032