-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling MoreChunkedMessages for Invoke Interaction #31378
Merged
tehampson
merged 16 commits into
project-chip:master
from
tehampson:batch-commands-allows-more-chunked-message-plumbing
Jan 18, 2024
Merged
Enabling MoreChunkedMessages for Invoke Interaction #31378
tehampson
merged 16 commits into
project-chip:master
from
tehampson:batch-commands-allows-more-chunked-message-plumbing
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehampson
commented
Jan 12, 2024
tehampson
commented
Jan 12, 2024
PR #31378: Size comparison from a4300e7 to f2f516f Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #31378: Size comparison from a4300e7 to 5017d75 Increases above 0.2%:
Increases (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for linux, psoc6)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 15, 2024
53 tasks
bzbarsky-apple
approved these changes
Jan 17, 2024
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only contains plumbing to allow CommandHandler to send multiple InvokeResponseMessages to CommandSender, and for CommandSender properly process and respond to
InvokeResponseMessage
s that containMoreChunkedMessage
Some test names in
src/app/tests/TestCommandInteraction.cpp
were updated to reflect what they were actually testing already. Brief attempt was made to change the tests to do what test name was suggesting, but that required a larger change adding in aCommandSender
for theCommandHandler
to communicate with. That is very much outside the scope of what this PR is trying to accomplish, as such I just went with renaming testnameTo be completed in a follow up PR:
src/app/tests/TestCommandInteraction.cpp
.CommandResponseSender
instead of adding unit test.CommandHandler
to build more than one InvokeResponseMessage (ie havingmChunks
contain more than 1 buffer). I would like that PR to focus just on that and this PR to focus on the plumbing of InvokeResponseMessages with MoreChunkedMessages betweenCommandResponseSender
andCommandSender
.Test: