Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC-IDM-4.2 Step 8 delay adjust #31773

Closed
wants to merge 11 commits into from
Closed

TC-IDM-4.2 Step 8 delay adjust #31773

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6338e61
test
raul-marquez-csa Jan 30, 2024
6472b8c
Adds 1/2 second to delay in step 8
raul-marquez-csa Jan 30, 2024
3f26dc8
Merge branch 'master' into idm-4.2-troubleshoot
raul-marquez-csa Jan 31, 2024
4c5df4c
Merge branch 'master' into idm-4.2-troubleshoot
raul-marquez-csa Feb 16, 2024
bbc0409
Adds loop in 0.1s cheks for 10s for reading updated attribute
raul-marquez-csa Feb 16, 2024
5750461
Merge branch 'idm-4.2-troubleshoot' of https://github.com/raul-marque…
raul-marquez-csa Feb 16, 2024
53c1002
Merge branch 'master' into idm-4.2-troubleshoot
raul-marquez-csa Feb 16, 2024
67b1635
Merge remote-tracking branch 'upstream/master' into idm-4.2-troubleshoot
raul-marquez-csa Feb 17, 2024
73f9801
Merge branch 'master' into idm-4.2-troubleshoot
raul-marquez-csa Feb 22, 2024
1d09862
Merge branch 'idm-4.2-troubleshoot' of https://github.com/raul-marque…
raul-marquez-csa Feb 22, 2024
f4fa9dd
Merge branch 'master' into idm-4.2-troubleshoot
raul-marquez-csa Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions src/python_testing/TC_IDM_4_2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,29 @@ async def get_idle_mode_duration_sec(self, ctrl, ep=ROOT_NODE_ENDPOINT_ID):
attribute=Clusters.IcdManagement.Attributes.IdleModeDuration
)

def get_attribute_value_wait(self, sub, typed_attr_path):
start_time = time.time()
timeout = 10
increment = 0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may have a few of these sprinkled in the code. How about adding a retry library in the testing requirements like https://tenacity.readthedocs.io/en/latest/ or maybe there are others, so we can read code like @retry(stop=stop_after_delay(10), wait=wait_fixed(0.1), retry=retry_if_result(is_empty))) or something like that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh...I hope we don't. If we do, that seems like a test red flag.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put up a PR to disable this test in the CI. The test plan has been updated so we don't have to do this. I'm hoping we can just skip this retry at this point and fix the test properly. This was meant to be a quick fix-forward to get this to stop flaking.

#32378

loop = True
attribute_value = None
while loop:
# Get the attribute value
attribute_value = sub.GetAttribute(typed_attr_path)

# Check if the value is not an empty string
if attribute_value != "":
loop = False # Exit the loop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
loop = False # Exit the loop
return attribute_value

Then you can get rid of the loop var and just loop on time.time() < end_time and throw the error at the end

else:
# Check if the timeout has been reached
if time.time() - start_time > timeout:
error_msg = f"Timeout: Value for '{typed_attr_path.AttributeName}' attribute not found within {timeout} seconds."
raise TimeoutError(error_msg)
else:
time.sleep(increment)

return attribute_value

@staticmethod
def verify_attribute_exists(sub, cluster, attribute, ep=ROOT_NODE_ENDPOINT_ID):
sub_attrs = sub
Expand Down Expand Up @@ -409,8 +432,8 @@ async def test_TC_IDM_4_2(self):
)

# Wait MinIntervalFloor seconds before reading updated attribute value
time.sleep(same_min_max_interval_sec)
new_node_label_read = sub_cr1_update_value.GetAttribute(node_label_attr_typed_path)
# TODO: Fix subscription ranges https://github.com/CHIP-Specifications/chip-test-plans/issues/3948
new_node_label_read = self.get_attribute_value_wait(sub_cr1_update_value, node_label_attr_typed_path)

# Verify new attribute value after MinIntervalFloor time
asserts.assert_equal(new_node_label_read, new_node_label_write, "Attribute value not updated after write operation.")
Expand Down
Loading