-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] [WiFi] Made changes to get logs on uart port #32242
Merged
mergify
merged 14 commits into
project-chip:master
from
arun-silabs:feature/enable_uart_logging
Mar 4, 2024
Merged
[Silabs] [WiFi] Made changes to get logs on uart port #32242
mergify
merged 14 commits into
project-chip:master
from
arun-silabs:feature/enable_uart_logging
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #32242: Size comparison from 7be1b2e to 9b75837 Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jepenven-silabs
requested changes
Feb 26, 2024
PR #32242: Size comparison from b427981 to a96538c Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32242: Size comparison from bdde9cf to f306475 Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
jepenven-silabs
approved these changes
Mar 1, 2024
PR #32242: Size comparison from c1ae85c to d0da4d0 Increases (3 builds for bl602, bl702, bl702l)
Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
PR #32242: Size comparison from c1ae85c to 69cc37d Increases (3 builds for bl602, bl702, bl702l)
Decreases (3 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
lpbeliveau-silabs
approved these changes
Mar 4, 2024
andy31415
approved these changes
Mar 4, 2024
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Mar 7, 2024
…2242) * Made changes to get logs on uart port * Added some checks to enable uart logging for SoC and efr. * Removed macro in common code and moved the logging code to uartLogWrite API. * Restyled by clang-format * Returning number of bytes written to uart console. * Restyled by clang-format * Modified code as per review comments. * Restyled by clang-format * Fixed the typo. * Update examples/platform/silabs/SiWx917/uart.cpp Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
…2242) * Made changes to get logs on uart port * Added some checks to enable uart logging for SoC and efr. * Removed macro in common code and moved the logging code to uartLogWrite API. * Restyled by clang-format * Returning number of bytes written to uart console. * Restyled by clang-format * Modified code as per review comments. * Restyled by clang-format * Fixed the typo. * Update examples/platform/silabs/SiWx917/uart.cpp Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com> --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: lpbeliveau-silabs <112982107+lpbeliveau-silabs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature : Enabling logs over uart port.
Description : For 917 SoC, if logs are enabled over Jlink, we need to restart the device after factory reset for the application to continue. Also, logs are getting disabled over Jlink for sleepy apps post commissioning. To get logs in such cases for debugging, we are enabling logs over uart port.