-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Messages] Change message duration to uint64 #32248
Conversation
PR #32248: Size comparison from 9aeff06 to 5ce1d28 Full report (39 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32)
|
5ce1d28
to
75fcb47
Compare
PR #32248: Size comparison from 9aeff06 to 75fcb47 Full report (4 builds for cc32xx, mbed, stm32)
|
ab02e42
to
19ea789
Compare
PR #32248: Size comparison from 4158d55 to 19ea789 Full report (3 builds for cc32xx, stm32)
|
19ea789
to
2171bf1
Compare
PR #32248: Size comparison from 4158d55 to 2171bf1 Increases (1 build for esp32)
Decreases (2 builds for efr32)
Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hasty I do not see this change in the spec and this PR tries to manually change an automatically generated file.
Duration says is "in minutes" ... why do we want 64-bit there? Is about 45 days insufficient? even then probably 32-bit would be sufficient...
I see https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/8909 exists ... however that has changes-requested. I feel uncomfortable allowing a SDK change before spec changes (very late). @robszewczyk what is the plan for the spec here? I would be ok if we synchronize them at the same time however right before 1.3 it seems dangerous to allow one to diverge before the other. |
PR #32248: Size comparison from 4158d55 to d21b243 Increases (4 builds for esp32, linux)
Decreases (2 builds for efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
* Change message duration to uint64 * Fixes to Java build * Missed a HandlePresentMessagesRequest signature
This changes the duration on Messages to be uint64 to match changes in the spec.