Leak in Darwin protocol for publicKey #32301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woody-apple
force-pushed
the
key-leak
branch
from
e7eaa14 to
96e78ba
Compare
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
joonhaengHeo
|
PR #32301: Size comparison from 22bb737 to 89da639 Full report (41 builds for bl602, bl702, bl702l, cc13x4_26x4, esp32, k32w, mbed, qpg, telink)
|
| publicKey = [keypair copyPublicKey]; | ||
| } else { | ||
| publicKey = [keypair publicKey]; | ||
| if (publicKey) |
There was a problem hiding this comment.
Curlies around body, please.
| CHIP_ERROR err = MTRP256KeypairBridge::MatterPubKeyFromSecKeyRef(params.nocSigner.publicKey, &pubKey); | ||
| SecKeyRef publicKey = NULL; | ||
|
|
||
| if ([params.nocSigner respondsToSelector:@selector(copyPublicKey)]) { |
There was a problem hiding this comment.
We should have a utility function for this, or better yet a utility RAII helper, instead of copy/pasting this code around.
pullapprove
bot
requested review from
axelnxp,
bauerschwan,
chapongatien,
doru91,
fessehaeve,
kiel-apple and
ReneJosefsen
|
PR #32301: Size comparison from 0840ca6 to 557535b Full report (32 builds for efr32, linux, mbed, nrfconnect, nxp, telink, tizen)
|
|
This PR has not been updated in a long time. Assuming stale and closing. |
* Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
|
PR #32301: Size comparison from 7df7676 to 17336cd Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol we're asking folks to implement basically guarantees a key leak, this should be an explicit copy.