-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove TV app from full builds and smoke tests as they have been included in CI as a build example per issue Issue 30906 #32763
Conversation
Remove tv app runs from full-android as they are now a part of CI as a build example
Remove tv app runs as they are now part of CI as a build example
PR #32763: Size comparison from 2d550d6 to ec4d87e Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
- name: Build Android arm-tv-casting-app | ||
run: | | ||
./scripts/run_in_build_env.sh \ | ||
"./scripts/build/build_examples.py --target android-arm-tv-casting-app build" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this being removed? Nothing else builds android-arm-tv-casting-app or android-arm-tv-server.... The "examples" thing mentioned only builds the arm64 versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true ... it is likely worth it to build arm as it is 32-bit so int/long conversions will be different than the 64-bit builds.
New context from Yufeng indicates that integrating this smoketest as a standalone build is not what we are looking for; instead we want runtime testing because failures were happening there rather than during builds. Would be nice to have this context in the issue writeup next time... I am reverting this for now. |
No description provided.