Move declarations from af.h into the corresponding storage/table/... headers
#32776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplemented in attribute-storage.cpp
…f.h (this will cause compile issues)
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro and
cliffamzn
|
PR #32776: Size comparison from 3a39c29 to f07cfed Decreases (2 builds for efr32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
Mar 29, 2024
|
PR #32776: Size comparison from 931e280 to 87dff5f Increases (3 builds for cc32xx, stm32)
Full report (4 builds for cc32xx, mbed, stm32)
|
|
PR #32776: Size comparison from 931e280 to 4b65704 Increases (3 builds for cc32xx, stm32)
Full report (3 builds for cc32xx, stm32)
|
…ste ... this is probably not good...
|
PR #32776: Size comparison from 931e280 to 6c070cc Increases (22 builds for bl702, cc13x4_26x4, cc32xx, cyw30739, esp32, psoc6, qpg, stm32)
Full report (33 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, mbed, psoc6, qpg, stm32)
|
|
PR #32776: Size comparison from 931e280 to 6ed465f Increases (61 builds for bl702, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (1 build for linux)
Full report (78 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
|
PR #32776: Size comparison from 931e280 to bbad9f3 Increases (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
Decreases (7 builds for bl702l, linux, telink)
Full report (78 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
bzbarsky-apple
approved these changes
Apr 4, 2024
|
PR #32776: Size comparison from 931e280 to 0b40196 Increases (1 build for mbed)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember af.h was a catch-all that declared functions from various cpp implementations, making it harder to figure out dependencies. It seems the original intent was to declare "a public api" however the end result was that a lot of code was including "af.h" as a catch all of "use ember". Since ember is not really as stand-alone currently, looking to enforce "if foo.cpp definex X, then foo.h should declare X".
Here I am working towards first making dependencies clear and then later iterating to define the a common "cluster/attribute/command/... metadata" interface that we could use to decouple code-generated data models from the interfaces used by the IM and cluster implemnentations, so that things become injectable (ability for code-driven clusters) and existing cluster code becomes testable in unit tests.
Changes
<string>forstd::stringusage.endpoint_config.h, however since ota-requestor uses attribute-table.h, I created a separate mock endpoint_config.h and config specifically for dynamic server builds to fix java.