-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Create ChipToolCheckInDelegate #32885
[chip-tool] Create ChipToolCheckInDelegate #32885
Conversation
da166a7
to
625293e
Compare
PR #32885: Size comparison from e2bb2e5 to 625293e Increases above 0.2%:
Increases (2 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
7b224e0
to
915690f
Compare
PR #32885: Size comparison from b4650b9 to 915690f Increases above 0.2%:
Increases (2 builds for linux)
Decreases (4 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
915690f
to
7762024
Compare
PR #32885: Size comparison from 9ff29ed to 7762024 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (3 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
@@ -180,6 +180,10 @@ class CHIPCommand : public Command | |||
|
|||
ChipDeviceCommissioner & GetCommissioner(std::string identity); | |||
|
|||
static void SetOnCheckInCompleteCallback(CheckInCompleteCallback * handler); | |||
|
|||
static void UnsetOnCheckInCompleteCallback(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better as:
static void UnsetOnCheckInCompleteCallback(); | |
static void ClearOnCheckInCompleteCallback(); |
chip::app::ICDClientStorage * mpStorage = nullptr; | ||
chip::app::InteractionModelEngine * mpImEngine = nullptr; | ||
|
||
CheckInCompleteCallback * mpCheckInCompleteCallbacks; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this plural? There is one callback...
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…e is enough for chip-tool icd usage
81ad69d
to
0ea3cdb
Compare
PR #32885: Size comparison from 5570be9 to 0ea3cdb Full report (9 builds for cc32xx, mbed, nrfconnect, qpg, stm32)
|
0ea3cdb
to
5f673c3
Compare
PR #32885: Size comparison from 5570be9 to 5f673c3 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (4 builds for efr32, linux)
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
The default check-in delegate does not meet the need of chip-tool usage. (And possibly other applications).
Implement a separate check-in delegate for chip-tool for now, and consider merge it back to the default check-in delegate when it is stabled.
Currently, the extra feature provided by chip-tool version is to support multiple
OnCheckInCompleteCallback
-s