Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec parsing: Use new ID table (#32410) #32971

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Spec parsing: Use new ID table (#32410) #32971

merged 1 commit into from
Apr 12, 2024

Conversation

cecille
Copy link
Contributor

@cecille cecille commented Apr 12, 2024

Cherry pick from main branch - gets the ID from the correct location for the new DM XML format.

@cecille @restyled-commits
Spec parsing: Use new ID table (project-chip#32410)
8398e93 
* Spec parsing: Use new ID table

The ID table has now been added for every cluster, including alias
clusters. This means we can now just make direct copies of the alias
clusters as we parse the cluster file. It also means we can ignore
the top-level cluster tag, so we don't need to worry about the
new weird naming.

Not yet handled in the XML - pics for aliased clusters.

* Restyled by isort

---------

Co-authored-by: Restyled.io <commits@restyled.io>
@github-actions github-actions bot added the tests label Apr 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2024 •
edited
Loading

PR #32971: Size comparison from d885e31 to 8398e93

Decreases (2 builds for efr32)
platform target config section d885e31 8398e93 change % change
efr32 lighting-app BRD4187C (read/write) 1107192 1107184 -8 -0.0
.text 908612 908604 -8 -0.0
window-app BRD4187C (read/write) 1153784 1153776 -8 -0.0
.text 983052 983044 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section d885e31 8398e93 change % change
bl602 lighting-app bl602 (read/write) 1432978 1432978 0 0.0
.bss 85328 85328 0 0.0
.data 9496 9496 0 0.0
.rodata 157532 157532 0 0.0
.text 1099972 1099972 0 0.0
bl602+mfd (read/write) 1447378 1447378 0 0.0
.bss 85488 85488 0 0.0
.data 9472 9472 0 0.0
.rodata 156492 156492 0 0.0
.text 1115282 1115282 0 0.0
bl602+rpc (read/write) 1480346 1480346 0 0.0
.bss 93360 93360 0 0.0
.data 9872 9872 0 0.0
.rodata 165100 165100 0 0.0
.text 1131354 1131354 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1197655 1197655 0 0.0
.bss 11121 11121 0 0.0
.data 3680 3680 0 0.0
.rodata 106872 106872 0 0.0
.text 969116 969116 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1208711 1208711 0 0.0
.bss 11297 11297 0 0.0
.data 3656 3656 0 0.0
.rodata 105812 105812 0 0.0
.text 981126 981126 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1289363 1289363 0 0.0
.bss 19589 19589 0 0.0
.data 4224 4224 0 0.0
.rodata 122244 122244 0 0.0
.text 1044060 1044060 0 0.0
bl706-eth (read/write) 1015349 1015349 0 0.0
.bss 23680 23680 0 0.0
.data 3248 3248 0 0.0
.rodata 100216 100216 0 0.0
.text 760250 760250 0 0.0
bl706-wifi (read/write) 1249390 1249390 0 0.0
.bss 10565 10565 0 0.0
.data 3688 3688 0 0.0
.rodata 121216 121216 0 0.0
.text 991514 991514 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1167220 1167220 0 0.0
.bss 16316 16316 0 0.0
.data 5040 5040 0 0.0
.rodata 100876 100876 0 0.0
.text 962218 962218 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1178624 1178624 0 0.0
.bss 16492 16492 0 0.0
.data 5024 5024 0 0.0
.rodata 99816 99816 0 0.0
.text 974540 974540 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 770860 770860 0 0.0
(read/write) 168552 168552 0 0.0
.bss 90556 90556 0 0.0
.data 3560 3560 0 0.0
.rodata 81652 81652 0 0.0
.text 688940 688940 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 787660 787660 0 0.0
(read/write) 178792 178792 0 0.0
.bss 100796 100796 0 0.0
.data 3560 3560 0 0.0
.rodata 75940 75940 0 0.0
.text 711452 711452 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 776308 776308 0 0.0
(read/write) 173240 173240 0 0.0
.bss 95244 95244 0 0.0
.data 3560 3560 0 0.0
.rodata 102700 102700 0 0.0
.text 673340 673340 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 728484 728484 0 0.0
(read/write) 167520 167520 0 0.0
.bss 89288 89288 0 0.0
.data 3552 3552 0 0.0
.rodata 77372 77372 0 0.0
.text 650844 650844 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 714116 714116 0 0.0
(read/write) 167728 167728 0 0.0
.bss 89512 89512 0 0.0
.data 3544 3544 0 0.0
.rodata 73212 73212 0 0.0
.text 640636 640636 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 581274 581274 0 0.0
(read/write) 207968 207968 0 0.0
.bss 201204 201204 0 0.0
.data 1640 1640 0 0.0
.rodata 86522 86522 0 0.0
.text 492628 492628 0 0.0
lock CC3235SF_LAUNCHXL (read only) 626570 626570 0 0.0
(read/write) 208312 208312 0 0.0
.bss 201696 201696 0 0.0
.data 1496 1496 0 0.0
.rodata 106978 106978 0 0.0
.text 517468 517468 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 566019 566019 0 0.0
.app_xip_area 455853 455853 0 0.0
.bss 65000 65000 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 548987 548987 0 0.0
.app_xip_area 434061 434061 0 0.0
.bss 69752 69752 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 567699 567699 0 0.0
.app_xip_area 459037 459037 0 0.0
.bss 63536 63536 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 562251 562251 0 0.0
.app_xip_area 450309 450309 0 0.0
.bss 66736 66736 0 0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 929792 929792 0 0.0
.bss 197912 197912 0 0.0
.data 1388 1388 0 0.0
.text 730468 730468 0 0.0
BRD4187C (read/write) 1107192 1107184 -8 -0.0
.bss 195152 195152 0 0.0
.data 3408 3408 0 0.0
.text 908612 908604 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1120564 1120564 0 0.0
.bss 186764 186764 0 0.0
.data 2792 2792 0 0.0
.text 930988 930988 0 0.0
window-app BRD4187C (read/write) 1153784 1153776 -8 -0.0
.bss 167392 167392 0 0.0
.data 3320 3320 0 0.0
.text 983052 983044 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1207462 1207462 0 0.0
(read/write) 1748464 1748464 0 0.0
.dram0.bss 74272 74272 0 0.0
.dram0.data 13620 13620 0 0.0
.flash.rodata 251040 251040 0 0.0
.flash.text 1207462 1207462 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1249587 1249587 0 0.0
(read/write) 533944 533944 0 0.0
.dram0.bss 81176 81176 0 0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 281684 281684 0 0.0
.flash.text 1243423 1243423 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 597928 597928 0 0.0
(read/write) 79560 79560 0 0.0
.bss 67380 67380 0 0.0
.data 2196 2196 0 0.0
.text 597392 597392 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 745788 745788 0 0.0
.bss 79132 79132 0 0.0
.data 2816 2816 0 0.0
.text 624472 624472 0 0.0
light k32w0+release (read only) 602088 602088 0 0.0
(read/write) 79444 79444 0 0.0
.bss 67260 67260 0 0.0
.data 2200 2200 0 0.0
.text 601552 601552 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 787552 787552 0 0.0
.bss 80524 80524 0 0.0
.data 2032 2032 0 0.0
.text 665640 665640 0 0.0
lock k32w0+release (read only) 580856 580856 0 0.0
(read/write) 77432 77432 0 0.0
.bss 65300 65300 0 0.0
.data 2148 2148 0 0.0
.text 580320 580320 0 0.0
linux air-purifier-app debug (read only) 2634149 2634149 0 0.0
(read/write) 129416 129416 0 0.0
.bss 46896 46896 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74328 74328 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 185104 185104 0 0.0
.text 2271061 2271061 0 0.0
all-clusters-app debug (read only) 5916849 5916849 0 0.0
(read/write) 479944 479944 0 0.0
.bss 134752 134752 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 333304 333304 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1376 1376 0 0.0
.rodata 348592 348592 0 0.0
.text 5134963 5134963 0 0.0
all-clusters-minimal-app debug (read only) 5209553 5209553 0 0.0
(read/write) 236808 236808 0 0.0
.bss 128032 128032 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 97320 97320 0 0.0
.dynamic 624 624 0 0.0
.got 5304 5304 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 288322 288322 0 0.0
.text 4686003 4686003 0 0.0
bridge-app debug (read only) 4606953 4606953 0 0.0
(read/write) 217680 217680 0 0.0
.bss 118560 118560 0 0.0
.data 6176 6176 0 0.0
.data.rel.ro 86224 86224 0 0.0
.dynamic 624 624 0 0.0
.got 5272 5272 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 228930 228930 0 0.0
.text 4157235 4157235 0 0.0
chip-tool debug (read only) 11986801 11986801 0 0.0
(read/write) 521232 521232 0 0.0
.bss 94264 94264 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 414656 414656 0 0.0
.dynamic 624 624 0 0.0
.got 5776 5776 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 447705 447705 0 0.0
.text 10833427 10833427 0 0.0
chip-tool-ipv6only arm64 (read only) 11484176 11484176 0 0.0
(read/write) 588600 588600 0 0.0
.bss 103352 103352 0 0.0
.data 4488 4488 0 0.0
.data.rel.ro 454416 454416 0 0.0
.dynamic 512 512 0 0.0
.got 20336 20336 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 352988 352988 0 0.0
.text 10243324 10243324 0 0.0
lighting-app debug+rpc+ui (read only) 5529185 5529185 0 0.0
(read/write) 226448 226448 0 0.0
.bss 119496 119496 0 0.0
.data 4832 4832 0 0.0
.data.rel.ro 94608 94608 0 0.0
.dynamic 672 672 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 353780 353780 0 0.0
.text 4928515 4928515 0 0.0
lock-app debug (read only) 4675089 4675089 0 0.0
(read/write) 205336 205336 0 0.0
.bss 114016 114016 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80472 80472 0 0.0
.dynamic 624 624 0 0.0
.got 5224 5224 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 254978 254978 0 0.0
.text 4207939 4207939 0 0.0
ota-provider-app debug (read only) 4307817 4307817 0 0.0
(read/write) 193896 193896 0 0.0
.bss 113792 113792 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 69856 69856 0 0.0
.dynamic 624 624 0 0.0
.got 4560 4560 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 207618 207618 0 0.0
.text 3906739 3906739 0 0.0
ota-requestor-app debug (read only) 4433977 4433977 0 0.0
(read/write) 198272 198272 0 0.0
.bss 114688 114688 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 72960 72960 0 0.0
.dynamic 624 624 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 213794 213794 0 0.0
.text 4022147 4022147 0 0.0
shell debug (read only) 2870225 2870225 0 0.0
(read/write) 155808 155808 0 0.0
.bss 62512 62512 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86128 86128 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 186208 186208 0 0.0
.text 2510994 2510994 0 0.0
thermostat-no-ble arm64 (read only) 4487448 4487448 0 0.0
(read/write) 249736 249736 0 0.0
.bss 122360 122360 0 0.0
.data 3360 3360 0 0.0
.data.rel.ro 103816 103816 0 0.0
.dynamic 512 512 0 0.0
.got 12080 12080 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 159356 159356 0 0.0
.text 3982892 3982892 0 0.0
tv-app debug (read only) 5683369 5683369 0 0.0
(read/write) 352080 352080 0 0.0
.bss 243824 243824 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 94472 94472 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 288098 288098 0 0.0
.text 5152915 5152915 0 0.0
tv-casting-app debug (read only) 9868889 9868889 0 0.0
(read/write) 340680 340680 0 0.0
.bss 156560 156560 0 0.0
.data 2944 2944 0 0.0
.data.rel.ro 174264 174264 0 0.0
.dynamic 624 624 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 382672 382672 0 0.0
.text 9020083 9020083 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2530760 2530760 0 0.0
.bss 220448 220448 0 0.0
.data 5200 5200 0 0.0
.text 1493444 1493444 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1098516 1098516 0 0.0
bss 130767 130767 0 0.0
rodata 111868 111868 0 0.0
text 808100 808100 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1218684 1218684 0 0.0
bss 122889 122889 0 0.0
rodata 141612 141612 0 0.0
text 803668 803668 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1048084 1048084 0 0.0
bss 129657 129657 0 0.0
rodata 99396 99396 0 0.0
text 771296 771296 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834504 834504 0 0.0
(read/write) 1792252 1792252 0 0.0
.bss 196180 196180 0 0.0
.data 2656 2656 0 0.0
.text 1585028 1585028 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837616 837616 0 0.0
(read/write) 1716212 1716212 0 0.0
.bss 193092 193092 0 0.0
.data 2632 2632 0 0.0
.text 1512100 1512100 0 0.0
light cy8ckit_062s2_43012 (read only) 844344 844344 0 0.0
(read/write) 1635540 1635540 0 0.0
.bss 186556 186556 0 0.0
.data 2440 2440 0 0.0
.text 1438156 1438156 0 0.0
lock cy8ckit_062s2_43012 (read only) 817184 817184 0 0.0
(read/write) 1665532 1665532 0 0.0
.bss 213716 213716 0 0.0
.data 2440 2440 0 0.0
.text 1440988 1440988 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1126072 1126072 0 0.0
.bss 102400 102400 0 0.0
.data 820 820 0 0.0
.text 638456 638456 0 0.0
lock-app qpg6105+debug (read/write) 1086064 1086064 0 0.0
.bss 97152 97152 0 0.0
.data 840 840 0 0.0
.text 598444 598444 0 0.0
stm32 light STM32WB5MM-DK (read/write) 598093 598093 0 0.0
.bss 128312 128312 0 0.0
.data 668 668 0 0.0
.rodata 78772 78772 0 0.0
.text 380616 380616 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820882 820882 0 0.0
bss 49628 49628 0 0.0
text 614714 614714 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1087732 1087732 0 0.0
bss 101720 101720 0 0.0
text 790056 790056 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1046668 1046668 0 0.0
bss 110052 110052 0 0.0
text 762652 762652 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 907908 907908 0 0.0
bss 93084 93084 0 0.0
text 650610 650610 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822498 822498 0 0.0
bss 49676 49676 0 0.0
text 616392 616392 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 928016 928016 0 0.0
bss 77676 77676 0 0.0
text 696342 696342 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1070180 1070180 0 0.0
bss 100164 100164 0 0.0
text 775124 775124 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 900600 900600 0 0.0
bss 69140 69140 0 0.0
text 651800 651800 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 926236 926236 0 0.0
bss 92664 92664 0 0.0
text 668976 668976 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 825114 825114 0 0.0
bss 49784 49784 0 0.0
text 619406 619406 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 788820 788820 0 0.0
bss 55984 55984 0 0.0
text 590154 590154 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676768 676768 0 0.0
bss 73640 73640 0 0.0
text 462284 462284 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 829526 829526 0 0.0
bss 51308 51308 0 0.0
text 622454 622454 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 847981 847981 0 0.0
bss 59460 59460 0 0.0
text 634064 634064 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 814424 814424 0 0.0
bss 56272 56272 0 0.0
text 609802 609802 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 832528 832528 0 0.0
bss 68048 68048 0 0.0
text 625060 625060 0 0.0

@mergify mergify bot merged commit aa3a804 into project-chip:1.3-sve Apr 12, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
fast track tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cecille @andy31415