Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force including <ble/Ble.h> umbrella header instead of specific headers #33023

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Force including <ble/Ble.h> umbrella header instead of specific headers #33023

merged 6 commits into from
Apr 18, 2024

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Apr 17, 2024

Problem

In the src/ble library there is a dedicated <ble/Ble.h> umbrella header which ought to be a dedicated public header for the BLE library. However, not everyone is accessing BLE library API via this header.

Changes

  • force everyone to use <ble/Ble.h> (one exception is <ble/BleConfig.h> which is included in the CHIPConfig.h)
  • fix includes in src/ble according to IWYU output
  • improve iwyu-check.py helper script a bit

Testing

CI should detect potential build breaks.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

PR #33023: Size comparison from 47c6d46 to b575fd6

Full report (11 builds for cc13x4_26x4, cc32xx, mbed, qpg, stm32)
platform target config section 47c6d46 b575fd6 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 782820 782820 0 0.0
(read/write) 171640 171640 0 0.0
.bss 93596 93596 0 0.0
.data 3584 3584 0 0.0
.rodata 82628 82628 0 0.0
.text 699928 699928 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798804 798804 0 0.0
(read/write) 182112 182112 0 0.0
.bss 104084 104084 0 0.0
.data 3576 3576 0 0.0
.rodata 76716 76716 0 0.0
.text 721820 721820 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787572 787572 0 0.0
(read/write) 176232 176232 0 0.0
.bss 98204 98204 0 0.0
.data 3576 3576 0 0.0
.rodata 103532 103532 0 0.0
.text 683776 683776 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 739884 739884 0 0.0
(read/write) 170600 170600 0 0.0
.bss 92336 92336 0 0.0
.data 3568 3568 0 0.0
.rodata 78292 78292 0 0.0
.text 661328 661328 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 725516 725516 0 0.0
(read/write) 170824 170824 0 0.0
.bss 92560 92560 0 0.0
.data 3568 3568 0 0.0
.rodata 74068 74068 0 0.0
.text 651184 651184 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586950 586950 0 0.0
(read/write) 208096 208096 0 0.0
.bss 201324 201324 0 0.0
.data 1648 1648 0 0.0
.rodata 87502 87502 0 0.0
.text 497324 497324 0 0.0
lock CC3235SF_LAUNCHXL (read only) 631766 631766 0 0.0
(read/write) 208352 208352 0 0.0
.bss 201728 201728 0 0.0
.data 1504 1504 0 0.0
.rodata 107854 107854 0 0.0
.text 521792 521792 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2534816 2534816 0 0.0
.bss 220488 220488 0 0.0
.data 5216 5216 0 0.0
.text 1497500 1497500 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1132360 1132360 0 0.0
.bss 102580 102580 0 0.0
.data 844 844 0 0.0
.text 644744 644744 0 0.0
lock-app qpg6105+debug (read/write) 1092360 1092360 0 0.0
.bss 97252 97252 0 0.0
.data 856 856 0 0.0
.text 604740 604740 0 0.0
stm32 light STM32WB5MM-DK (read/write) 603949 603949 0 0.0
.bss 128436 128436 0 0.0
.data 676 676 0 0.0
.rodata 80212 80212 0 0.0
.text 384880 384880 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2024 •
edited
Loading

PR #33023: Size comparison from 47c6d46 to f9360eb

Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 47c6d46 f9360eb change % change
bl602 lighting-app bl602 (read/write) 1443066 1443066 0 0.0
.bss 85448 85448 0 0.0
.data 9504 9504 0 0.0
.rodata 159068 159068 0 0.0
.text 1108384 1108384 0 0.0
bl602+mfd (read/write) 1457490 1457490 0 0.0
.bss 85616 85616 0 0.0
.data 9480 9480 0 0.0
.rodata 158028 158028 0 0.0
.text 1123702 1123702 0 0.0
bl602+rpc (read/write) 1490466 1490466 0 0.0
.bss 93488 93488 0 0.0
.data 9880 9880 0 0.0
.rodata 166644 166644 0 0.0
.text 1139774 1139774 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1207927 1207927 0 0.0
.bss 11185 11185 0 0.0
.data 3696 3696 0 0.0
.rodata 108432 108432 0 0.0
.text 977684 977684 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1218743 1218743 0 0.0
.bss 11361 11361 0 0.0
.data 3672 3672 0 0.0
.rodata 107372 107372 0 0.0
.text 989438 989438 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1299407 1299407 0 0.0
.bss 19669 19669 0 0.0
.data 4232 4232 0 0.0
.rodata 123804 123804 0 0.0
.text 1052392 1052392 0 0.0
bl706-eth (read/write) 1025193 1025193 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101756 101756 0 0.0
.text 768388 768388 0 0.0
bl706-wifi (read/write) 1259846 1259846 0 0.0
.bss 10645 10645 0 0.0
.data 3696 3696 0 0.0
.rodata 122756 122756 0 0.0
.text 1000280 1000280 0 0.0
bl702l lighting-app bl702l (read/write) 1177784 1177784 0 0.0
.bss 16396 16396 0 0.0
.data 5056 5056 0 0.0
.rodata 102436 102436 0 0.0
.text 970550 970550 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1188676 1188676 0 0.0
.bss 16572 16572 0 0.0
.data 5040 5040 0 0.0
.rodata 101376 101376 0 0.0
.text 982872 982872 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 782820 782820 0 0.0
(read/write) 171640 171640 0 0.0
.bss 93596 93596 0 0.0
.data 3584 3584 0 0.0
.rodata 82628 82628 0 0.0
.text 699928 699928 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 798804 798804 0 0.0
(read/write) 182112 182112 0 0.0
.bss 104084 104084 0 0.0
.data 3576 3576 0 0.0
.rodata 76716 76716 0 0.0
.text 721820 721820 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 787572 787572 0 0.0
(read/write) 176232 176232 0 0.0
.bss 98204 98204 0 0.0
.data 3576 3576 0 0.0
.rodata 103532 103532 0 0.0
.text 683776 683776 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 739884 739884 0 0.0
(read/write) 170600 170600 0 0.0
.bss 92336 92336 0 0.0
.data 3568 3568 0 0.0
.rodata 78292 78292 0 0.0
.text 661328 661328 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 725516 725516 0 0.0
(read/write) 170824 170824 0 0.0
.bss 92560 92560 0 0.0
.data 3568 3568 0 0.0
.rodata 74068 74068 0 0.0
.text 651184 651184 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586950 586950 0 0.0
(read/write) 208096 208096 0 0.0
.bss 201324 201324 0 0.0
.data 1648 1648 0 0.0
.rodata 87502 87502 0 0.0
.text 497324 497324 0 0.0
lock CC3235SF_LAUNCHXL (read only) 631766 631766 0 0.0
(read/write) 208352 208352 0 0.0
.bss 201728 201728 0 0.0
.data 1504 1504 0 0.0
.rodata 107854 107854 0 0.0
.text 521792 521792 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 569783 569783 0 0.0
.app_xip_area 459709 459709 0 0.0
.bss 64900 64900 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 551999 551999 0 0.0
.app_xip_area 437253 437253 0 0.0
.bss 69564 69564 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573111 573111 0 0.0
.app_xip_area 464533 464533 0 0.0
.bss 63444 63444 0 0.0
.data 712 712 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 565063 565063 0 0.0
.app_xip_area 453301 453301 0 0.0
.bss 66548 66548 0 0.0
.data 792 792 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1068480 1068480 0 0.0
.bss 179904 179904 0 0.0
.data 3424 3424 0 0.0
.text 885132 885132 0 0.0
lock-app BRD4338a (read/write) 960724 960724 0 0.0
.bss 210236 210236 0 0.0
.data 30272 30272 0 0.0
.text 700848 700848 0 0.0
window-app BRD4187C (read/write) 1134380 1134380 0 0.0
.bss 164504 164504 0 0.0
.data 3328 3328 0 0.0
.text 966528 966528 0 0.0
esp32 all-clusters-app c3devkit (read only) 1213534 1213534 0 0.0
(read/write) 1750240 1750240 0 0.0
.dram0.bss 74328 74328 0 0.0
.dram0.data 13628 13628 0 0.0
.flash.rodata 252752 252752 0 0.0
.flash.text 1213534 1213534 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1256183 1256183 0 0.0
(read/write) 536540 536540 0 0.0
.dram0.bss 81072 81072 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284368 284368 0 0.0
.flash.text 1250019 1250019 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2647317 2647317 0 0.0
(read/write) 130032 130032 0 0.0
.bss 46728 46728 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 185392 185392 0 0.0
.text 2282933 2282933 0 0.0
all-clusters-app debug (read only) 5956929 5956929 0 0.0
(read/write) 481512 481512 0 0.0
.bss 135040 135040 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334472 334472 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 351760 351760 0 0.0
.text 5170387 5170387 0 0.0
all-clusters-minimal-app debug (read only) 5236873 5236873 0 0.0
(read/write) 237464 237464 0 0.0
.bss 127872 127872 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98056 98056 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290410 290410 0 0.0
.text 4710339 4710339 0 0.0
bridge-app debug (read only) 4628817 4628817 0 0.0
(read/write) 218344 218344 0 0.0
.bss 118400 118400 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 86976 86976 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 230794 230794 0 0.0
.text 4176323 4176323 0 0.0
chip-tool debug (read only) 12084641 12084641 0 0.0
(read/write) 523104 523104 0 0.0
.bss 94744 94744 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416000 416000 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451449 451449 0 0.0
.text 10924835 10924835 0 0.0
chip-tool-ipv6only arm64 (read only) 11403972 11403972 0 0.0
(read/write) 587232 587232 0 0.0
.bss 103720 103720 0 0.0
.data 4512 4512 0 0.0
.data.rel.ro 455936 455936 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356260 356260 0 0.0
.text 10166024 10166024 0 0.0
lighting-app debug+rpc+ui (read only) 5552929 5552929 0 0.0
(read/write) 227112 227112 0 0.0
.bss 119344 119344 0 0.0
.data 4864 4864 0 0.0
.data.rel.ro 95376 95376 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 354676 354676 0 0.0
.text 4950163 4950163 0 0.0
lock-app debug (read only) 4694681 4694681 0 0.0
(read/write) 205568 205568 0 0.0
.bss 113704 113704 0 0.0
.data 4160 4160 0 0.0
.data.rel.ro 81000 81000 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 256586 256586 0 0.0
.text 4225459 4225459 0 0.0
ota-provider-app debug (read only) 4310161 4310161 0 0.0
(read/write) 194200 194200 0 0.0
.bss 113440 113440 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70448 70448 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209642 209642 0 0.0
.text 3906035 3906035 0 0.0
ota-requestor-app debug (read only) 4440993 4440993 0 0.0
(read/write) 198568 198568 0 0.0
.bss 114336 114336 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215914 215914 0 0.0
.text 4026051 4026051 0 0.0
shell debug (read only) 2923497 2923497 0 0.0
(read/write) 156880 156880 0 0.0
.bss 62512 62512 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87152 87152 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 187872 187872 0 0.0
.text 2560946 2560946 0 0.0
thermostat-no-ble arm64 (read only) 4429260 4429260 0 0.0
(read/write) 246160 246160 0 0.0
.bss 121976 121976 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 104296 104296 0 0.0
.dynamic 512 512 0 0.0
.got 8712 8712 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160148 160148 0 0.0
.text 3932568 3932568 0 0.0
tv-app debug (read only) 5767065 5767065 0 0.0
(read/write) 353336 353336 0 0.0
.bss 244336 244336 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95160 95160 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 294730 294730 0 0.0
.text 5229011 5229011 0 0.0
tv-casting-app debug (read only) 9897137 9897137 0 0.0
(read/write) 342720 342720 0 0.0
.bss 157976 157976 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174848 174848 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 384472 384472 0 0.0
.text 9045859 9045859 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2534816 2534816 0 0.0
.bss 220488 220488 0 0.0
.data 5216 5216 0 0.0
.text 1497500 1497500 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1065016 1065016 0 0.0
bss 133107 133107 0 0.0
rodata 103096 103096 0 0.0
text 781600 781600 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1225908 1225908 0 0.0
bss 127171 127171 0 0.0
rodata 151304 151304 0 0.0
text 797400 797400 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1012496 1012496 0 0.0
bss 131965 131965 0 0.0
rodata 90360 90360 0 0.0
text 742968 742968 0 0.0
light-switch-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 964116 964116 0 0.0
bss 126026 126026 0 0.0
rodata 79820 79820 0 0.0
text 711136 711136 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1198364 1198364 0 0.0
bss 119347 119347 0 0.0
rodata 178200 178200 0 0.0
text 746660 746660 0 0.0
lighting-app nrf52840dk_nrf52840+rpc (read only) 4 4 0 0.0
(read/write) 1064080 1064080 0 0.0
bss 137777 137777 0 0.0
rodata 85536 85536 0 0.0
text 790480 790480 0 0.0
nrf52840dongle_nrf52840 (read only) 4 4 0 0.0
(read/write) 1018888 1018888 0 0.0
bss 145782 145782 0 0.0
rodata 75456 75456 0 0.0
text 742640 742640 0 0.0
nrf5340dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 962076 962076 0 0.0
bss 136583 136583 0 0.0
rodata 81324 81324 0 0.0
text 692180 692180 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1198364 1198364 0 0.0
bss 119347 119347 0 0.0
rodata 178200 178200 0 0.0
text 746660 746660 0 0.0
lock-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 976476 976476 0 0.0
bss 126557 126557 0 0.0
rodata 99380 99380 0 0.0
text 703452 703452 0 0.0
nrf5340dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 906716 906716 0 0.0
bss 126623 126623 0 0.0
rodata 100804 100804 0 0.0
text 627304 627304 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1211664 1211664 0 0.0
bss 119878 119878 0 0.0
rodata 197768 197768 0 0.0
text 739876 739876 0 0.0
pump-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 927524 927524 0 0.0
bss 125234 125234 0 0.0
rodata 74884 74884 0 0.0
text 680324 680324 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 913828 913828 0 0.0
bss 125033 125033 0 0.0
rodata 71620 71620 0 0.0
text 670164 670164 0 0.0
nxp contact k32w0+release (read only) 575100 575100 0 0.0
(read/write) 80012 80012 0 0.0
.bss 67848 67848 0 0.0
.data 2180 2180 0 0.0
.text 574564 574564 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 702220 702220 0 0.0
.bss 71192 71192 0 0.0
.data 2856 2856 0 0.0
.text 588792 588792 0 0.0
light k32w0+release (read only) 609040 609040 0 0.0
(read/write) 79472 79472 0 0.0
.bss 67288 67288 0 0.0
.data 2200 2200 0 0.0
.text 608504 608504 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 793992 793992 0 0.0
.bss 80736 80736 0 0.0
.data 2056 2056 0 0.0
.text 671832 671832 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832280 832280 0 0.0
(read/write) 1803444 1803444 0 0.0
.bss 198372 198372 0 0.0
.data 2688 2688 0 0.0
.text 1593996 1593996 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835432 835432 0 0.0
(read/write) 1725332 1725332 0 0.0
.bss 195252 195252 0 0.0
.data 2656 2656 0 0.0
.text 1519036 1519036 0 0.0
light cy8ckit_062s2_43012 (read only) 842160 842160 0 0.0
(read/write) 1644060 1644060 0 0.0
.bss 188716 188716 0 0.0
.data 2464 2464 0 0.0
.text 1444492 1444492 0 0.0
lock cy8ckit_062s2_43012 (read only) 815088 815088 0 0.0
(read/write) 1672748 1672748 0 0.0
.bss 215796 215796 0 0.0
.data 2456 2456 0 0.0
.text 1446108 1446108 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1132360 1132360 0 0.0
.bss 102580 102580 0 0.0
.data 844 844 0 0.0
.text 644744 644744 0 0.0
lock-app qpg6105+debug (read/write) 1092360 1092360 0 0.0
.bss 97252 97252 0 0.0
.data 856 856 0 0.0
.text 604740 604740 0 0.0
stm32 light STM32WB5MM-DK (read/write) 603949 603949 0 0.0
.bss 128436 128436 0 0.0
.data 676 676 0 0.0
.rodata 80212 80212 0 0.0
.text 384880 384880 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 833042 833042 0 0.0
bss 49844 49844 0 0.0
text 624058 624058 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1096264 1096264 0 0.0
bss 101528 101528 0 0.0
text 797604 797604 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1057728 1057728 0 0.0
bss 109976 109976 0 0.0
text 771966 771966 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 913120 913120 0 0.0
bss 92732 92732 0 0.0
text 655312 655312 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 835078 835078 0 0.0
bss 49888 49888 0 0.0
text 626164 626164 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 935864 935864 0 0.0
bss 77500 77500 0 0.0
text 702830 702830 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1089632 1089632 0 0.0
bss 99824 99824 0 0.0
text 793420 793420 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 910316 910316 0 0.0
bss 69168 69168 0 0.0
text 659696 659696 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 932900 932900 0 0.0
bss 92436 92436 0 0.0
text 674972 674972 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 832724 832724 0 0.0
bss 58132 58132 0 0.0
text 623260 623260 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 798852 798852 0 0.0
bss 56060 56060 0 0.0
text 598166 598166 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676016 676016 0 0.0
bss 73412 73412 0 0.0
text 461764 461764 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 842810 842810 0 0.0
bss 51516 51516 0 0.0
text 632706 632706 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858565 858565 0 0.0
bss 59684 59684 0 0.0
text 642268 642268 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 824400 824400 0 0.0
bss 56392 56392 0 0.0
text 617722 617722 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 837516 837516 0 0.0
bss 58348 58348 0 0.0
text 625630 625630 0 0.0

@Damian-Nordic
Copy link
Contributor

Actually, why is it better to have a single header for everything instead of including only what is needed?

@arkq
Copy link
Contributor Author

arkq commented Apr 17, 2024 •
edited
Loading

Actually, why is it better to have a single header for everything instead of including only what is needed?

Actually it depends.

I thought that the intent of the ble/Ble.h header was to define a single header for the BLE internal library, so any refactoring in the src/ble will not imply changes in dependent components. However, since this lib is a static lib used (only ?) internally, maybe this ble/Ble.h should be dropped in favor of actually including what is needed. So, there are two ways of doing things and I think that we should choose one of these. Personally, I would favor your way - treat this BLE library as an internal library only and do not define any public include for it. But since there was already this umbrella header, I've tried to use only it in the rest of the code.

@Damian-Nordic
Copy link
Contributor

Damian-Nordic commented Apr 17, 2024 •
edited
Loading

Actually, why is it better to have a single header for everything instead of including only what is needed?

Actually it depends.

I thought that the intent of the ble/Ble.h header was to define a single header for the BLE internal library, so any refactoring in the src/ble will not imply changes in dependent components. However, since this lib is a static lib used (only ?) internally, maybe this ble/Ble.h should be dropped in favor of actually including what is needed. So, there are two ways of doing things and I think that we should choose one of these. Personally, I would favor your way - treat this BLE library as an internal library only and do not define any public include for it. But since there was already this umbrella header, I've tried to use only it in the rest of the code.

Thanks for the clarification. Right, I don't have a strong opinion which option is better (though subjectively, I prefer if headers explicitly include what they need instead of relying on some outer header) and your PR is an improvement in a way it at least enforces the correct usage of the headers, but I was just curious about your reasons.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2024 •
edited
Loading

PR #33023: Size comparison from 511c974 to 40ca835

Decreases (5 builds for cyw30739, efr32)
platform target config section 511c974 40ca835 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 570455 570447 -8 -0.0
.app_xip_area 460365 460357 -8 -0.0
lock cyw930739m2evb_01 (read/write) 552671 552663 -8 -0.0
.app_xip_area 437909 437901 -8 -0.0
ota-requestor cyw930739m2evb_01 (read/write) 573223 573215 -8 -0.0
.app_xip_area 464629 464621 -8 -0.0
efr32 lighting-app BRD4187C (read/write) 1069672 1069664 -8 -0.0
.text 886300 886292 -8 -0.0
window-app BRD4187C (read/write) 1136092 1136084 -8 -0.0
.text 968216 968208 -8 -0.0
Full report (82 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
platform target config section 511c974 40ca835 change % change
bl602 lighting-app bl602 (read/write) 1443066 1443066 0 0.0
.bss 85448 85448 0 0.0
.data 9512 9512 0 0.0
.rodata 159068 159068 0 0.0
.text 1108384 1108384 0 0.0
bl602+mfd (read/write) 1457490 1457490 0 0.0
.bss 85616 85616 0 0.0
.data 9488 9488 0 0.0
.rodata 158028 158028 0 0.0
.text 1123702 1123702 0 0.0
bl602+rpc (read/write) 1490466 1490466 0 0.0
.bss 93488 93488 0 0.0
.data 9888 9888 0 0.0
.rodata 166644 166644 0 0.0
.text 1139774 1139774 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1209499 1209499 0 0.0
.bss 11185 11185 0 0.0
.data 3704 3704 0 0.0
.rodata 108768 108768 0 0.0
.text 978896 978896 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1220323 1220323 0 0.0
.bss 11361 11361 0 0.0
.data 3688 3688 0 0.0
.rodata 107708 107708 0 0.0
.text 990650 990650 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1300987 1300987 0 0.0
.bss 19669 19669 0 0.0
.data 4248 4248 0 0.0
.rodata 124140 124140 0 0.0
.text 1053604 1053604 0 0.0
bl706-eth (read/write) 1025205 1025205 0 0.0
.bss 23760 23760 0 0.0
.data 3256 3256 0 0.0
.rodata 101756 101756 0 0.0
.text 768400 768400 0 0.0
bl706-wifi (read/write) 1259866 1259866 0 0.0
.bss 10645 10645 0 0.0
.data 3704 3704 0 0.0
.rodata 122756 122756 0 0.0
.text 1000292 1000292 0 0.0
bl702l lighting-app bl702l (read/write) 1179336 1179336 0 0.0
.bss 16396 16396 0 0.0
.data 5072 5072 0 0.0
.rodata 102772 102772 0 0.0
.text 971750 971750 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1190236 1190236 0 0.0
.bss 16572 16572 0 0.0
.data 5048 5048 0 0.0
.rodata 101712 101712 0 0.0
.text 984072 984072 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 783724 783724 0 0.0
(read/write) 171660 171660 0 0.0
.bss 93604 93604 0 0.0
.data 3588 3588 0 0.0
.rodata 82932 82932 0 0.0
.text 700528 700528 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 799580 799580 0 0.0
(read/write) 182148 182148 0 0.0
.bss 104092 104092 0 0.0
.data 3588 3588 0 0.0
.rodata 76916 76916 0 0.0
.text 722396 722396 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 788476 788476 0 0.0
(read/write) 176268 176268 0 0.0
.bss 98212 98212 0 0.0
.data 3588 3588 0 0.0
.rodata 103836 103836 0 0.0
.text 684376 684376 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 740796 740796 0 0.0
(read/write) 170636 170636 0 0.0
.bss 92344 92344 0 0.0
.data 3580 3580 0 0.0
.rodata 78596 78596 0 0.0
.text 661936 661936 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 726420 726420 0 0.0
(read/write) 170844 170844 0 0.0
.bss 92568 92568 0 0.0
.data 3572 3572 0 0.0
.rodata 74372 74372 0 0.0
.text 651784 651784 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 586950 586950 0 0.0
(read/write) 208100 208100 0 0.0
.bss 201324 201324 0 0.0
.data 1652 1652 0 0.0
.rodata 87502 87502 0 0.0
.text 497324 497324 0 0.0
lock CC3235SF_LAUNCHXL (read only) 633142 633142 0 0.0
(read/write) 208364 208364 0 0.0
.bss 201728 201728 0 0.0
.data 1516 1516 0 0.0
.rodata 108190 108190 0 0.0
.text 522832 522832 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 570455 570447 -8 -0.0
.app_xip_area 460365 460357 -8 -0.0
.bss 64908 64908 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 552671 552663 -8 -0.0
.app_xip_area 437909 437901 -8 -0.0
.bss 69572 69572 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573223 573215 -8 -0.0
.app_xip_area 464629 464621 -8 -0.0
.bss 63452 63452 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 565727 565727 0 0.0
.app_xip_area 453949 453949 0 0.0
.bss 66556 66556 0 0.0
.data 800 800 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4187C (read/write) 1069672 1069664 -8 -0.0
.bss 179920 179920 0 0.0
.data 3432 3432 0 0.0
.text 886300 886292 -8 -0.0
lock-app BRD4338a (read/write) 962068 962068 0 0.0
.bss 210236 210236 0 0.0
.data 30288 30288 0 0.0
.text 702176 702176 0 0.0
window-app BRD4187C (read/write) 1136092 1136084 -8 -0.0
.bss 164520 164520 0 0.0
.data 3336 3336 0 0.0
.text 968216 968208 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1214260 1214260 0 0.0
(read/write) 1750696 1750696 0 0.0
.dram0.bss 74328 74328 0 0.0
.dram0.data 13636 13636 0 0.0
.flash.rodata 253192 253192 0 0.0
.flash.text 1214260 1214260 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1256843 1256843 0 0.0
(read/write) 536956 536956 0 0.0
.dram0.bss 81064 81064 0 0.0
.dram0.data 35180 35180 0 0.0
.flash.rodata 284792 284792 0 0.0
.flash.text 1250679 1250679 0 0.0
.iram0.text 125403 125403 0 0.0
linux air-purifier-app debug (read only) 2647317 2647317 0 0.0
(read/write) 130032 130032 0 0.0
.bss 46728 46728 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 75080 75080 0 0.0
.dynamic 608 608 0 0.0
.got 4520 4520 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 185392 185392 0 0.0
.text 2282933 2282933 0 0.0
all-clusters-app debug (read only) 5962073 5962073 0 0.0
(read/write) 481672 481672 0 0.0
.bss 135040 135040 0 0.0
.data 4560 4560 0 0.0
.data.rel.ro 334632 334632 0 0.0
.dynamic 624 624 0 0.0
.got 5328 5328 0 0.0
.init 27 27 0 0.0
.init_array 1440 1440 0 0.0
.rodata 352208 352208 0 0.0
.text 5174723 5174723 0 0.0
all-clusters-minimal-app debug (read only) 5242049 5242049 0 0.0
(read/write) 237624 237624 0 0.0
.bss 127872 127872 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 98216 98216 0 0.0
.dynamic 624 624 0 0.0
.got 5248 5248 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 290858 290858 0 0.0
.text 4714707 4714707 0 0.0
bridge-app debug (read only) 4634009 4634009 0 0.0
(read/write) 218536 218536 0 0.0
.bss 118400 118400 0 0.0
.data 6240 6240 0 0.0
.data.rel.ro 87168 87168 0 0.0
.dynamic 624 624 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 231242 231242 0 0.0
.text 4180707 4180707 0 0.0
chip-tool debug (read only) 12084593 12084593 0 0.0
(read/write) 523104 523104 0 0.0
.bss 94744 94744 0 0.0
.data 5122 5122 0 0.0
.data.rel.ro 416000 416000 0 0.0
.dynamic 624 624 0 0.0
.got 5736 5736 0 0.0
.init 27 27 0 0.0
.init_array 832 832 0 0.0
.rodata 451449 451449 0 0.0
.text 10924787 10924787 0 0.0
chip-tool-ipv6only arm64 (read only) 11403940 11403940 0 0.0
(read/write) 587264 587264 0 0.0
.bss 103720 103720 0 0.0
.data 4520 4520 0 0.0
.data.rel.ro 455936 455936 0 0.0
.dynamic 512 512 0 0.0
.got 17112 17112 0 0.0
.init 24 24 0 0.0
.init_array 280 280 0 0.0
.rodata 356260 356260 0 0.0
.text 10165992 10165992 0 0.0
lighting-app debug+rpc+ui (read only) 5558057 5558057 0 0.0
(read/write) 227304 227304 0 0.0
.bss 119344 119344 0 0.0
.data 4896 4896 0 0.0
.data.rel.ro 95536 95536 0 0.0
.dynamic 672 672 0 0.0
.got 5856 5856 0 0.0
.init 27 27 0 0.0
.init_array 976 976 0 0.0
.rodata 355124 355124 0 0.0
.text 4954483 4954483 0 0.0
lock-app debug (read only) 4699857 4699857 0 0.0
(read/write) 205760 205760 0 0.0
.bss 113704 113704 0 0.0
.data 4192 4192 0 0.0
.data.rel.ro 81160 81160 0 0.0
.dynamic 624 624 0 0.0
.got 5168 5168 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 257034 257034 0 0.0
.text 4229827 4229827 0 0.0
ota-provider-app debug (read only) 4310161 4310161 0 0.0
(read/write) 194200 194200 0 0.0
.bss 113440 113440 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 70448 70448 0 0.0
.dynamic 624 624 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 209642 209642 0 0.0
.text 3906035 3906035 0 0.0
ota-requestor-app debug (read only) 4440993 4440993 0 0.0
(read/write) 198568 198568 0 0.0
.bss 114336 114336 0 0.0
.data 4768 4768 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 624 624 0 0.0
.got 4472 4472 0 0.0
.init 27 27 0 0.0
.init_array 800 800 0 0.0
.rodata 215914 215914 0 0.0
.text 4026051 4026051 0 0.0
shell debug (read only) 2928641 2928641 0 0.0
(read/write) 157040 157040 0 0.0
.bss 62512 62512 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 87312 87312 0 0.0
.dynamic 592 592 0 0.0
.got 4056 4056 0 0.0
.init 27 27 0 0.0
.init_array 1112 1112 0 0.0
.rodata 188288 188288 0 0.0
.text 2565314 2565314 0 0.0
thermostat-no-ble arm64 (read only) 4433564 4433564 0 0.0
(read/write) 245936 245936 0 0.0
.bss 121976 121976 0 0.0
.data 3408 3408 0 0.0
.data.rel.ro 104424 104424 0 0.0
.dynamic 512 512 0 0.0
.got 8728 8728 0 0.0
.init 24 24 0 0.0
.init_array 448 448 0 0.0
.rodata 160388 160388 0 0.0
.text 3936328 3936328 0 0.0
tv-app debug (read only) 5772193 5772193 0 0.0
(read/write) 353496 353496 0 0.0
.bss 244336 244336 0 0.0
.data 6560 6560 0 0.0
.data.rel.ro 95320 95320 0 0.0
.dynamic 624 624 0 0.0
.got 5464 5464 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 295178 295178 0 0.0
.text 5233331 5233331 0 0.0
tv-casting-app debug (read only) 9897137 9897137 0 0.0
(read/write) 342720 342720 0 0.0
.bss 157976 157976 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 174848 174848 0 0.0
.dynamic 624 624 0 0.0
.got 5040 5040 0 0.0
.init 27 27 0 0.0
.init_array 1216 1216 0 0.0
.rodata 384472 384472 0 0.0
.text 9045859 9045859 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2535696 2535696 0 0.0
.bss 220488 220488 0 0.0
.data 5216 5216 0 0.0
.text 1498380 1498380 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1065984 1065984 0 0.0
bss 133119 133119 0 0.0
rodata 103400 103400 0 0.0
text 782256 782256 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1226472 1226472 0 0.0
bss 127175 127175 0 0.0
rodata 151368 151368 0 0.0
text 797900 797900 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1013584 1013584 0 0.0
bss 131977 131977 0 0.0
rodata 90664 90664 0 0.0
text 743624 743624 0 0.0
light-switch-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 965084 965084 0 0.0
bss 126038 126038 0 0.0
rodata 80124 80124 0 0.0
text 711792 711792 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1199228 1199228 0 0.0
bss 119351 119351 0 0.0
rodata 178500 178500 0 0.0
text 747228 747228 0 0.0
lighting-app nrf52840dk_nrf52840+rpc (read only) 4 4 0 0.0
(read/write) 1065036 1065036 0 0.0
bss 137789 137789 0 0.0
rodata 85836 85836 0 0.0
text 791136 791136 0 0.0
nrf52840dongle_nrf52840 (read only) 4 4 0 0.0
(read/write) 1019984 1019984 0 0.0
bss 145794 145794 0 0.0
rodata 75760 75760 0 0.0
text 743296 743296 0 0.0
nrf5340dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 963036 963036 0 0.0
bss 136595 136595 0 0.0
rodata 81628 81628 0 0.0
text 692836 692836 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1199228 1199228 0 0.0
bss 119351 119351 0 0.0
rodata 178500 178500 0 0.0
text 747228 747228 0 0.0
lock-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 977436 977436 0 0.0
bss 126569 126569 0 0.0
rodata 99684 99684 0 0.0
text 704108 704108 0 0.0
nrf5340dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 907676 907676 0 0.0
bss 126635 126635 0 0.0
rodata 101108 101108 0 0.0
text 627960 627960 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1212520 1212520 0 0.0
bss 119882 119882 0 0.0
rodata 198068 198068 0 0.0
text 740440 740440 0 0.0
pump-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 928488 928488 0 0.0
bss 125246 125246 0 0.0
rodata 75184 75184 0 0.0
text 680980 680980 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 914792 914792 0 0.0
bss 125045 125045 0 0.0
rodata 71920 71920 0 0.0
text 670820 670820 0 0.0
nxp contact k32w0+release (read only) 575756 575756 0 0.0
(read/write) 80028 80028 0 0.0
.bss 67856 67856 0 0.0
.data 2188 2188 0 0.0
.text 575220 575220 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 703028 703028 0 0.0
.bss 71200 71200 0 0.0
.data 2864 2864 0 0.0
.text 589584 589584 0 0.0
light k32w0+release (read only) 609776 609776 0 0.0
(read/write) 79488 79488 0 0.0
.bss 67296 67296 0 0.0
.data 2208 2208 0 0.0
.text 609240 609240 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 794968 794968 0 0.0
.bss 80744 80744 0 0.0
.data 2064 2064 0 0.0
.text 672792 672792 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 832272 832272 0 0.0
(read/write) 1804796 1804796 0 0.0
.bss 198380 198380 0 0.0
.data 2688 2688 0 0.0
.text 1595340 1595340 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 835424 835424 0 0.0
(read/write) 1726700 1726700 0 0.0
.bss 195260 195260 0 0.0
.data 2656 2656 0 0.0
.text 1520396 1520396 0 0.0
light cy8ckit_062s2_43012 (read only) 842144 842144 0 0.0
(read/write) 1645420 1645420 0 0.0
.bss 188724 188724 0 0.0
.data 2472 2472 0 0.0
.text 1445836 1445836 0 0.0
lock cy8ckit_062s2_43012 (read only) 815072 815072 0 0.0
(read/write) 1674108 1674108 0 0.0
.bss 215804 215804 0 0.0
.data 2464 2464 0 0.0
.text 1447452 1447452 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1133316 1133316 0 0.0
.bss 102588 102588 0 0.0
.data 856 856 0 0.0
.text 645696 645696 0 0.0
lock-app qpg6105+debug (read/write) 1093316 1093316 0 0.0
.bss 97260 97260 0 0.0
.data 860 860 0 0.0
.text 605700 605700 0 0.0
stm32 light STM32WB5MM-DK (read/write) 604921 604921 0 0.0
.bss 128444 128444 0 0.0
.data 688 688 0 0.0
.rodata 80516 80516 0 0.0
.text 385528 385528 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 834086 834086 0 0.0
bss 49856 49856 0 0.0
text 624770 624770 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1097308 1097308 0 0.0
bss 101540 101540 0 0.0
text 798316 798316 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1058772 1058772 0 0.0
bss 109988 109988 0 0.0
text 772678 772678 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 914156 914156 0 0.0
bss 92744 92744 0 0.0
text 656024 656024 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 836114 836114 0 0.0
bss 49900 49900 0 0.0
text 626876 626876 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 936908 936908 0 0.0
bss 77512 77512 0 0.0
text 703542 703542 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1090668 1090668 0 0.0
bss 99836 99836 0 0.0
text 794132 794132 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 911360 911360 0 0.0
bss 69180 69180 0 0.0
text 660408 660408 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 933008 933008 0 0.0
bss 92448 92448 0 0.0
text 675066 675066 0 0.0
pump-app tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 833760 833760 0 0.0
bss 58144 58144 0 0.0
text 623972 623972 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 799888 799888 0 0.0
bss 56072 56072 0 0.0
text 598878 598878 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676128 676128 0 0.0
bss 73424 73424 0 0.0
text 461864 461864 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 843854 843854 0 0.0
bss 51528 51528 0 0.0
text 633418 633418 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 858673 858673 0 0.0
bss 59696 59696 0 0.0
text 642362 642362 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 825436 825436 0 0.0
bss 56404 56404 0 0.0
text 618434 618434 0 0.0
window-covering tlsr9258a (read only) 52490 52490 0 0.0
(read/write) 838560 838560 0 0.0
bss 58360 58360 0 0.0
text 626342 626342 0 0.0

@mergify mergify bot merged commit 9966940 into project-chip:master Apr 18, 2024
65 checks passed
@arkq arkq deleted the ble branch April 18, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@dhrishi dhrishi Awaiting requested review from dhrishi

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo joonhaengHeo is a code owner

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@woody-apple woody-apple Awaiting requested review from woody-apple

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app ble controller core darwin esp32 examples lib linux platform review - approved scripts silabs telink tizen For Tizen platform transport zephyr
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkq @Damian-Nordic @yunhanw-google