-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TC-CNET-4.13: Update cnet 4.13 test as per spec #33024
Open
Kshitijjain21
wants to merge
8
commits into
project-chip:master
Choose a base branch
from
Kshitijjain21:update-CNET-4.13-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0a70418
send a commission complete command after adding networks
Kshitijjain21 8a0ec9a
Merge branch 'project-chip:master' into update-CNET-4.13-test
Kshitijjain21 aaa8a20
Restyled by prettier-yaml
restyled-commits ebccaae
Merge branch 'master' into update-CNET-4.13-test
Kshitijjain21 2207e90
arm fail safe after commissioning complete command
Kshitijjain21 3886fb2
Merge branch 'update-CNET-4.13-test' of github.com:Kshitijjain21/conn…
Kshitijjain21 1164d6a
Merge branch 'project-chip:master' into update-CNET-4.13-test
Kshitijjain21 e6a2f46
arm fail safe after commissioning complete command
Kshitijjain21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new disabled (i.e. manual) test step. We generally do not allow new manual test steps anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. The change done here is allow this test to align with the matter spec. Since the test was a manual test and has not been changed to an automated/semi automated test what would be the correct course of action to get it to align with the spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andy31415 since this is a old cert test, we can make updates to the manual test.
@Kshitijjain21 But we can not merge this change unless test plan PR is approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds several new steps that are manual ... so it kind of makes the problem worse. I understand the justification of "we add a test step in a long list of test steps that is already manual" however I also am concerned that this does increase the count of manual stuff invocation. We should not do that.