Make chip::Dnssd::kMaxDeviceNameLen configurable #33036

sharadb-amazon · 2024-04-17T20:21:10Z

Change Summary

Added a gn variable chip_max_device_name_len and set its default value to the existing value of chip::Dnssd::kMaxDeviceNameLen.
Used chip_max_device_name_len to set a C++ macro CHIP_DEVICE_CONFIG_MAX_DEVICE_NAME_LEN in src/platform/BUILD.gn
Overrode chip_max_device_name_len to 128 for the android/darwin/linux tv-casting-apps in their args.gni files. For TV Casting use cases, TV names can be strings that are longer than 32 bytes.

Testing

Tested with the iOS tv-casting-app and saw the full deviceName appearing in discovery results: シャラドのエコーショー15

github-actions · 2024-04-17T20:34:05Z

PR #33036: Size comparison from 035d302 to 9961c45

Full report (38 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)

platform	target	config	section	`035d302`	`9961c45`
bl602	lighting-app	bl602	(read/write)	1443066	1443066
			.bss	85448	85448
			.data	9504	9504
			.rodata	159068	159068
			.text	1108384	1108384
		bl602+mfd	(read/write)	`1457490`	`1457490`
			.bss	85616	85616
			.data	9480	9480
			.rodata	158028	158028
			.text	`1123702`	`1123702`
		bl602+rpc	(read/write)	1490466	1490466
			.bss	93488	93488
			.data	9880	9880
			.rodata	166644	166644
			.text	`1139774`	`1139774`
bl702	lighting-app	bl702	(read only)	3478	3478
			(read/write)	1207927	1207927
			.bss	11185	11185
			.data	3696	3696
			.rodata	108432	108432
			.text	977684	977684
		bl702+mfd	(read only)	3478	3478
			(read/write)	1218743	1218743
			.bss	11361	11361
			.data	3672	3672
			.rodata	107372	107372
			.text	989438	989438
		bl702+rpc	(read only)	3478	3478
			(read/write)	1299407	1299407
			.bss	19669	19669
			.data	4232	4232
			.rodata	123804	123804
			.text	1052392	1052392
		bl706-eth	(read/write)	`1025193`	`1025193`
			.bss	23760	23760
			.data	3256	3256
			.rodata	101756	101756
			.text	768388	768388
		bl706-wifi	(read/write)	`1259846`	`1259846`
			.bss	10645	10645
			.data	3696	3696
			.rodata	122756	122756
			.text	1000280	1000280
bl702l	lighting-app	bl702l	(read/write)	1177784	1177784
			.bss	16396	16396
			.data	5056	5056
			.rodata	102436	102436
			.text	970550	970550
		bl702l+mfd	(read only)	512	512
			(read/write)	1188676	1188676
			.bss	16572	16572
			.data	5040	5040
			.rodata	101376	101376
			.text	982872	982872
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	(read only)	782820	782820
			(read/write)	171640	171640
			.bss	93596	93596
			.data	3584	3584
			.rodata	82628	82628
			.text	699928	699928
	lock-ftd	LP_EM_CC1354P10_6	(read only)	798804	798804
			(read/write)	182112	182112
			.bss	104084	104084
			.data	3576	3576
			.rodata	76716	76716
			.text	721820	721820
	lock-mtd	LP_EM_CC1354P10_6	(read only)	787572	787572
			(read/write)	176232	176232
			.bss	98204	98204
			.data	3576	3576
			.rodata	103532	103532
			.text	683776	683776
	pump-app	LP_EM_CC1354P10_6	(read only)	739884	739884
			(read/write)	170600	170600
			.bss	92336	92336
			.data	3568	3568
			.rodata	78292	78292
			.text	661328	661328
	pump-controller-app	LP_EM_CC1354P10_6	(read only)	725516	725516
			(read/write)	170824	170824
			.bss	92560	92560
			.data	3568	3568
			.rodata	74068	74068
			.text	651184	651184
cc32xx	air-purifier	CC3235SF_LAUNCHXL	(read only)	586950	586950
			(read/write)	208096	208096
			.bss	201324	201324
			.data	1648	1648
			.rodata	87502	87502
			.text	497324	497324
	lock	CC3235SF_LAUNCHXL	(read only)	631766	631766
			(read/write)	208352	208352
			.bss	201728	201728
			.data	1504	1504
			.rodata	107854	107854
			.text	521792	521792
cyw30739	light	cyw930739m2evb_01	(read/write)	569783	569783
			.app_xip_area	459709	459709
			.bss	64900	64900
			.data	752	752
			.rodata	0	0
			.text	112	112
	lock	cyw930739m2evb_01	(read/write)	551999	551999
			.app_xip_area	437253	437253
			.bss	69564	69564
			.data	760	760
			.rodata	0	0
			.text	112	112
	ota-requestor	cyw930739m2evb_01	(read/write)	573111	573111
			.app_xip_area	464533	464533
			.bss	63444	63444
			.data	712	712
			.rodata	0	0
			.text	112	112
	switch	cyw930739m2evb_01	(read/write)	565063	565063
			.app_xip_area	453301	453301
			.bss	66548	66548
			.data	792	792
			.rodata	0	0
			.text	112	112
linux	chip-tool-ipv6only	arm64	(read only)	11403972	11403972
			(read/write)	587232	587232
			.bss	103720	103720
			.data	4512	4512
			.data.rel.ro	455936	455936
			.dynamic	512	512
			.got	17112	17112
			.init	24	24
			.init_array	280	280
			.rodata	356260	356260
			.text	10166024	10166024
	thermostat-no-ble	arm64	(read only)	4429260	4429260
			(read/write)	246160	246160
			.bss	121976	121976
			.data	3392	3392
			.data.rel.ro	104296	104296
			.dynamic	512	512
			.got	8712	8712
			.init	24	24
			.init_array	448	448
			.rodata	160148	160148
			.text	3932568	3932568
mbed	lock-app-release	cy8cproto_062_4343w	(read only)	6224	6224
			(read/write)	2534816	2534816
			.bss	220488	220488
			.data	5216	5216
			.text	1497500	1497500
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4
			(read/write)	`1065016`	`1065016`
			bss	133107	133107
			rodata	103096	103096
			text	781600	781600
		nrf7002dk_nrf5340_cpuapp	(read only)	4	4
			(read/write)	1225908	1225908
			bss	127171	127171
			rodata	151304	151304
			text	797400	797400
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4
			(read/write)	1012496	1012496
			bss	131965	131965
			rodata	90360	90360
			text	742968	742968
nxp	contact	k32w0+release	(read only)	575100	575100
			(read/write)	80012	80012
			.bss	67848	67848
			.data	2180	2180
			.text	574564	574564
		k32w1+release	(read only)	1024	1024
			(read/write)	702220	702220
			.bss	71192	71192
			.data	2856	2856
			.text	588792	588792
	light	k32w0+release	(read only)	609040	609040
			(read/write)	79472	79472
			.bss	67288	67288
			.data	2200	2200
			.text	608504	608504
		k32w1+release	(read only)	1024	1024
			(read/write)	793992	793992
			.bss	80736	80736
			.data	2056	2056
			.text	671832	671832
psoc6	all-clusters	cy8ckit_062s2_43012	(read only)	832280	832280
			(read/write)	1803444	1803444
			.bss	198372	198372
			.data	2688	2688
			.text	1593996	1593996
	all-clusters-minimal	cy8ckit_062s2_43012	(read only)	835432	835432
			(read/write)	1725332	1725332
			.bss	195252	195252
			.data	2656	2656
			.text	1519036	1519036
	light	cy8ckit_062s2_43012	(read only)	842160	842160
			(read/write)	1644060	1644060
			.bss	188716	188716
			.data	2464	2464
			.text	1444492	1444492
	lock	cy8ckit_062s2_43012	(read only)	815088	815088
			(read/write)	`1672748`	`1672748`
			.bss	215796	215796
			.data	2456	2456
			.text	1446108	1446108
qpg	lighting-app	qpg6105+debug	(read/write)	1132360	1132360
			.bss	102580	102580
			.data	844	844
			.text	644744	644744
	lock-app	qpg6105+debug	(read/write)	1092360	1092360
			.bss	97252	97252
			.data	856	856
			.text	604740	604740
stm32	light	STM32WB5MM-DK	(read/write)	603949	603949
			.bss	128436	128436
			.data	676	676
			.rodata	80212	80212
			.text	384880	384880

…ghting-app

github-actions · 2024-04-17T21:21:05Z

PR #33036: Size comparison from 035d302 to 732f5a7

Increases above 0.2%:

platform	target	config	section	`035d302`	`732f5a7`	change	% change
bl702	lighting-app	bl702	.rodata	108432	108768	336	0.3
		bl702+mfd	.data	3672	3688	16	0.4
			.rodata	107372	107708	336	0.3
		bl702+rpc	.data	4232	4248	16	0.4
			.rodata	123804	124140	336	0.3
bl702l	lighting-app	bl702l	.data	5056	5072	16	0.3
			.rodata	102436	102772	336	0.3
		bl702l+mfd	.rodata	101376	101712	336	0.3
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	.rodata	82628	82932	304	0.4
	lock-ftd	LP_EM_CC1354P10_6	.data	3576	3588	12	0.3
			.rodata	76716	76916	200	0.3
	lock-mtd	LP_EM_CC1354P10_6	.data	3576	3588	12	0.3
			.rodata	103532	103836	304	0.3
	pump-app	LP_EM_CC1354P10_6	.data	3568	3580	12	0.3
			.rodata	78292	78596	304	0.4
	pump-controller-app	LP_EM_CC1354P10_6	.rodata	74068	74372	304	0.4
cc32xx	lock	CC3235SF_LAUNCHXL	.data	1504	1516	12	0.8
			.rodata	107854	108190	336	0.3
cyw30739	light	cyw930739m2evb_01	.data	752	760	8	1.1
	lock	cyw930739m2evb_01	.data	760	768	8	1.1
	ota-requestor	cyw930739m2evb_01	.data	712	720	8	1.1
	switch	cyw930739m2evb_01	.data	792	800	8	1.0
linux	bridge-app	debug	.data.rel.ro	86976	87168	192	0.2
	lighting-app	debug+rpc+ui	.data	4864	4896	32	0.7
	lock-app	debug	.data	4160	4192	32	0.8
	shell	debug	.rodata	187872	188288	416	0.2
	thermostat-no-ble	arm64	.data	3392	3408	16	0.5
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	rodata	103096	103400	304	0.3
	all-clusters-minimal-app	nrf52840dk_nrf52840	rodata	90360	90664	304	0.3
nxp	contact	k32w0+release	.data	2180	2188	8	0.4
		k32w1+release	.data	2856	2864	8	0.3
	light	k32w0+release	.data	2200	2208	8	0.4
		k32w1+release	.data	2056	2064	8	0.4
psoc6	light	cy8ckit_062s2_43012	.data	2464	2472	8	0.3
	lock	cy8ckit_062s2_43012	.data	2456	2464	8	0.3
qpg	lighting-app	qpg6105+debug	.data	844	856	12	1.4
	lock-app	qpg6105+debug	.data	856	860	4	0.5
stm32	light	STM32WB5MM-DK	.data	676	688	12	1.8
			.rodata	80212	80516	304	0.4

Increases (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)

platform	target	config	section	`035d302`	`732f5a7`	change	% change
bl602	lighting-app	bl602	.data	9504	9512	8	0.1
		bl602+mfd	.data	9480	9488	8	0.1
		bl602+rpc	.data	9880	9888	8	0.1
bl702	lighting-app	bl702	(read/write)	1207927	1209499	1572	0.1
			.data	3696	3704	8	0.2
			.rodata	108432	108768	336	0.3
			.text	977684	978896	1212	0.1
		bl702+mfd	(read/write)	1218743	1220323	1580	0.1
			.data	3672	3688	16	0.4
			.rodata	107372	107708	336	0.3
			.text	989438	990650	1212	0.1
		bl702+rpc	(read/write)	1299407	`1300987`	1580	0.1
			.data	4232	4248	16	0.4
			.rodata	123804	124140	336	0.3
			.text	1052392	1053604	1212	0.1
		bl706-eth	(read/write)	`1025193`	`1025205`	12	0.0
			.text	768388	768400	12	0.0
		bl706-wifi	(read/write)	`1259846`	1259866	20	0.0
			.data	3696	3704	8	0.2
			.text	1000280	1000292	12	0.0
bl702l	lighting-app	bl702l	(read/write)	1177784	`1179336`	1552	0.1
			.data	5056	5072	16	0.3
			.rodata	102436	102772	336	0.3
			.text	970550	971750	1200	0.1
		bl702l+mfd	(read/write)	1188676	1190236	1560	0.1
			.data	5040	5048	8	0.2
			.rodata	101376	101712	336	0.3
			.text	982872	984072	1200	0.1
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	(read only)	782820	783724	904	0.1
			(read/write)	171640	171660	20	0.0
			.bss	93596	93604	8	0.0
			.data	3584	3588	4	0.1
			.rodata	82628	82932	304	0.4
			.text	699928	700528	600	0.1
	lock-ftd	LP_EM_CC1354P10_6	(read only)	798804	799580	776	0.1
			(read/write)	182112	182148	36	0.0
			.bss	104084	104092	8	0.0
			.data	3576	3588	12	0.3
			.rodata	76716	76916	200	0.3
			.text	721820	722396	576	0.1
	lock-mtd	LP_EM_CC1354P10_6	(read only)	787572	788476	904	0.1
			(read/write)	176232	176268	36	0.0
			.bss	98204	98212	8	0.0
			.data	3576	3588	12	0.3
			.rodata	103532	103836	304	0.3
			.text	683776	684376	600	0.1
	pump-app	LP_EM_CC1354P10_6	(read only)	739884	740796	912	0.1
			(read/write)	170600	170636	36	0.0
			.bss	92336	92344	8	0.0
			.data	3568	3580	12	0.3
			.rodata	78292	78596	304	0.4
			.text	661328	661936	608	0.1
	pump-controller-app	LP_EM_CC1354P10_6	(read only)	725516	726420	904	0.1
			(read/write)	170824	170844	20	0.0
			.bss	92560	92568	8	0.0
			.data	3568	3572	4	0.1
			.rodata	74068	74372	304	0.4
			.text	651184	651784	600	0.1
cc32xx	air-purifier	CC3235SF_LAUNCHXL	(read/write)	208096	208100	4	0.0
			.data	1648	1652	4	0.2
	lock	CC3235SF_LAUNCHXL	(read only)	631766	633142	1376	0.2
			(read/write)	208352	208364	12	0.0
			.data	1504	1516	12	0.8
			.rodata	107854	108190	336	0.3
			.text	521792	522832	1040	0.2
cyw30739	light	cyw930739m2evb_01	(read/write)	569783	570455	672	0.1
			.app_xip_area	459709	460365	656	0.1
			.bss	64900	64908	8	0.0
			.data	752	760	8	1.1
	lock	cyw930739m2evb_01	(read/write)	551999	552671	672	0.1
			.app_xip_area	437253	437909	656	0.2
			.bss	69564	69572	8	0.0
			.data	760	768	8	1.1
	ota-requestor	cyw930739m2evb_01	(read/write)	573111	573223	112	0.0
			.app_xip_area	464533	464629	96	0.0
			.bss	63444	63452	8	0.0
			.data	712	720	8	1.1
	switch	cyw930739m2evb_01	(read/write)	565063	565727	664	0.1
			.app_xip_area	453301	453949	648	0.1
			.bss	66548	66556	8	0.0
			.data	792	800	8	1.0
efr32	lighting-app	BRD4187C	(read/write)	`1068480`	1069472	992	0.1
			.bss	179904	179912	8	0.0
			.data	3424	3432	8	0.2
			.text	885132	886108	976	0.1
	lock-app	BRD4338a	(read/write)	960724	962068	1344	0.1
			.data	30272	30288	16	0.1
			.text	700848	702176	1328	0.2
	window-app	BRD4187C	(read/write)	1134380	`1135884`	1504	0.1
			.bss	164504	164512	8	0.0
			.data	3328	3336	8	0.2
			.text	966528	968016	1488	0.2
esp32	all-clusters-app	c3devkit	(read only)	`1213674`	1214260	586	0.0
			(read/write)	`1750368`	1750696	328	0.0
			.dram0.data	13628	13636	8	0.1
			.flash.rodata	252880	253192	312	0.1
			.flash.text	`1213674`	1214260	586	0.0
		m5stack	(read only)	`1256271`	1256843	572	0.0
			(read/write)	536652	536956	304	0.1
			.flash.rodata	284488	284792	304	0.1
			.flash.text	1250107	1250679	572	0.0
linux	all-clusters-app	debug	(read only)	5956929	5962073	5144	0.1
			(read/write)	481512	481672	160	0.0
			.data.rel.ro	334472	334632	160	0.0
			.rodata	351760	352208	448	0.1
			.text	5170387	5174723	4336	0.1
	all-clusters-minimal-app	debug	(read only)	5236873	`5242049`	5176	0.1
			(read/write)	237464	237624	160	0.1
			.data.rel.ro	98056	98216	160	0.2
			.rodata	290410	290858	448	0.2
			.text	4710339	`4714707`	4368	0.1
	bridge-app	debug	(read only)	`4628817`	4634009	5192	0.1
			(read/write)	218344	218536	192	0.1
			.data.rel.ro	86976	87168	192	0.2
			.rodata	230794	231242	448	0.2
			.text	4176323	4180707	4384	0.1
	chip-tool-ipv6only	arm64	.data	4512	4520	8	0.2
	lighting-app	debug+rpc+ui	(read only)	5552929	5558057	5128	0.1
			(read/write)	227112	227304	192	0.1
			.data	4864	4896	32	0.7
			.data.rel.ro	95376	95536	160	0.2
			.rodata	354676	355124	448	0.1
			.text	4950163	4954483	4320	0.1
	lock-app	debug	(read only)	`4694681`	`4699857`	5176	0.1
			(read/write)	205568	205760	192	0.1
			.data	4160	4192	32	0.8
			.data.rel.ro	81000	81160	160	0.2
			.rodata	256586	257034	448	0.2
			.text	`4225459`	4229827	4368	0.1
	shell	debug	(read only)	2923497	2928641	5144	0.2
			(read/write)	156880	157040	160	0.1
			.data.rel.ro	87152	87312	160	0.2
			.rodata	187872	188288	416	0.2
			.text	`2560946`	2565314	4368	0.2
	thermostat-no-ble	arm64	(read only)	4429260	4433564	4304	0.1
			.data	3392	3408	16	0.5
			.data.rel.ro	104296	104424	128	0.1
			.got	8712	8728	16	0.2
			.rodata	160148	160388	240	0.1
			.text	3932568	3936328	3760	0.1
	tv-app	debug	(read only)	5767065	5772241	5176	0.1
			(read/write)	353336	353496	160	0.0
			.data.rel.ro	95160	95320	160	0.2
			.rodata	294730	295178	448	0.2
			.text	5229011	5233379	4368	0.1
	tv-casting-app	debug	(read/write)	342720	342912	192	0.1
			.bss	157976	158168	192	0.1
mbed	lock-app-release	cy8cproto_062_4343w	(read/write)	2534816	2535696	880	0.0
			.text	1497500	1498380	880	0.1
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	`1065016`	1065984	968	0.1
			bss	133107	133119	12	0.0
			rodata	103096	103400	304	0.3
			text	781600	782256	656	0.1
		nrf7002dk_nrf5340_cpuapp	(read/write)	1225908	`1226472`	564	0.0
			bss	127171	127175	4	0.0
			rodata	151304	151368	64	0.0
			text	797400	797900	500	0.1
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read/write)	1012496	`1013584`	1088	0.1
			bss	131965	131977	12	0.0
			rodata	90360	90664	304	0.3
			text	742968	743624	656	0.1
nxp	contact	k32w0+release	(read only)	575100	575756	656	0.1
			(read/write)	80012	80028	16	0.0
			.bss	67848	67856	8	0.0
			.data	2180	2188	8	0.4
			.text	574564	575220	656	0.1
		k32w1+release	(read/write)	702220	703028	808	0.1
			.bss	71192	71200	8	0.0
			.data	2856	2864	8	0.3
			.text	588792	589584	792	0.1
	light	k32w0+release	(read only)	609040	609776	736	0.1
			(read/write)	79472	79488	16	0.0
			.bss	67288	67296	8	0.0
			.data	2200	2208	8	0.4
			.text	608504	609240	736	0.1
		k32w1+release	(read/write)	793992	794968	976	0.1
			.bss	80736	80744	8	0.0
			.data	2056	2064	8	0.4
			.text	671832	672792	960	0.1
psoc6	all-clusters	cy8ckit_062s2_43012	(read/write)	1803444	1804796	1352	0.1
			.bss	198372	198380	8	0.0
			.text	1593996	1595340	1344	0.1
	all-clusters-minimal	cy8ckit_062s2_43012	(read/write)	1725332	1726700	1368	0.1
			.bss	195252	195260	8	0.0
			.text	1519036	1520396	1360	0.1
	light	cy8ckit_062s2_43012	(read/write)	1644060	1645420	1360	0.1
			.bss	188716	188724	8	0.0
			.data	2464	2472	8	0.3
			.text	1444492	1445836	1344	0.1
	lock	cy8ckit_062s2_43012	(read/write)	`1672748`	1674108	1360	0.1
			.bss	215796	215804	8	0.0
			.data	2456	2464	8	0.3
			.text	1446108	1447452	1344	0.1
qpg	lighting-app	qpg6105+debug	(read/write)	1132360	1133316	956	0.1
			.bss	102580	102588	8	0.0
			.data	844	856	12	1.4
			.text	644744	645696	952	0.1
	lock-app	qpg6105+debug	(read/write)	1092360	1093316	956	0.1
			.bss	97252	97260	8	0.0
			.data	856	860	4	0.5
			.text	604740	605700	960	0.2
stm32	light	STM32WB5MM-DK	(read/write)	603949	604921	972	0.2
			.bss	128436	128444	8	0.0
			.data	676	688	12	1.8
			.rodata	80212	80516	304	0.4
			.text	384880	385528	648	0.2
telink	air-quality-sensor-app	tlsr9528a_retention	(read/write)	833042	834086	1044	0.1
			bss	49844	49856	12	0.0
			text	624058	624770	712	0.1
	all-clusters-app	tlsr9518adk80d	(read/write)	1096264	1097308	1044	0.1
			bss	101528	101540	12	0.0
			text	797604	798316	712	0.1
	all-clusters-minimal-app	tlsr9528a	(read/write)	1057728	1058772	1044	0.1
			bss	109976	109988	12	0.0
			text	771966	772678	712	0.1
	bridge-app	tlsr9518adk80d	(read/write)	913120	914156	1036	0.1
			bss	92732	92744	12	0.0
			text	655312	656024	712	0.1
	contact-sensor-app	tlsr9528a_retention	(read/write)	835078	836114	1036	0.1
			bss	49888	49900	12	0.0
			text	626164	626876	712	0.1
	light-switch-app-ota-shell-factory-data	tlsr9528a	(read/write)	935864	936908	1044	0.1
			bss	77500	77512	12	0.0
			text	702830	703542	712	0.1
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	(read/write)	1089632	1090668	1036	0.1
			bss	99824	99836	12	0.0
			text	793420	794132	712	0.1
	lock-app-dfu	tlsr9528a	(read/write)	910316	911360	1044	0.1
			bss	69168	69180	12	0.0
			text	659696	660408	712	0.1
	ota-requestor-app	tlsr9518adk80d	(read/write)	932900	933008	108	0.0
			bss	92436	92448	12	0.0
			text	674972	675066	94	0.0
	pump-app	tlsr9258a	(read/write)	832724	833760	1036	0.1
			bss	58132	58144	12	0.0
			text	623260	623972	712	0.1
	pump-controller-app	tlsr9518adk80d	(read/write)	798852	799888	1036	0.1
			bss	56060	56072	12	0.0
			text	598166	598878	712	0.1
	shell	tlsr9518adk80d	(read/write)	676016	676128	112	0.0
			bss	73412	73424	12	0.0
			text	461764	461864	100	0.0
	smoke_co_alarm-app	tlsr9528a_retention	(read/write)	842810	843854	1044	0.1
			bss	51516	51528	12	0.0
			text	632706	633418	712	0.1
	temperature-measurement-app-mars-ota	tlsr9518adk80d	(read/write)	858565	858673	108	0.0
			bss	59684	59696	12	0.0
			text	642268	642362	94	0.0
	thermostat	tlsr9518adk80d	(read/write)	824400	825436	1036	0.1
			bss	56392	56404	12	0.0
			text	617722	618434	712	0.1
	window-covering	tlsr9258a	(read/write)	837516	838560	1044	0.1
			bss	58348	58360	12	0.0
			text	625630	626342	712	0.1

Decreases (6 builds for linux, psoc6)

platform	target	config	section	`035d302`	`732f5a7`	change	% change
linux	thermostat-no-ble	arm64	(read/write)	246160	245936	-224	-0.1
	tv-casting-app	debug	(read only)	`9897137`	9897057	-80	-0.0
			.text	9045859	9045779	-80	-0.0
psoc6	all-clusters	cy8ckit_062s2_43012	(read only)	832280	832272	-8	-0.0
	all-clusters-minimal	cy8ckit_062s2_43012	(read only)	835432	835424	-8	-0.0
	light	cy8ckit_062s2_43012	(read only)	842160	842144	-16	-0.0
	lock	cy8ckit_062s2_43012	(read only)	815088	815072	-16	-0.0

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)

platform	target	config	section	`035d302`	`732f5a7`	change	% change
bl602	lighting-app	bl602	(read/write)	1443066	1443066	0	0.0
			.bss	85448	85448	0	0.0
			.data	9504	9512	8	0.1
			.rodata	159068	159068	0	0.0
			.text	1108384	1108384	0	0.0
		bl602+mfd	(read/write)	`1457490`	`1457490`	0	0.0
			.bss	85616	85616	0	0.0
			.data	9480	9488	8	0.1
			.rodata	158028	158028	0	0.0
			.text	`1123702`	`1123702`	0	0.0
		bl602+rpc	(read/write)	1490466	1490466	0	0.0
			.bss	93488	93488	0	0.0
			.data	9880	9888	8	0.1
			.rodata	166644	166644	0	0.0
			.text	`1139774`	`1139774`	0	0.0
bl702	lighting-app	bl702	(read only)	3478	3478	0	0.0
			(read/write)	1207927	1209499	1572	0.1
			.bss	11185	11185	0	0.0
			.data	3696	3704	8	0.2
			.rodata	108432	108768	336	0.3
			.text	977684	978896	1212	0.1
		bl702+mfd	(read only)	3478	3478	0	0.0
			(read/write)	1218743	1220323	1580	0.1
			.bss	11361	11361	0	0.0
			.data	3672	3688	16	0.4
			.rodata	107372	107708	336	0.3
			.text	989438	990650	1212	0.1
		bl702+rpc	(read only)	3478	3478	0	0.0
			(read/write)	1299407	`1300987`	1580	0.1
			.bss	19669	19669	0	0.0
			.data	4232	4248	16	0.4
			.rodata	123804	124140	336	0.3
			.text	1052392	1053604	1212	0.1
		bl706-eth	(read/write)	`1025193`	`1025205`	12	0.0
			.bss	23760	23760	0	0.0
			.data	3256	3256	0	0.0
			.rodata	101756	101756	0	0.0
			.text	768388	768400	12	0.0
		bl706-wifi	(read/write)	`1259846`	1259866	20	0.0
			.bss	10645	10645	0	0.0
			.data	3696	3704	8	0.2
			.rodata	122756	122756	0	0.0
			.text	1000280	1000292	12	0.0
bl702l	lighting-app	bl702l	(read/write)	1177784	`1179336`	1552	0.1
			.bss	16396	16396	0	0.0
			.data	5056	5072	16	0.3
			.rodata	102436	102772	336	0.3
			.text	970550	971750	1200	0.1
		bl702l+mfd	(read only)	512	512	0	0.0
			(read/write)	1188676	1190236	1560	0.1
			.bss	16572	16572	0	0.0
			.data	5040	5048	8	0.2
			.rodata	101376	101712	336	0.3
			.text	982872	984072	1200	0.1
cc13x4_26x4	lighting-app	LP_EM_CC1354P10_6	(read only)	782820	783724	904	0.1
			(read/write)	171640	171660	20	0.0
			.bss	93596	93604	8	0.0
			.data	3584	3588	4	0.1
			.rodata	82628	82932	304	0.4
			.text	699928	700528	600	0.1
	lock-ftd	LP_EM_CC1354P10_6	(read only)	798804	799580	776	0.1
			(read/write)	182112	182148	36	0.0
			.bss	104084	104092	8	0.0
			.data	3576	3588	12	0.3
			.rodata	76716	76916	200	0.3
			.text	721820	722396	576	0.1
	lock-mtd	LP_EM_CC1354P10_6	(read only)	787572	788476	904	0.1
			(read/write)	176232	176268	36	0.0
			.bss	98204	98212	8	0.0
			.data	3576	3588	12	0.3
			.rodata	103532	103836	304	0.3
			.text	683776	684376	600	0.1
	pump-app	LP_EM_CC1354P10_6	(read only)	739884	740796	912	0.1
			(read/write)	170600	170636	36	0.0
			.bss	92336	92344	8	0.0
			.data	3568	3580	12	0.3
			.rodata	78292	78596	304	0.4
			.text	661328	661936	608	0.1
	pump-controller-app	LP_EM_CC1354P10_6	(read only)	725516	726420	904	0.1
			(read/write)	170824	170844	20	0.0
			.bss	92560	92568	8	0.0
			.data	3568	3572	4	0.1
			.rodata	74068	74372	304	0.4
			.text	651184	651784	600	0.1
cc32xx	air-purifier	CC3235SF_LAUNCHXL	(read only)	586950	586950	0	0.0
			(read/write)	208096	208100	4	0.0
			.bss	201324	201324	0	0.0
			.data	1648	1652	4	0.2
			.rodata	87502	87502	0	0.0
			.text	497324	497324	0	0.0
	lock	CC3235SF_LAUNCHXL	(read only)	631766	633142	1376	0.2
			(read/write)	208352	208364	12	0.0
			.bss	201728	201728	0	0.0
			.data	1504	1516	12	0.8
			.rodata	107854	108190	336	0.3
			.text	521792	522832	1040	0.2
cyw30739	light	cyw930739m2evb_01	(read/write)	569783	570455	672	0.1
			.app_xip_area	459709	460365	656	0.1
			.bss	64900	64908	8	0.0
			.data	752	760	8	1.1
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	lock	cyw930739m2evb_01	(read/write)	551999	552671	672	0.1
			.app_xip_area	437253	437909	656	0.2
			.bss	69564	69572	8	0.0
			.data	760	768	8	1.1
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	ota-requestor	cyw930739m2evb_01	(read/write)	573111	573223	112	0.0
			.app_xip_area	464533	464629	96	0.0
			.bss	63444	63452	8	0.0
			.data	712	720	8	1.1
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
	switch	cyw930739m2evb_01	(read/write)	565063	565727	664	0.1
			.app_xip_area	453301	453949	648	0.1
			.bss	66548	66556	8	0.0
			.data	792	800	8	1.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4187C	(read/write)	`1068480`	1069472	992	0.1
			.bss	179904	179912	8	0.0
			.data	3424	3432	8	0.2
			.text	885132	886108	976	0.1
	lock-app	BRD4338a	(read/write)	960724	962068	1344	0.1
			.bss	210236	210236	0	0.0
			.data	30272	30288	16	0.1
			.text	700848	702176	1328	0.2
	window-app	BRD4187C	(read/write)	1134380	`1135884`	1504	0.1
			.bss	164504	164512	8	0.0
			.data	3328	3336	8	0.2
			.text	966528	968016	1488	0.2
esp32	all-clusters-app	c3devkit	(read only)	`1213674`	1214260	586	0.0
			(read/write)	`1750368`	1750696	328	0.0
			.dram0.bss	74328	74328	0	0.0
			.dram0.data	13628	13636	8	0.1
			.flash.rodata	252880	253192	312	0.1
			.flash.text	`1213674`	1214260	586	0.0
			.iram0.text	75530	75530	0	0.0
		m5stack	(read only)	`1256271`	1256843	572	0.0
			(read/write)	536652	536956	304	0.1
			.dram0.bss	81064	81064	0	0.0
			.dram0.data	35180	35180	0	0.0
			.flash.rodata	284488	284792	304	0.1
			.flash.text	1250107	1250679	572	0.0
			.iram0.text	125403	125403	0	0.0
linux	air-purifier-app	debug	(read only)	2647317	2647317	0	0.0
			(read/write)	130032	130032	0	0.0
			.bss	46728	46728	0	0.0
			.data	2272	2272	0	0.0
			.data.rel.ro	75080	75080	0	0.0
			.dynamic	608	608	0	0.0
			.got	4520	4520	0	0.0
			.init	27	27	0	0.0
			.init_array	800	800	0	0.0
			.rodata	185392	185392	0	0.0
			.text	`2282933`	`2282933`	0	0.0
	all-clusters-app	debug	(read only)	5956929	5962073	5144	0.1
			(read/write)	481512	481672	160	0.0
			.bss	135040	135040	0	0.0
			.data	4560	4560	0	0.0
			.data.rel.ro	334472	334632	160	0.0
			.dynamic	624	624	0	0.0
			.got	5328	5328	0	0.0
			.init	27	27	0	0.0
			.init_array	1440	1440	0	0.0
			.rodata	351760	352208	448	0.1
			.text	5170387	5174723	4336	0.1
	all-clusters-minimal-app	debug	(read only)	5236873	`5242049`	5176	0.1
			(read/write)	237464	237624	160	0.1
			.bss	127872	127872	0	0.0
			.data	4464	4464	0	0.0
			.data.rel.ro	98056	98216	160	0.2
			.dynamic	624	624	0	0.0
			.got	5248	5248	0	0.0
			.init	27	27	0	0.0
			.init_array	1168	1168	0	0.0
			.rodata	290410	290858	448	0.2
			.text	4710339	`4714707`	4368	0.1
	bridge-app	debug	(read only)	`4628817`	4634009	5192	0.1
			(read/write)	218344	218536	192	0.1
			.bss	118400	118400	0	0.0
			.data	6240	6240	0	0.0
			.data.rel.ro	86976	87168	192	0.2
			.dynamic	624	624	0	0.0
			.got	5216	5216	0	0.0
			.init	27	27	0	0.0
			.init_array	864	864	0	0.0
			.rodata	230794	231242	448	0.2
			.text	4176323	4180707	4384	0.1
	chip-tool	debug	(read only)	12084641	12084641	0	0.0
			(read/write)	523104	523104	0	0.0
			.bss	94744	94744	0	0.0
			.data	5122	5122	0	0.0
			.data.rel.ro	416000	416000	0	0.0
			.dynamic	624	624	0	0.0
			.got	5736	5736	0	0.0
			.init	27	27	0	0.0
			.init_array	832	832	0	0.0
			.rodata	451449	451449	0	0.0
			.text	10924835	10924835	0	0.0
	chip-tool-ipv6only	arm64	(read only)	11403972	11403972	0	0.0
			(read/write)	587232	587232	0	0.0
			.bss	103720	103720	0	0.0
			.data	4512	4520	8	0.2
			.data.rel.ro	455936	455936	0	0.0
			.dynamic	512	512	0	0.0
			.got	17112	17112	0	0.0
			.init	24	24	0	0.0
			.init_array	280	280	0	0.0
			.rodata	356260	356260	0	0.0
			.text	10166024	10166024	0	0.0
	lighting-app	debug+rpc+ui	(read only)	5552929	5558057	5128	0.1
			(read/write)	227112	227304	192	0.1
			.bss	119344	119344	0	0.0
			.data	4864	4896	32	0.7
			.data.rel.ro	95376	95536	160	0.2
			.dynamic	672	672	0	0.0
			.got	5856	5856	0	0.0
			.init	27	27	0	0.0
			.init_array	976	976	0	0.0
			.rodata	354676	355124	448	0.1
			.text	4950163	4954483	4320	0.1
	lock-app	debug	(read only)	`4694681`	`4699857`	5176	0.1
			(read/write)	205568	205760	192	0.1
			.bss	113704	113704	0	0.0
			.data	4160	4192	32	0.8
			.data.rel.ro	81000	81160	160	0.2
			.dynamic	624	624	0	0.0
			.got	5168	5168	0	0.0
			.init	27	27	0	0.0
			.init_array	880	880	0	0.0
			.rodata	256586	257034	448	0.2
			.text	`4225459`	4229827	4368	0.1
	ota-provider-app	debug	(read only)	4310161	4310161	0	0.0
			(read/write)	194200	194200	0	0.0
			.bss	113440	113440	0	0.0
			.data	4368	4368	0	0.0
			.data.rel.ro	70448	70448	0	0.0
			.dynamic	624	624	0	0.0
			.got	4536	4536	0	0.0
			.init	27	27	0	0.0
			.init_array	752	752	0	0.0
			.rodata	209642	209642	0	0.0
			.text	3906035	3906035	0	0.0
	ota-requestor-app	debug	(read only)	4440993	4440993	0	0.0
			(read/write)	198568	198568	0	0.0
			.bss	114336	114336	0	0.0
			.data	4768	4768	0	0.0
			.data.rel.ro	73536	73536	0	0.0
			.dynamic	624	624	0	0.0
			.got	4472	4472	0	0.0
			.init	27	27	0	0.0
			.init_array	800	800	0	0.0
			.rodata	215914	215914	0	0.0
			.text	4026051	4026051	0	0.0
	shell	debug	(read only)	2923497	2928641	5144	0.2
			(read/write)	156880	157040	160	0.1
			.bss	62512	62512	0	0.0
			.data	1424	1424	0	0.0
			.data.rel.ro	87152	87312	160	0.2
			.dynamic	592	592	0	0.0
			.got	4056	4056	0	0.0
			.init	27	27	0	0.0
			.init_array	1112	1112	0	0.0
			.rodata	187872	188288	416	0.2
			.text	`2560946`	2565314	4368	0.2
	thermostat-no-ble	arm64	(read only)	4429260	4433564	4304	0.1
			(read/write)	246160	245936	-224	-0.1
			.bss	121976	121976	0	0.0
			.data	3392	3408	16	0.5
			.data.rel.ro	104296	104424	128	0.1
			.dynamic	512	512	0	0.0
			.got	8712	8728	16	0.2
			.init	24	24	0	0.0
			.init_array	448	448	0	0.0
			.rodata	160148	160388	240	0.1
			.text	3932568	3936328	3760	0.1
	tv-app	debug	(read only)	5767065	5772241	5176	0.1
			(read/write)	353336	353496	160	0.0
			.bss	244336	244336	0	0.0
			.data	6560	6560	0	0.0
			.data.rel.ro	95160	95320	160	0.2
			.dynamic	624	624	0	0.0
			.got	5464	5464	0	0.0
			.init	27	27	0	0.0
			.init_array	1184	1184	0	0.0
			.rodata	294730	295178	448	0.2
			.text	5229011	5233379	4368	0.1
	tv-casting-app	debug	(read only)	`9897137`	9897057	-80	-0.0
			(read/write)	342720	342912	192	0.1
			.bss	157976	158168	192	0.1
			.data	3008	3008	0	0.0
			.data.rel.ro	174848	174848	0	0.0
			.dynamic	624	624	0	0.0
			.got	5040	5040	0	0.0
			.init	27	27	0	0.0
			.init_array	1216	1216	0	0.0
			.rodata	384472	384472	0	0.0
			.text	9045859	9045779	-80	-0.0
mbed	lock-app-release	cy8cproto_062_4343w	(read only)	6224	6224	0	0.0
			(read/write)	2534816	2535696	880	0.0
			.bss	220488	220488	0	0.0
			.data	5216	5216	0	0.0
			.text	1497500	1498380	880	0.1
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	`1065016`	1065984	968	0.1
			bss	133107	133119	12	0.0
			rodata	103096	103400	304	0.3
			text	781600	782256	656	0.1
		nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0	0.0
			(read/write)	1225908	`1226472`	564	0.0
			bss	127171	127175	4	0.0
			rodata	151304	151368	64	0.0
			text	797400	797900	500	0.1
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1012496	`1013584`	1088	0.1
			bss	131965	131977	12	0.0
			rodata	90360	90664	304	0.3
			text	742968	743624	656	0.1
nxp	contact	k32w0+release	(read only)	575100	575756	656	0.1
			(read/write)	80012	80028	16	0.0
			.bss	67848	67856	8	0.0
			.data	2180	2188	8	0.4
			.text	574564	575220	656	0.1
		k32w1+release	(read only)	1024	1024	0	0.0
			(read/write)	702220	703028	808	0.1
			.bss	71192	71200	8	0.0
			.data	2856	2864	8	0.3
			.text	588792	589584	792	0.1
	light	k32w0+release	(read only)	609040	609776	736	0.1
			(read/write)	79472	79488	16	0.0
			.bss	67288	67296	8	0.0
			.data	2200	2208	8	0.4
			.text	608504	609240	736	0.1
		k32w1+release	(read only)	1024	1024	0	0.0
			(read/write)	793992	794968	976	0.1
			.bss	80736	80744	8	0.0
			.data	2056	2064	8	0.4
			.text	671832	672792	960	0.1
psoc6	all-clusters	cy8ckit_062s2_43012	(read only)	832280	832272	-8	-0.0
			(read/write)	1803444	1804796	1352	0.1
			.bss	198372	198380	8	0.0
			.data	2688	2688	0	0.0
			.text	1593996	1595340	1344	0.1
	all-clusters-minimal	cy8ckit_062s2_43012	(read only)	835432	835424	-8	-0.0
			(read/write)	1725332	1726700	1368	0.1
			.bss	195252	195260	8	0.0
			.data	2656	2656	0	0.0
			.text	1519036	1520396	1360	0.1
	light	cy8ckit_062s2_43012	(read only)	842160	842144	-16	-0.0
			(read/write)	1644060	1645420	1360	0.1
			.bss	188716	188724	8	0.0
			.data	2464	2472	8	0.3
			.text	1444492	1445836	1344	0.1
	lock	cy8ckit_062s2_43012	(read only)	815088	815072	-16	-0.0
			(read/write)	`1672748`	1674108	1360	0.1
			.bss	215796	215804	8	0.0
			.data	2456	2464	8	0.3
			.text	1446108	1447452	1344	0.1
qpg	lighting-app	qpg6105+debug	(read/write)	1132360	1133316	956	0.1
			.bss	102580	102588	8	0.0
			.data	844	856	12	1.4
			.text	644744	645696	952	0.1
	lock-app	qpg6105+debug	(read/write)	1092360	1093316	956	0.1
			.bss	97252	97260	8	0.0
			.data	856	860	4	0.5
			.text	604740	605700	960	0.2
stm32	light	STM32WB5MM-DK	(read/write)	603949	604921	972	0.2
			.bss	128436	128444	8	0.0
			.data	676	688	12	1.8
			.rodata	80212	80516	304	0.4
			.text	384880	385528	648	0.2
telink	air-quality-sensor-app	tlsr9528a_retention	(read only)	51774	51774	0	0.0
			(read/write)	833042	834086	1044	0.1
			bss	49844	49856	12	0.0
			text	624058	624770	712	0.1
	all-clusters-app	tlsr9518adk80d	(read only)	29042	29042	0	0.0
			(read/write)	1096264	1097308	1044	0.1
			bss	101528	101540	12	0.0
			text	797604	798316	712	0.1
	all-clusters-minimal-app	tlsr9528a	(read only)	47960	47960	0	0.0
			(read/write)	1057728	1058772	1044	0.1
			bss	109976	109988	12	0.0
			text	771966	772678	712	0.1
	bridge-app	tlsr9518adk80d	(read only)	29042	29042	0	0.0
			(read/write)	913120	914156	1036	0.1
			bss	92732	92744	12	0.0
			text	655312	656024	712	0.1
	contact-sensor-app	tlsr9528a_retention	(read only)	51774	51774	0	0.0
			(read/write)	835078	836114	1036	0.1
			bss	49888	49900	12	0.0
			text	626164	626876	712	0.1
	light-switch-app-ota-shell-factory-data	tlsr9528a	(read only)	51584	51584	0	0.0
			(read/write)	935864	936908	1044	0.1
			bss	77500	77512	12	0.0
			text	702830	703542	712	0.1
	lighting-app-ota-rpc-factory-data-4mb	tlsr9518adk80d	(read only)	29122	29122	0	0.0
			(read/write)	1089632	1090668	1036	0.1
			bss	99824	99836	12	0.0
			text	793420	794132	712	0.1
	lock-app-dfu	tlsr9528a	(read only)	51584	51584	0	0.0
			(read/write)	910316	911360	1044	0.1
			bss	69168	69180	12	0.0
			text	659696	660408	712	0.1
	ota-requestor-app	tlsr9518adk80d	(read only)	29042	29042	0	0.0
			(read/write)	932900	933008	108	0.0
			bss	92436	92448	12	0.0
			text	674972	675066	94	0.0
	pump-app	tlsr9258a	(read only)	52490	52490	0	0.0
			(read/write)	832724	833760	1036	0.1
			bss	58132	58144	12	0.0
			text	623260	623972	712	0.1
	pump-controller-app	tlsr9518adk80d	(read only)	31872	31872	0	0.0
			(read/write)	798852	799888	1036	0.1
			bss	56060	56072	12	0.0
			text	598166	598878	712	0.1
	shell	tlsr9518adk80d	(read only)	29042	29042	0	0.0
			(read/write)	676016	676128	112	0.0
			bss	73412	73424	12	0.0
			text	461764	461864	100	0.0
	smoke_co_alarm-app	tlsr9528a_retention	(read only)	51774	51774	0	0.0
			(read/write)	842810	843854	1044	0.1
			bss	51516	51528	12	0.0
			text	632706	633418	712	0.1
	temperature-measurement-app-mars-ota	tlsr9518adk80d	(read only)	32220	32220	0	0.0
			(read/write)	858565	858673	108	0.0
			bss	59684	59696	12	0.0
			text	642268	642362	94	0.0
	thermostat	tlsr9518adk80d	(read only)	31872	31872	0	0.0
			(read/write)	824400	825436	1036	0.1
			bss	56392	56404	12	0.0
			text	617722	618434	712	0.1
	window-covering	tlsr9258a	(read only)	52490	52490	0	0.0
			(read/write)	837516	838560	1044	0.1
			bss	58348	58360	12	0.0
			text	625630	626342	712	0.1

bzbarsky-apple

Spec says, in "4.3.1.9. TXT key for device name (DN)":

The optional key DN MAY provide a device advertisement name. If present, it SHALL be encoded as a valid UTF-8 string with a maximum length of 32 bytes (matching the maximum length of the NodeLabel string in the Basic Information Cluster).

So if somethiing has a longer name than that, it's violating the spec and should stop doing that.

sharadb-amazon · 2024-04-18T21:26:21Z

Spec says, in "4.3.1.9. TXT key for device name (DN)":

The optional key DN MAY provide a device advertisement name. If present, it SHALL be encoded as a valid UTF-8 string with a maximum length of 32 bytes (matching the maximum length of the NodeLabel string in the Basic Information Cluster).

So if somethiing has a longer name than that, it's violating the spec and should stop doing that.

Understood. Canceling this PR for now.

Make chip::Dnssd::kMaxDeviceNameLen configurable

9961c45

github-actions bot added examples platform lib labels Apr 17, 2024

pullapprove bot requested review from andy31415, andyg-apple, anush-apple, arkq, bzbarsky-apple, carol-apple, cecille, chrisdecenzo, chshu, chulspro, cliffamzn, Damian-Nordic, dhrishi, harimau-qirex, harsha-rajendran, hawk248, hicklin, jepenven-silabs and jmartinez-silabs April 17, 2024 20:21

pullapprove bot requested review from younghak-hwang, mhazley, yufengwangca, mkardous-silabs, nivi-apple, p0fi, pidarped, plauric, rcasallas-silabs, robszewczyk, saurabhst, selissia, tcarmelveilleux and tecimovic April 17, 2024 20:21

pullapprove bot added the review - pending label Apr 17, 2024

pullapprove bot requested review from tehampson, tima-q, tobiasgraf, turon, vivien-apple, wiba-nordic, woody-apple, younghak-hwang and yufengwangca April 17, 2024 20:21

Setting CHIP_DEVICE_CONFIG_MAX_DEVICE_NAME_LEN for esp32 and stm32 li…

732f5a7

…ghting-app

bzbarsky-apple requested changes Apr 17, 2024

View reviewed changes

sharadb-amazon closed this Apr 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make chip::Dnssd::kMaxDeviceNameLen configurable #33036

Make chip::Dnssd::kMaxDeviceNameLen configurable #33036

sharadb-amazon commented Apr 17, 2024 •

edited

Loading

github-actions bot commented Apr 17, 2024 •

edited

Loading

github-actions bot commented Apr 17, 2024 •

edited

Loading

bzbarsky-apple left a comment

sharadb-amazon commented Apr 18, 2024

Make chip::Dnssd::kMaxDeviceNameLen configurable #33036

Make chip::Dnssd::kMaxDeviceNameLen configurable #33036

Conversation

sharadb-amazon commented Apr 17, 2024 • edited Loading

Change Summary

Testing

github-actions bot commented Apr 17, 2024 • edited Loading

github-actions bot commented Apr 17, 2024 • edited Loading

bzbarsky-apple left a comment

Choose a reason for hiding this comment

sharadb-amazon commented Apr 18, 2024

sharadb-amazon commented Apr 17, 2024 •

edited

Loading

github-actions bot commented Apr 17, 2024 •

edited

Loading

github-actions bot commented Apr 17, 2024 •

edited

Loading