-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infineon] Update CYW30739 to support CYW30739B2-P5-EVK-XX boards. #33065
Conversation
PR #33065: Size comparison from f084d65 to febacad Decreases (2 builds for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
febacad
to
a8f177d
Compare
Rebase to clear conflicts. |
PR #33065: Size comparison from 8dd2de7 to a8f177d Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32)
|
* Replace CYW30739 submodules with the matter-wpan-sdk submodule. * Update README files for CYW30739 apps. * Add CYW30739B2-P5-EVK-01, CYW30739B2-P5-EVK-02, and CYW30739B2-P5-EVK-03 boards for CYW30739. * Add development DAC files for CYW30739. * Add cyw30739_example, cyw30739_platform, and ifx_openthread template for board dependant targets. * Update GN files for CYW30739 apps. * Update CYW30739 builder scripts. configuration in the .gitmodules file. * Update the CYW30739 flashing script. * Update the workflow to build all CYW30739-supported targets. * Move shared codes to the matter_config.cpp file. * Implemented FactoryDataProvider for CYW30739 to load factory data.
a8f177d
to
ff3f129
Compare
PR #33065: Size comparison from 8dd2de7 to ff3f129 Decreases (1 build for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having each target compile every possible supported board seems off. We can do that as part of CI, however auto-selecting all boards as part of the build seems strange.
We didn't remove the ability to let the developer build only a specified board. We documented how to do it in README files. The below instruction is a part of the CYW30739 app README file: $ cd ~/connectedhomeip
$ source scripts/activate.sh
$ gn gen --root=examples/lighting-app/infineon/cyw30739 out/cyw30739-light
$ ninja -C out/cyw30739-light [lighting_app-BOARD_NAME] I also noticed that the |
f151a5e
to
8ec1a15
Compare
8ec1a15
to
c66c280
Compare
PR #33065: Size comparison from bc0f5ee to c66c280 Decreases (2 builds for efr32)
Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
Update the checkout_submodules.py script to support the recursive configuration in the .gitmodules file. #33089)