Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NSCache for the MTRDevice attribute cache when possible. #33125

Merged
merged 3 commits into from
Apr 24, 2024
+243 −70
Merged

Use NSCache for the MTRDevice attribute cache when possible. #33125

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db118ac
Use NSCache for the MTRDevice attribute cache when possible.
bzbarsky-apple Apr 23, 2024
951e0f2
Update src/darwin/Framework/CHIP/MTRDevice.mm
woody-apple Apr 23, 2024
b433d18
Update src/darwin/Framework/CHIP/MTRDevice.mm
woody-apple Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Loading
Loading status checks…
Update src/darwin/Framework/CHIP/MTRDevice.mm 
Co-authored-by: Jeff Tung <100387939+jtung-apple@users.noreply.github.com>
@woody-apple @jtung-apple
woody-apple and jtung-apple authored Apr 23, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit b433d182bf99df164169bca806b53615996ce73f
2 changes: 1 addition & 1 deletion src/darwin/Framework/CHIP/MTRDevice.mm
View file
Original file line number Diff line number Diff line change
@@ -368,7 +368,7 @@ @implementation MTRDevice {
// don't have persistence enabled, this is our only data store. Nil if we
// currently have nothing that could need persisting.
NSMutableDictionary<MTRClusterPath *, MTRDeviceClusterData *> * _Nullable _clusterDataToPersist;
// _existingClusters stores the set of "valid" keys into _persistedClusterData.
// _persistedClusters stores the set of "valid" keys into _persistedClusterData.
// These are keys that could have values in _persistedClusterData even if they don't
// right now (because they have been evicted).
NSMutableSet<MTRClusterPath *> * _persistedClusters;